Conditions | 12 |
Paths | 257 |
Total Lines | 112 |
Lines | 38 |
Ratio | 33.93 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
48 | function load_assets( $attr, $content ) { |
||
49 | |||
50 | if ( ! verify_connection() ) { |
||
51 | return null; |
||
52 | } |
||
53 | |||
54 | $values = get_attributes_with_defaults( $attr ); |
||
55 | $blog_id = ( defined( 'IS_WPCOM' ) && IS_WPCOM ) |
||
56 | ? get_current_blog_id() |
||
57 | : Jetpack_Options::get_option( 'id' ); |
||
58 | Jetpack_Gutenberg::load_assets_as_required( FEATURE_NAME ); |
||
59 | $classes = Jetpack_Gutenberg::block_classes( FEATURE_NAME, $attr ); |
||
60 | $amp_form_action = sprintf( 'https://public-api.wordpress.com/rest/v1.1/sites/%s/email_follow/amp/subscribe/', $blog_id ); |
||
61 | $is_amp_request = class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request(); |
||
62 | |||
63 | ob_start(); |
||
64 | ?> |
||
65 | |||
66 | <div class="<?php echo esc_attr( $classes ); ?>" data-blog-id="<?php echo esc_attr( $blog_id ); ?>"> |
||
67 | <div class="components-placeholder"> |
||
68 | <form |
||
69 | aria-describedby="wp-block-jetpack-mailchimp_consent-text" |
||
70 | <?php if ( $is_amp_request ) : ?> |
||
71 | action-xhr="<?php echo esc_url( $amp_form_action ); ?>" |
||
72 | method="post" |
||
73 | id="mailchimp_form" |
||
74 | target="_top" |
||
75 | on="submit-success:AMP.setState( { mailing_list_status: 'subscribed', mailing_list_email: event.response.email } )" |
||
76 | <?php endif; ?> |
||
77 | > |
||
78 | <p> |
||
79 | <input |
||
80 | aria-label="<?php echo esc_attr( $values['emailPlaceholder'] ); ?>" |
||
81 | placeholder="<?php echo esc_attr( $values['emailPlaceholder'] ); ?>" |
||
82 | required |
||
83 | title="<?php echo esc_attr( $values['emailPlaceholder'] ); ?>" |
||
84 | type="email" |
||
85 | name="email" |
||
86 | /> |
||
87 | </p> |
||
88 | <?php foreach ( is_array( $values['interests'] ) ? $values['interests'] : array() as $interest ) : ?> |
||
89 | <input |
||
90 | name="interests[<?php echo esc_attr( $interest ); ?>]" |
||
91 | type="hidden" |
||
92 | class="mc-submit-param" |
||
93 | value="1" |
||
94 | /> |
||
95 | <?php endforeach; ?> |
||
96 | <?php |
||
97 | if ( |
||
98 | ! empty( $values['signupFieldTag'] ) |
||
99 | && ! empty( $values['signupFieldValue'] ) |
||
100 | ) : |
||
101 | ?> |
||
102 | <input |
||
103 | name="merge_fields[<?php echo esc_attr( $values['signupFieldTag'] ); ?>]" |
||
104 | type="hidden" |
||
105 | class="mc-submit-param" |
||
106 | value="<?php echo esc_attr( $values['signupFieldValue'] ); ?>" |
||
107 | /> |
||
108 | <?php endif; ?> |
||
109 | <?php echo render_button( $attr, $content ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?> |
||
110 | <p id="wp-block-jetpack-mailchimp_consent-text"> |
||
111 | <?php echo wp_kses_post( $values['consentText'] ); ?> |
||
112 | </p> |
||
113 | |||
114 | View Code Duplication | <?php if ( $is_amp_request ) : ?> |
|
115 | |||
116 | <div submit-success> |
||
117 | <template type="amp-mustache"> |
||
118 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_success wp-block-jetpack-mailchimp__is-amp"> |
||
119 | <?php echo esc_html( $values['successLabel'] ); ?> |
||
120 | </div> |
||
121 | </template> |
||
122 | </div> |
||
123 | <div submit-error> |
||
124 | <template type="amp-mustache"> |
||
125 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_error wp-block-jetpack-mailchimp__is-amp"> |
||
126 | <?php echo esc_html( $values['errorLabel'] ); ?> |
||
127 | </div> |
||
128 | </template> |
||
129 | </div> |
||
130 | <div submitting> |
||
131 | <template type="amp-mustache"> |
||
132 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_processing wp-block-jetpack-mailchimp__is-amp" role="status"> |
||
133 | <?php echo esc_html( $values['processingLabel'] ); ?> |
||
134 | </div> |
||
135 | </template> |
||
136 | </div> |
||
137 | |||
138 | <?php endif; ?> |
||
139 | |||
140 | </form> |
||
141 | View Code Duplication | <?php if ( ! $is_amp_request ) : ?> |
|
142 | |||
143 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_processing" role="status"> |
||
144 | <?php echo esc_html( $values['processingLabel'] ); ?> |
||
145 | </div> |
||
146 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_success" role="status"> |
||
147 | <?php echo esc_html( $values['successLabel'] ); ?> |
||
148 | </div> |
||
149 | <div class="wp-block-jetpack-mailchimp_notification wp-block-jetpack-mailchimp_error" role="alert"> |
||
150 | <?php echo esc_html( $values['errorLabel'] ); ?> |
||
151 | </div> |
||
152 | |||
153 | <?php endif; ?> |
||
154 | </div> |
||
155 | </div> |
||
156 | <?php |
||
157 | $html = ob_get_clean(); |
||
158 | return $html; |
||
159 | } |
||
160 | |||
267 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.