Test_Manager::setUp() - Code Metrics - Inspection of "Fix a rebase conflict" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/sync-classmapped-package ( bf1ff0...7eeaec )

by Marin

created 2019-06-06 08:29 UTC

Test_Manager::setUp() A

↳ Parent: Test_Manager

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

use Automattic\Jetpack\Constants\Manager as Constants_Manager;
use PHPUnit\Framework\TestCase;

class Test_Manager extends TestCase {
	public function setUp() {
		if ( ! defined( 'JETPACK__VERSION' ) ) {
			define( 'JETPACK__VERSION', '7.5' );
		}
	}

	public function tearDown() {
		parent::tearDown();
		Constants_Manager::$set_constants = array();
	}

	// Constants_Manager::is_defined()

	function test_jetpack_constants_is_defined_when_constant_set_via_class() {
		Constants_Manager::set_constant( 'TEST', 'hello' );
		$this->assertTrue( Constants_Manager::is_defined( 'TEST' ) );
	}

	function test_jetpack_constants_is_defined_false_when_constant_not_set() {
		$this->assertFalse( Constants_Manager::is_defined( 'UNDEFINED' ) );
	}

	function test_jetpack_constants_is_defined_true_when_set_with_define() {
		$this->assertTrue( Constants_Manager::is_defined( 'JETPACK__VERSION' ) );
	}

	function test_jetpack_constants_is_defined_when_constant_set_to_null() {
		Constants_Manager::set_constant( 'TEST', null );
		$this->assertTrue( Constants_Manager::is_defined( 'TEST' ) );
	}

	// Constants_Manager::get_constant()

	function test_jetpack_constants_default_to_constant() {
		$this->assertEquals( Constants_Manager::get_constant( 'JETPACK__VERSION' ), JETPACK__VERSION );
	}

	function test_jetpack_constants_get_constant_null_when_not_set() {
		$this->assertNull( Constants_Manager::get_constant( 'UNDEFINED' ) );
	}

	function test_jetpack_constants_can_override_previously_defined_constant() {
		$test_version = '1.0.0';
		Constants_Manager::set_constant( 'JETPACK__VERSION', $test_version );
		$this->assertEquals( Constants_Manager::get_constant( 'JETPACK__VERSION' ), $test_version );
	}

	function test_jetpack_constants_override_to_null_gets_null() {
		Constants_Manager::set_constant( 'JETPACK__VERSION', null );
		$this->assertNull( Constants_Manager::get_constant( 'JETPACK__VERSION' ) );
	}

	// Constants_Manager::set_constant()

	function test_jetpack_constants_set_constants_adds_to_set_constants_array() {
		$key = 'TEST';
		Constants_Manager::set_constant( $key, '1' );
		$this->assertArrayHasKey( $key, Constants_Manager::$set_constants );
		$this->assertEquals( '1', Constants_Manager::$set_constants[ $key ] );
	}

	// Constants_Manager::clear_constants()

	function test_jetpack_constants_can_clear_all_constants() {
		Constants_Manager::set_constant( 'JETPACK__VERSION', '1.0.0' );
		Constants_Manager::clear_constants();
		$this->assertEmpty( Constants_Manager::$set_constants );
	}

	// Constants_Manager::clear_single_constant()

	function test_jetpack_constants_can_clear_single_constant() {
		Constants_Manager::set_constant( 'FIRST', '1' );
		Constants_Manager::set_constant( 'SECOND', '2' );

		$this->assertCount( 2, Constants_Manager::$set_constants );

		Constants_Manager::clear_single_constant( 'FIRST' );

		$this->assertCount( 1, Constants_Manager::$set_constants );
		$this->assertContains( 'SECOND', array_keys( Constants_Manager::$set_constants ) );
	}

	function test_jetpack_constants_can_clear_single_constant_when_null() {
		Constants_Manager::set_constant( 'TEST', null );
		$this->assertCount( 1, Constants_Manager::$set_constants );

		Constants_Manager::clear_single_constant( 'TEST' );

		$this->assertEmpty( Constants_Manager::$set_constants );
	}

	// Jetpack_Constant::is_true
	function test_jetpack_constants_is_true_method() {
		$this->assertFalse( Constants_Manager::is_true( 'FOO' ), 'unset constant returns true' );
		Constants_Manager::set_constant( 'FOO', false );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$this->assertFalse( Constants_Manager::is_true( 'FOO' ), 'false constant returns true' );
		Constants_Manager::set_constant( 'FOO', true );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$this->assertTrue( Constants_Manager::is_true( 'FOO' ), 'true constant returns false');
	}
}


1			<?php
2
3			use Automattic\Jetpack\Constants\Manager as Constants_Manager;
4			use PHPUnit\Framework\TestCase;
5
6			class Test_Manager extends TestCase {
7			public function setUp() {
8			if ( ! defined( 'JETPACK__VERSION' ) ) {
9			define( 'JETPACK__VERSION', '7.5' );
10			}
11			}
12
13			public function tearDown() {
14			parent::tearDown();
15			Constants_Manager::$set_constants = array();
16			}
17
18			// Constants_Manager::is_defined()
19
20			function test_jetpack_constants_is_defined_when_constant_set_via_class() {
21			Constants_Manager::set_constant( 'TEST', 'hello' );
22			$this->assertTrue( Constants_Manager::is_defined( 'TEST' ) );
23			}
24
25			function test_jetpack_constants_is_defined_false_when_constant_not_set() {
26			$this->assertFalse( Constants_Manager::is_defined( 'UNDEFINED' ) );
27			}
28
29			function test_jetpack_constants_is_defined_true_when_set_with_define() {
30			$this->assertTrue( Constants_Manager::is_defined( 'JETPACK__VERSION' ) );
31			}
32
33			function test_jetpack_constants_is_defined_when_constant_set_to_null() {
34			Constants_Manager::set_constant( 'TEST', null );
35			$this->assertTrue( Constants_Manager::is_defined( 'TEST' ) );
36			}
37
38			// Constants_Manager::get_constant()
39
40			function test_jetpack_constants_default_to_constant() {
41			$this->assertEquals( Constants_Manager::get_constant( 'JETPACK__VERSION' ), JETPACK__VERSION );
42			}
43
44			function test_jetpack_constants_get_constant_null_when_not_set() {
45			$this->assertNull( Constants_Manager::get_constant( 'UNDEFINED' ) );
46			}
47
48			function test_jetpack_constants_can_override_previously_defined_constant() {
49			$test_version = '1.0.0';
50			Constants_Manager::set_constant( 'JETPACK__VERSION', $test_version );
51			$this->assertEquals( Constants_Manager::get_constant( 'JETPACK__VERSION' ), $test_version );
52			}
53
54			function test_jetpack_constants_override_to_null_gets_null() {
55			Constants_Manager::set_constant( 'JETPACK__VERSION', null );
56			$this->assertNull( Constants_Manager::get_constant( 'JETPACK__VERSION' ) );
57			}
58
59			// Constants_Manager::set_constant()
60
61			function test_jetpack_constants_set_constants_adds_to_set_constants_array() {
62			$key = 'TEST';
63			Constants_Manager::set_constant( $key, '1' );
64			$this->assertArrayHasKey( $key, Constants_Manager::$set_constants );
65			$this->assertEquals( '1', Constants_Manager::$set_constants[ $key ] );
66			}
67
68			// Constants_Manager::clear_constants()
69
70			function test_jetpack_constants_can_clear_all_constants() {
71			Constants_Manager::set_constant( 'JETPACK__VERSION', '1.0.0' );
72			Constants_Manager::clear_constants();
73			$this->assertEmpty( Constants_Manager::$set_constants );
74			}
75
76			// Constants_Manager::clear_single_constant()
77
78			function test_jetpack_constants_can_clear_single_constant() {
79			Constants_Manager::set_constant( 'FIRST', '1' );
80			Constants_Manager::set_constant( 'SECOND', '2' );
81
82			$this->assertCount( 2, Constants_Manager::$set_constants );
83
84			Constants_Manager::clear_single_constant( 'FIRST' );
85
86			$this->assertCount( 1, Constants_Manager::$set_constants );
87			$this->assertContains( 'SECOND', array_keys( Constants_Manager::$set_constants ) );
88			}
89
90			function test_jetpack_constants_can_clear_single_constant_when_null() {
91			Constants_Manager::set_constant( 'TEST', null );
92			$this->assertCount( 1, Constants_Manager::$set_constants );
93
94			Constants_Manager::clear_single_constant( 'TEST' );
95
96			$this->assertEmpty( Constants_Manager::$set_constants );
97			}
98
99			// Jetpack_Constant::is_true
100			function test_jetpack_constants_is_true_method() {
101			$this->assertFalse( Constants_Manager::is_true( 'FOO' ), 'unset constant returns true' );
102			Constants_Manager::set_constant( 'FOO', false );
			0 ignored issues – show Documentation introduced 2019-06-04 16:45 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
103
104			$this->assertFalse( Constants_Manager::is_true( 'FOO' ), 'false constant returns true' );
105			Constants_Manager::set_constant( 'FOO', true );
			0 ignored issues – show Documentation introduced 2019-06-04 16:45 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106
107			$this->assertTrue( Constants_Manager::is_true( 'FOO' ), 'true constant returns false');
108			}
109			}
110

Automattic / jetpack

Push — add/sync-classmapped-package ( bf1ff0...7eeaec )

Test_Manager::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like