Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | */ |
||
8 | |||
9 | /** |
||
10 | * Translate a 'videopress' or 'wpvideo' shortcode and arguments into a video player display. |
||
11 | * |
||
12 | * Expected input formats: |
||
13 | * |
||
14 | * [videopress OcobLTqC] |
||
15 | * [wpvideo OcobLTqC] |
||
16 | * |
||
17 | * @link http://codex.wordpress.org/Shortcode_API Shortcode API |
||
18 | * @param array $attr shortcode attributes |
||
19 | * @return string HTML markup or blank string on fail |
||
20 | */ |
||
21 | function videopress_shortcode_callback( $attr, $content = '' ) { |
||
22 | global $content_width; |
||
23 | |||
24 | /** |
||
25 | * We only accept GUIDs as a first unnamed argument. |
||
26 | */ |
||
27 | $guid = $attr[0]; |
||
28 | |||
29 | /** |
||
30 | * Make sure the GUID passed in matches how actual GUIDs are formatted. |
||
31 | */ |
||
32 | if ( ! videopress_is_valid_guid( $guid ) ) { |
||
33 | return ''; |
||
34 | } |
||
35 | |||
36 | /** |
||
37 | * Set the defaults |
||
38 | */ |
||
39 | $defaults = array( |
||
40 | 'w' => 0, // Width of the video player, in pixels |
||
41 | 'at' => 0, // How many seconds in to initially seek to |
||
42 | 'hd' => false, // Whether to display a high definition version |
||
43 | 'loop' => false, // Whether to loop the video repeatedly |
||
44 | 'freedom' => false, // Whether to use only free/libre codecs |
||
45 | 'autoplay' => false, // Whether to autoplay the video on load |
||
46 | 'permalink' => true, // Whether to display the permalink to the video |
||
47 | 'flashonly' => false, // Whether to support the Flash player exclusively |
||
48 | 'defaultlangcode' => false, // Default language code |
||
49 | ); |
||
50 | |||
51 | $attr = shortcode_atts( $defaults, $attr, 'videopress' ); |
||
52 | |||
53 | /** |
||
54 | * Cast the attributes, post-input. |
||
55 | */ |
||
56 | $attr['width'] = absint( $attr['w'] ); |
||
57 | $attr['hd'] = (bool) $attr['hd']; |
||
58 | $attr['freedom'] = (bool) $attr['freedom']; |
||
59 | |||
60 | /** |
||
61 | * If the provided width is less than the minimum allowed |
||
62 | * width, or greater than `$content_width` ignore. |
||
63 | */ |
||
64 | if ( $attr['width'] < VIDEOPRESS_MIN_WIDTH ) { |
||
65 | $attr['width'] = 0; |
||
66 | View Code Duplication | } elseif ( isset( $content_width ) && $content_width > VIDEOPRESS_MIN_WIDTH && $attr['width'] > $content_width ) { |
|
67 | $attr['width'] = 0; |
||
68 | } |
||
69 | |||
70 | /** |
||
71 | * If there was an invalid or unspecified width, set the width equal to the theme's `$content_width`. |
||
72 | */ |
||
73 | View Code Duplication | if ( $attr['width'] === 0 && isset( $content_width ) && $content_width > VIDEOPRESS_MIN_WIDTH ) { |
|
74 | $attr['width'] = $content_width; |
||
75 | } |
||
76 | |||
77 | /** |
||
78 | * If the width isn't an even number, reduce it by one (making it even). |
||
79 | */ |
||
80 | if ( ( $attr['width'] % 2 ) === 1 ) { |
||
81 | $attr['width'] --; |
||
82 | } |
||
83 | |||
84 | /** |
||
85 | * Filter the default VideoPress shortcode options. |
||
86 | * |
||
87 | * @module videopress |
||
88 | * |
||
89 | * @since 2.5.0 |
||
90 | * |
||
91 | * @param array $args Array of VideoPress shortcode options. |
||
92 | */ |
||
93 | $options = apply_filters( 'videopress_shortcode_options', array( |
||
94 | 'at' => (int) $attr['at'], |
||
95 | 'hd' => $attr['hd'], |
||
96 | 'loop' => $attr['autoplay'] || $attr['loop'], |
||
97 | 'freedom' => $attr['freedom'], |
||
98 | 'autoplay' => $attr['autoplay'], |
||
99 | 'permalink' => $attr['permalink'], |
||
100 | 'force_flash' => (bool) $attr['flashonly'], |
||
101 | 'defaultlangcode' => $attr['defaultlangcode'], |
||
102 | 'forcestatic' => false, // This used to be a displayed option, but now is only |
||
103 | // accessible via the `videopress_shortcode_options` filter. |
||
104 | ) ); |
||
105 | |||
106 | // Register VideoPress scripts |
||
107 | wp_register_script( 'videopress', 'https://v0.wordpress.com/js/videopress.js', array( 'jquery', 'swfobject' ), '1.09' ); |
||
108 | |||
109 | require_once( dirname( __FILE__ ) . '/class.videopress-video.php' ); |
||
110 | require_once( dirname( __FILE__ ) . '/class.videopress-player.php' ); |
||
111 | |||
112 | $player = new VideoPress_Player( $guid, $attr['width'], $options ); |
||
113 | |||
114 | if ( is_feed() ) { |
||
115 | return $player->asXML(); |
||
116 | } else { |
||
117 | return $player->asHTML(); |
||
118 | } |
||
119 | } |
||
120 | add_shortcode( 'videopress', 'videopress_shortcode_callback' ); |
||
121 | add_shortcode( 'wpvideo', 'videopress_shortcode_callback' ); |
||
122 | |||
123 | /** |
||
124 | * By explicitly declaring the provider here, we can speed things up by not relying on oEmbed discovery. |
||
125 | */ |
||
126 | wp_oembed_add_provider( '#^https?://videopress.com/v/.*#', 'http://public-api.wordpress.com/oembed/1.0/', true ); |
||
127 | |||
128 | /** |
||
129 | * Adds a `for` query parameter to the oembed provider request URL. |
||
130 | * @param String $oembed_provider |
||
131 | * @return String $ehnanced_oembed_provider |
||
132 | */ |
||
133 | function videopress_add_oembed_for_parameter( $oembed_provider ) { |
||
134 | if ( false === stripos( $oembed_provider, 'videopress.com' ) ) { |
||
135 | return $oembed_provider; |
||
136 | } |
||
137 | return add_query_arg( 'for', parse_url( home_url(), PHP_URL_HOST ), $oembed_provider ); |
||
138 | } |
||
139 | add_filter( 'oembed_fetch_url', 'videopress_add_oembed_for_parameter' ); |