Conditions | 58 |
Paths | > 20000 |
Total Lines | 294 |
Code Lines | 199 |
Lines | 16 |
Ratio | 5.44 % |
Changes | 7 | ||
Bugs | 3 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
211 | public static function output_fields($options) { |
||
212 | foreach ($options as $value) { |
||
213 | if ( ! isset($value['type'])) { |
||
214 | continue; |
||
215 | } |
||
216 | if ( ! isset($value['id'])) { |
||
217 | $value['id'] = ''; |
||
218 | } |
||
219 | if ( ! isset($value['title'])) { |
||
220 | $value['title'] = isset($value['name']) ? $value['name'] : ''; |
||
221 | } |
||
222 | if ( ! isset($value['class'])) { |
||
223 | $value['class'] = ''; |
||
224 | } |
||
225 | if ( ! isset($value['css'])) { |
||
226 | $value['css'] = ''; |
||
227 | } |
||
228 | if ( ! isset($value['default'])) { |
||
229 | $value['default'] = ''; |
||
230 | } |
||
231 | if ( ! isset($value['desc'])) { |
||
232 | $value['desc'] = ''; |
||
233 | } |
||
234 | if ( ! isset($value['desc_tip'])) { |
||
235 | $value['desc_tip'] = false; |
||
236 | } |
||
237 | |||
238 | // Custom attribute handling |
||
239 | $custom_attributes = array(); |
||
240 | |||
241 | if ( ! empty($value['custom_attributes']) && is_array($value['custom_attributes'])) { |
||
242 | foreach ($value['custom_attributes'] as $attribute => $attribute_value) { |
||
243 | $custom_attributes[] = esc_attr($attribute).'="'.esc_attr($attribute_value).'"'; |
||
244 | } |
||
245 | } |
||
246 | |||
247 | // Description handling |
||
248 | if ($value['desc_tip'] === true) { |
||
249 | $description = ''; |
||
250 | $tip = $value['desc']; |
||
251 | } else if ( ! empty($value['desc_tip'])) { |
||
252 | $description = $value['desc']; |
||
253 | $tip = $value['desc_tip']; |
||
254 | } else if ( ! empty($value['desc'])) { |
||
255 | $description = $value['desc']; |
||
256 | $tip = ''; |
||
257 | } else { |
||
258 | $description = $tip = ''; |
||
259 | } |
||
260 | |||
261 | View Code Duplication | if ($description && in_array($value['type'], array('textarea', 'radio'))) { |
|
262 | $description = '<p style="margin-top:0">'.wp_kses_post($description).'</p>'; |
||
263 | } else if ($description) { |
||
264 | $description = '<span class="description">'.wp_kses_post($description).'</span>'; |
||
265 | } |
||
266 | |||
267 | View Code Duplication | if ($tip && in_array($value['type'], array('checkbox'))) { |
|
268 | $tip = '<p class="description">'.$tip.'</p>'; |
||
269 | } else if ($tip) { |
||
270 | $tip = '<img class="help_tip" data-tip="'.esc_attr($tip).'" src="'.AUTO_LOAD_NEXT_POST_URL_PATH.'/assets/images/help.png" height="16" width="16" />'; |
||
271 | } |
||
272 | |||
273 | // Switch based on type |
||
274 | switch ($value['type']) { |
||
275 | // Section Titles |
||
276 | case 'title': |
||
277 | if ( ! empty($value['title'])) { |
||
278 | echo '<h3>'.esc_html($value['title']).'</h3>'; |
||
279 | } |
||
280 | |||
281 | if ( ! empty($value['desc'])) { |
||
282 | echo wpautop(wptexturize(wp_kses_post($value['desc']))); |
||
283 | } |
||
284 | |||
285 | echo '<table class="form-table">'."\n\n"; |
||
286 | |||
287 | if ( ! empty($value['id'])) { |
||
288 | do_action('auto_load_next_post_settings_'.sanitize_title($value['id'])); |
||
289 | } |
||
290 | |||
291 | break; |
||
292 | |||
293 | // Section Ends |
||
294 | case 'sectionend': |
||
295 | |||
296 | View Code Duplication | if ( ! empty($value['id'])) { |
|
297 | do_action('auto_load_next_post_settings_'.sanitize_title($value['id']).'_end'); |
||
298 | } |
||
299 | |||
300 | echo '</table>'; |
||
301 | |||
302 | View Code Duplication | if ( ! empty($value['id'])) { |
|
303 | do_action('auto_load_next_post_settings_'.sanitize_title($value['id']).'_after'); |
||
304 | } |
||
305 | |||
306 | break; |
||
307 | |||
308 | // Standard text inputs and subtypes like 'number' |
||
309 | case 'text': |
||
310 | case 'number': |
||
311 | $type = $value['type']; |
||
312 | $class = ''; |
||
313 | $option_value = self::get_option($value['id'], $value['default']); |
||
314 | ?><tr valign="top"> |
||
315 | <th scope="row" class="titledesc"> |
||
316 | <label for="<?php echo esc_attr($value['id']); ?>"><?php echo esc_html($value['title']); ?></label> |
||
317 | <?php echo $tip; ?> |
||
318 | </th> |
||
319 | <td class="forminp forminp-<?php echo sanitize_title($value['type']); ?>"> |
||
320 | <input |
||
321 | name="<?php echo esc_attr($value['id']); ?>" |
||
322 | id="<?php echo esc_attr($value['id']); ?>" |
||
323 | type="<?php echo esc_attr($type); ?>" |
||
324 | style="<?php echo esc_attr($value['css']); ?>" |
||
325 | value="<?php echo esc_attr($option_value); ?>" |
||
326 | class="<?php echo esc_attr($value['class']); ?>" |
||
327 | <?php echo implode(' ', $custom_attributes); ?> |
||
328 | /> <?php echo $description; ?> |
||
329 | </td> |
||
330 | </tr><?php |
||
331 | |||
332 | break; |
||
333 | |||
334 | // Textarea |
||
335 | case 'textarea': |
||
336 | $option_value = self::get_option($value['id'], $value['default']); |
||
337 | ?><tr valign="top"> |
||
338 | <th scope="row" class="titledesc"> |
||
339 | <label for="<?php echo esc_attr($value['id']); ?>"><?php echo esc_html($value['title']); ?></label> |
||
340 | <?php echo $tip; ?> |
||
341 | </th> |
||
342 | <td class="forminp forminp-<?php echo sanitize_title($value['type']); ?>"> |
||
343 | <?php echo $description; ?> |
||
344 | <textarea |
||
345 | name="<?php echo esc_attr($value['id']); ?>" |
||
346 | id="<?php echo esc_attr($value['id']); ?>" |
||
347 | style="<?php echo esc_attr($value['css']); ?>" |
||
348 | class="<?php echo esc_attr($value['class']); ?>" |
||
349 | <?php echo implode(' ', $custom_attributes); ?> |
||
350 | ><?php echo esc_textarea($option_value); ?></textarea> |
||
351 | </td> |
||
352 | </tr><?php |
||
353 | |||
354 | break; |
||
355 | |||
356 | // Select boxes |
||
357 | case 'select': |
||
358 | case 'multiselect': |
||
359 | $option_value = self::get_option($value['id'], $value['default']); |
||
360 | ?><tr valign="top"> |
||
361 | <th scope="row" class="titledesc"> |
||
362 | <label for="<?php echo esc_attr($value['id']); ?>"><?php echo esc_html($value['title']); ?></label> |
||
363 | <?php echo $tip; ?> |
||
364 | </th> |
||
365 | <td class="forminp forminp-<?php echo sanitize_title($value['type']); ?>"> |
||
366 | <select |
||
367 | name="<?php echo esc_attr($value['id']); ?><?php if ($value['type'] == 'multiselect') { |
||
368 | echo '[]'; |
||
369 | } |
||
370 | ?>" |
||
371 | id="<?php echo esc_attr($value['id']); ?>" |
||
372 | style="<?php echo esc_attr($value['css']); ?>" |
||
373 | class="<?php echo esc_attr($value['class']); ?>" |
||
374 | <?php echo implode(' ', $custom_attributes); ?> |
||
375 | <?php if ($value['type'] == 'multiselect') { |
||
376 | echo 'multiple="multiple"'; |
||
377 | } |
||
378 | ?>> |
||
379 | <?php foreach ($value['options'] as $key => $val) { ?> |
||
380 | <option value="<?php echo esc_attr($key); ?>" <?php |
||
381 | if (is_array($option_value)) { |
||
382 | selected(in_array($key, $option_value), true); |
||
383 | } else { |
||
384 | selected($option_value, $key); |
||
385 | } |
||
386 | ?>><?php echo $val ?></option> |
||
387 | <?php |
||
388 | } |
||
389 | ?> |
||
390 | </select> <?php echo $description; ?> |
||
391 | </td> |
||
392 | </tr><?php |
||
393 | |||
394 | break; |
||
395 | |||
396 | // Radio inputs |
||
397 | case 'radio': |
||
398 | $option_value = self::get_option($value['id'], $value['default']); |
||
399 | ?><tr valign="top"> |
||
400 | <th scope="row" class="titledesc"> |
||
401 | <label for="<?php echo esc_attr($value['id']); ?>"><?php echo esc_html($value['title']); ?></label> |
||
402 | <?php echo $tip; ?> |
||
403 | </th> |
||
404 | <td class="forminp forminp-<?php echo sanitize_title($value['type']); ?>"> |
||
405 | <fieldset> |
||
406 | <?php echo $description; ?> |
||
407 | <ul> |
||
408 | <?php foreach ($value['options'] as $key => $val) { ?> |
||
409 | <li> |
||
410 | <label><input |
||
411 | name="<?php echo esc_attr($value['id']); ?>" |
||
412 | value="<?php echo $key; ?>" |
||
413 | type="radio" |
||
414 | style="<?php echo esc_attr($value['css']); ?>" |
||
415 | class="<?php echo esc_attr($value['class']); ?>" |
||
416 | <?php echo implode(' ', $custom_attributes); ?> |
||
417 | <?php checked($key, $option_value); ?> |
||
418 | /> <?php echo $val ?></label> |
||
419 | </li> |
||
420 | <?php } ?> |
||
421 | </ul> |
||
422 | </fieldset> |
||
423 | </td> |
||
424 | </tr><?php |
||
425 | |||
426 | break; |
||
427 | |||
428 | // Checkbox input |
||
429 | case 'checkbox': |
||
430 | $option_value = self::get_option($value['id'], $value['default']); |
||
431 | if ( ! isset($value['hide_if_checked'])) { |
||
432 | $value['hide_if_checked'] = false; |
||
433 | } |
||
434 | if ( ! isset($value['show_if_checked'])) { |
||
435 | $value['show_if_checked'] = false; |
||
436 | } |
||
437 | if ( ! isset($value['checkboxgroup']) || (isset($value['checkboxgroup']) && $value['checkboxgroup'] == 'start')) { |
||
438 | ?> |
||
439 | <tr valign="top" class="<?php |
||
440 | if ($value['hide_if_checked'] == 'yes' || $value['show_if_checked'] == 'yes') { |
||
441 | echo 'hidden_option'; |
||
442 | } |
||
443 | if ($value['hide_if_checked'] == 'option') { |
||
444 | echo 'hide_options_if_checked'; |
||
445 | } |
||
446 | if ($value['show_if_checked'] == 'option') { |
||
447 | echo 'show_options_if_checked'; |
||
448 | } |
||
449 | ?>"> |
||
450 | <th scope="row" class="titledesc"><?php echo esc_html($value['title']); ?></th> |
||
451 | <td class="forminp forminp-checkbox"> |
||
452 | <fieldset> |
||
453 | <?php |
||
454 | } else { |
||
455 | ?> |
||
456 | <fieldset class="<?php |
||
457 | if ($value['hide_if_checked'] == 'yes' || $value['show_if_checked'] == 'yes') { |
||
458 | echo 'hidden_option'; |
||
459 | } |
||
460 | if ($value['hide_if_checked'] == 'option') { |
||
461 | echo 'hide_options_if_checked'; |
||
462 | } |
||
463 | if ($value['show_if_checked'] == 'option') { |
||
464 | echo 'show_options_if_checked'; |
||
465 | } |
||
466 | ?>"> |
||
467 | <?php |
||
468 | } |
||
469 | ?> |
||
470 | <legend class="screen-reader-text"><span><?php echo esc_html($value['title']); ?></span></legend> |
||
471 | <label for="<?php echo $value['id'] ?>"> |
||
472 | <input |
||
473 | name="<?php echo esc_attr($value['id']); ?>" |
||
474 | id="<?php echo esc_attr($value['id']); ?>" |
||
475 | type="checkbox" |
||
476 | value="1" |
||
477 | <?php checked($option_value, 'yes'); ?> |
||
478 | <?php echo implode(' ', $custom_attributes); ?> |
||
479 | /> <?php echo wp_kses_post($value['desc']) ?></label> <?php echo $tip; ?> |
||
480 | <?php |
||
481 | if ( ! isset($value['checkboxgroup']) || (isset($value['checkboxgroup']) && $value['checkboxgroup'] == 'end')) { |
||
482 | ?> |
||
483 | </fieldset> |
||
484 | </td> |
||
485 | </tr> |
||
486 | <?php |
||
487 | } else { |
||
488 | ?> |
||
489 | </fieldset> |
||
490 | <?php |
||
491 | } |
||
492 | |||
493 | break; |
||
494 | |||
495 | // Default: run an action |
||
496 | default: |
||
497 | do_action('auto_load_next_post_admin_field_'.$value['type'], $value); |
||
498 | |||
499 | break; |
||
500 | } // end switch |
||
501 | |||
502 | } |
||
503 | |||
504 | } // END output_fields() |
||
505 | |||
636 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.