AuthorizeNetCP_Response::__construct() - Code Metrics - Inspection of "Adding code quality and package version widgets" - AuthorizeNet/sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Naman

created 2016-03-04 19:00 UTC

AuthorizeNetCP_Response::__construct() C

↳ Parent: AuthorizeNetCP_Response

Complexity

Conditions	11
Paths	71

Size

Total Lines	95
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	34
CRAP Score	20.8435

Metric	Value
dl	0
loc	95
ccs	34
cts	60
cp	0.5667
rs	5.2653
cc	11
eloc	62
nc	71
nop	4
crap	20.8435

How to fix Long Method Complexity

<?php
/**
 * Easily interact with the Authorize.Net Card Present API.
 *
 *
 * @package    AuthorizeNet
 * @subpackage AuthorizeNetCP
 * @link       http://www.authorize.net/support/CP_guide.pdf Card Present Guide
 */

 
/**
 * Builds and sends an AuthorizeNet CP Request.
 *
 * @package    AuthorizeNet
 * @subpackage AuthorizeNetCP
 */
class AuthorizeNetCP extends AuthorizeNetAIM
namespace YourVendor;

class YourClass { }
{
    
    const LIVE_URL = 'https://cardpresent.authorize.net/gateway/transact.dll';
    
    public $verify_x_fields = false; 
    
    /**
     * Holds all the x_* name/values that will be posted in the request. 
     * Default values are provided for best practice fields.
     */
    protected $_x_post_fields = array(
        "cpversion" => "1.0", 
        "delim_char" => ",",
        "encap_char" => "|",
        "market_type" => "2",
        "response_format" => "1", // 0 - XML, 1 - NVP
        );
    
    /**
     * Device Types (x_device_type)
     * 1 = Unknown
     * 2 = Unattended Terminal
     * 3 = Self Service Terminal
     * 4 = Electronic Cash Register
     * 5 = Personal Computer- Based Terminal
     * 6 = AirPay
     * 7 = Wireless POS
     * 8 = Website
     * 9 = Dial Terminal
     * 10 = Virtual Terminal
     */
    
	/**
     * Only used if merchant wants to send custom fields.
     */
    private $_custom_fields = array();

	
    /**
     * Strip sentinels and set track1 field.
     *
     * @param  string $track1data
     */
    public function setTrack1Data($track1data) {
        if (preg_match('/^%.*\?$/', $track1data)) {
            $this->track1 = substr($track1data, 1, -1);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->track1 = $track1data;    
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
    
    /**
     * Strip sentinels and set track2 field.
     *
     * @param  string $track2data
     */
    public function setTrack2Data($track2data) {
        if (preg_match('/^;.*\?$/', $track2data)) {
            $this->track2 = substr($track2data, 1, -1);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->track2 = $track2data;    
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
    
    /**
     *
     *
     * @param string $response
     * 
     * @return AuthorizeNetAIM_Response
     */
    protected function _handleResponse($response)
    {
        return new AuthorizeNetCP_Response($response, $this->_x_post_fields['delim_char'], $this->_x_post_fields['encap_char'], $this->_custom_fields);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
    
}


/**
 * Parses an AuthorizeNet Card Present Response.
 *
 * @package    AuthorizeNet
 * @subpackage AuthorizeNetCP
 */
class AuthorizeNetCP_Response extends AuthorizeNetResponse
namespace YourVendor;

class YourClass { }
{
    private $_response_array = array(); // An array with the split response.

    /**
     * Constructor. Parses the AuthorizeNet response string.
     *
     * @param string $response      The response from the AuthNet server.
     * @param string $delimiter     The delimiter used (default is ",")
     * @param string $encap_char    The encap_char used (default is "|")
     * @param array  $custom_fields Any custom fields set in the request.
     */
    public function __construct($response, $delimiter, $encap_char, $custom_fields)

    {
        if ($response) {
            
            // If it's an XML response
            if (substr($response, 0, 5) == "<?xml") {
                
                $this->xml = @simplexml_load_string($response);
class MyClass { }

$x = new MyClass();
$x->foo = true;
                // Set all fields
                $this->version              = array_pop(array_slice(explode('"', $response), 1,1));
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->response_code        = (string)$this->xml->ResponseCode;
                
                if ($this->response_code == 1) {
                    $this->response_reason_code = (string)$this->xml->Messages->Message->Code;
                    $this->response_reason_text = (string)$this->xml->Messages->Message->Description;
                } else {
                    $this->response_reason_code = (string)$this->xml->Errors->Error->ErrorCode;
                    $this->response_reason_text = (string)$this->xml->Errors->Error->ErrorText;
                }
                
                $this->authorization_code   = (string)$this->xml->AuthCode;
                $this->avs_code             = (string)$this->xml->AVSResultCode;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->card_code_response   = (string)$this->xml->CVVResultCode;
                $this->transaction_id       = (string)$this->xml->TransID;
                $this->md5_hash             = (string)$this->xml->TransHash;
                $this->user_ref             = (string)$this->xml->UserRef;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->card_num             = (string)$this->xml->AccountNumber;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->card_type            = (string)$this->xml->AccountType;
                $this->test_mode            = (string)$this->xml->TestMode;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->ref_trans_id         = (string)$this->xml->RefTransID;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                
                
            } else { // If it's an NVP response
                
                // Split Array
                $this->response = $response;
                if ($encap_char) {
                    $this->_response_array = explode($encap_char.$delimiter.$encap_char, substr($response, 1, -1));
                } else {
                    $this->_response_array = explode($delimiter, $response);
                }
                
                /**
                 * If AuthorizeNet doesn't return a delimited response.
                 */
                if (count($this->_response_array) < 10) {
                    $this->approved = false;
                    $this->error = true;
                    $this->error_message = "Unrecognized response from AuthorizeNet: $response";
class MyClass { }

$x = new MyClass();
$x->foo = true;
                    return;
                }
                
                
                
                // Set all fields
                $this->version              = $this->_response_array[0];
                $this->response_code        = $this->_response_array[1];
                $this->response_reason_code = $this->_response_array[2];
                $this->response_reason_text = $this->_response_array[3];
                $this->authorization_code   = $this->_response_array[4];
                $this->avs_code             = $this->_response_array[5];
                $this->card_code_response   = $this->_response_array[6];
                $this->transaction_id       = $this->_response_array[7];
                $this->md5_hash             = $this->_response_array[8];
                $this->user_ref             = $this->_response_array[9];
                $this->card_num             = $this->_response_array[20];
                $this->card_type            = $this->_response_array[21];
                $this->split_tender_id      = isset($this->_response_array[22]) ? $this->_response_array[22] : NULL;
                $this->requested_amount     = isset($this->_response_array[23]) ? $this->_response_array[23] : NULL;
                $this->approved_amount      = isset($this->_response_array[24]) ? $this->_response_array[24] : NULL;

                $this->card_balance         = isset($this->_response_array[25]) ? $this->_response_array[25] : NULL;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    
    
                
            }
            $this->approved = ($this->response_code == self::APPROVED);
            $this->declined = ($this->response_code == self::DECLINED);
            $this->error    = ($this->response_code == self::ERROR);
            $this->held     = ($this->response_code == self::HELD);

            
            if ($this->error) {
                $this->error_message = "AuthorizeNet Error:
                Response Code: ".$this->response_code."
                Response Reason Code: ".$this->response_reason_code."
                Response Reason Text: ".$this->response_reason_text."
                ";
            }
            
        } else {
            $this->approved = false;
            $this->error = true;
            $this->error_message = "Error connecting to AuthorizeNet";
        }
    }
    
    /**
     * Is the MD5 provided correct?
     *
     * @param string $api_login_id
     * @param string $md5_setting
     * @return bool
     */
    public function isAuthorizeNet($api_login_id = false, $md5_setting = false)
    {
        $amount = ($this->amount ? $this->amount : '0.00');
        $api_login_id = ($api_login_id ? $api_login_id : AUTHORIZENET_API_LOGIN_ID);
        $md5_setting = ($md5_setting ? $md5_setting : AUTHORIZENET_MD5_SETTING);
        return ($this->md5_hash == strtoupper(md5($md5_setting . $api_login_id . $this->transaction_id . $amount)));
    }

}



1			<?php
2			/**
3			* Easily interact with the Authorize.Net Card Present API.
4			*
5			*
6			* @package AuthorizeNet
7			* @subpackage AuthorizeNetCP
8			* @link http://www.authorize.net/support/CP_guide.pdf Card Present Guide
9			*/
10
11
12			/**
13			* Builds and sends an AuthorizeNet CP Request.
14			*
15			* @package AuthorizeNet
16			* @subpackage AuthorizeNetCP
17			*/
18			class AuthorizeNetCP extends AuthorizeNetAIM
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-02 13:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
19			{
20
21			const LIVE_URL = 'https://cardpresent.authorize.net/gateway/transact.dll';
22
23			public $verify_x_fields = false;
24
25			/**
26			* Holds all the x_* name/values that will be posted in the request.
27			* Default values are provided for best practice fields.
28			*/
29			protected $_x_post_fields = array(
30			"cpversion" => "1.0",
31			"delim_char" => ",",
32			"encap_char" => "\|",
33			"market_type" => "2",
34			"response_format" => "1", // 0 - XML, 1 - NVP
35			);
36
37			/**
38			* Device Types (x_device_type)
39			* 1 = Unknown

AuthorizeNet / sdk-php

Pull Request — master (#114)

AuthorizeNetCP_Response::__construct() C

Complexity

Size

Duplication

Code Coverage

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like