UsersController::update() - Code Metrics - Inspection of "Merge pull request #32 from AudithSoftworks/auth" - AudithSoftworks/Basis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b1c4b6...a05019 )

by Şəhriyar

created 2016-04-18 12:50 UTC

UsersController::update() A

↳ Parent: UsersController

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.072

Importance

Changes	6
Bugs	2	Features	4

Metric	Value
c	6
b	2
f	4
dl	0
loc	9
ccs	4
cts	5
cp	0.8
rs	9.6666
cc	3
eloc	5
nc	2
nop	3
crap	3.072

<?php namespace App\Http\Controllers;

use App\Contracts\Registrar;
use App\Exceptions\Common\NotImplementedException;
use Illuminate\Http\Request;
use Illuminate\Http\Response as IlluminateResponse;

class UsersController extends Controller
{
    /**
     * Create a new authentication controller instance.
     */
    public function __construct()
    {
        $this->middleware('guest', ['except' => ['show', 'edit', 'update', 'destroy']]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create(Request $request)
    {
        if ($request->ajax() || $request->wantsJson()) {
            throw new NotImplementedException;
        }

        return view('auth/register');
    }

    /**
     * Store a newly created user.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     *
     * @return \Illuminate\Http\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function store(Request $request, Registrar $registrar)
    {
        $user = $registrar->register();

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json($user)->setStatusCode(IlluminateResponse::HTTP_CREATED);
        }

        return redirect($this->redirectPath())->with('message', 'Created');
    }

    /**
     * Display the specified user information.
     *
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function show(Registrar $registrar, $id)
    {
        $user = $registrar->get($id);

        return response()->json($user);
    }

    /**
     * Show the form for editing user information.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function edit(Request $request, Registrar $registrar, $id)
    {
        /** @var \App\Models\User $user */
        $user = $registrar->get($id);

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Ready', 'data' => $user]);
        }

        return view('auth/edit', ['user' => $user]);
    }

    /**
     * Update the specified user information.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function update(Request $request, Registrar $registrar, $id)
    {
        $registrar->update($id);
        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Updated']);
        }

        return redirect()->back()->with('message', 'Updated');
    }

    /**
     * Remove the specified user record from storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function destroy(Request $request, Registrar $registrar, $id)
    {
        $registrar->delete($id);

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json()->setStatusCode(IlluminateResponse::HTTP_NO_CONTENT);
        }

        return redirect($this->redirectPath())->with('message', 'Deleted');
    }

    /**
     * Get the post register / login redirect path.
     *
     * @return string
     */
    private function redirectPath()
    {
        if (isset($this->redirectPath)) {
            return $this->redirectPath;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return isset($this->redirectTo) ? $this->redirectTo : '/';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1		<?php namespace App\Http\Controllers;
2
3		use App\Contracts\Registrar;
4		use App\Exceptions\Common\NotImplementedException;
5		use Illuminate\Http\Request;
6		use Illuminate\Http\Response as IlluminateResponse;
7
8		class UsersController extends Controller
9		{
10		/**
11		* Create a new authentication controller instance.
12		*/
13	13	public function __construct()
14		{
15	13	$this->middleware('guest', ['except' => ['show', 'edit', 'update', 'destroy']]);
16	13	}
17
18		/**
19		* Show the form for creating a new resource.
20		*
21		* @param \Illuminate\Http\Request $request
22		*
23		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
24		*/
25	3	public function create(Request $request)
26		{
27	3	if ($request->ajax() \|\| $request->wantsJson()) {
28	1	throw new NotImplementedException;
29		}
30
31	2	return view('auth/register');
32		}
33
34		/**
35		* Store a newly created user.
36		*
37		* @param \Illuminate\Http\Request $request
38		* @param \App\Contracts\Registrar $registrar
39		*
40		* @return \Illuminate\Http\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
41		*/
42	3	public function store(Request $request, Registrar $registrar)
43		{
44	3	$user = $registrar->register();
45
46	1	if ($request->ajax() \|\| $request->wantsJson()) {
47	1	return response()->json($user)->setStatusCode(IlluminateResponse::HTTP_CREATED);
48		}
49
50	1	return redirect($this->redirectPath())->with('message', 'Created');
51		}
52
53		/**
54		* Display the specified user information.
55		*
56		* @param \App\Contracts\Registrar $registrar
57		* @param int $id
58		*
59		* @return \Illuminate\Http\JsonResponse
60		*/
61	2	public function show(Registrar $registrar, $id)
62		{
63	2	$user = $registrar->get($id);
64
65	1	return response()->json($user);
66		}
67
68		/**
69		* Show the form for editing user information.
70		*
71		* @param \Illuminate\Http\Request $request
72		* @param \App\Contracts\Registrar $registrar
73		* @param int $id
74		*
75		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\Http\JsonResponse\|\Illuminate\View\View
76		*/
77	1	public function edit(Request $request, Registrar $registrar, $id)
78		{
79		/** @var \App\Models\User $user */
80	1	$user = $registrar->get($id);
81
82	1	if ($request->ajax() \|\| $request->wantsJson()) {
83	1	return response()->json(['message' => 'Ready', 'data' => $user]);
84		}
85
86		return view('auth/edit', ['user' => $user]);
87		}
88
89		/**
90		* Update the specified user information.
91		*
92		* @param \Illuminate\Http\Request $request
93		* @param \App\Contracts\Registrar $registrar
94		* @param int $id
95		*
96		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
97		*/
98	2	public function update(Request $request, Registrar $registrar, $id)
99		{
100	2	$registrar->update($id);
101	1	if ($request->ajax() \|\| $request->wantsJson()) {
102	1	return response()->json(['message' => 'Updated']);
103		}
104
105		return redirect()->back()->with('message', 'Updated');
106		}
107
108		/**
109		* Remove the specified user record from storage.
110		*
111		* @param \Illuminate\Http\Request $request
112		* @param \App\Contracts\Registrar $registrar
113		* @param int $id
114		*
115		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
116		*/
117	2	public function destroy(Request $request, Registrar $registrar, $id)
118		{
119	2	$registrar->delete($id);
120
121	1	if ($request->ajax() \|\| $request->wantsJson()) {
122	1	return response()->json()->setStatusCode(IlluminateResponse::HTTP_NO_CONTENT);
123		}
124
125		return redirect($this->redirectPath())->with('message', 'Deleted');
126		}
127
128		/**
129		* Get the post register / login redirect path.
130		*
131		* @return string
132		*/
133	2	private function redirectPath()
134		{
135		if (isset($this->redirectPath)) {
136		return $this->redirectPath;
		0 ignored issues – show Bug introduced 2015-11-20 21:25 UTC by Report Bug Copy Issue Report The property `redirectPath` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
137		}
138
139		return isset($this->redirectTo) ? $this->redirectTo : '/';
		0 ignored issues – show Bug introduced 2015-11-20 21:25 UTC by Report Bug Copy Issue Report The property `redirectTo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
140	2	}
141		}
142

AudithSoftworks / Basis

Push — master ( b1c4b6...a05019 )

UsersController::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like