UsersController::__construct() - Code Metrics - Inspection of "Few fixes." - AudithSoftworks/Basis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9fa9ff...52caec )

by Şəhriyar

created 2015-12-08 14:11 UTC

UsersController::__construct() A

↳ Parent: UsersController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php namespace App\Http\Controllers;

use App\Contracts\Registrar;
use App\Exceptions\Common\NotImplementedException;
use Illuminate\Http\Request;

class UsersController extends Controller
{
    /**
     * Create a new authentication controller instance.
     */
    public function __construct()
    {
        $this->middleware('guest', ['except' => ['show', 'edit', 'update', 'destroy']]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create(Request $request)
    {
        if ($request->ajax() || $request->wantsJson()) {
            throw new NotImplementedException;
        }

        return view('auth/register');
    }

    /**
     * Store a newly created user.
     *
     * @param \Illuminate\Http\Request $request *
     * @param \App\Contracts\Registrar $registrar
     *
     * @return \Illuminate\Http\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function store(Request $request, Registrar $registrar)
    {
        $user = $registrar->register();

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Created', 'data' => $user])->setStatusCode(\Illuminate\Http\Response::HTTP_CREATED);
        }

        return redirect($this->redirectPath())->with('message', 'Created');
    }

    /**
     * Display the specified user information.
     *
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function show(Registrar $registrar, $id)
    {
        $user = $registrar->get($id);

        return response()->json(['message' => 'Found', 'data' => $user]);
    }

    /**
     * Show the form for editing user information.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function edit(Request $request, Registrar $registrar, $id)
    {
        /** @var \App\Models\User $user */
        $user = $registrar->get($id);

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Ready', 'data' => $user]);
        }

        return view('auth/edit', ['user' => $user]);
    }

    /**
     * Update the specified user information.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function update(Request $request, Registrar $registrar, $id)
    {
        $registrar->update($id);
        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Updated']);
        }

        return redirect()->back()->with('message', 'Updated');
    }

    /**
     * Remove the specified user record from storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param \App\Contracts\Registrar $registrar
     * @param int                      $id
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function destroy(Request $request, Registrar $registrar, $id)
    {
        $registrar->delete($id);

        if ($request->ajax() || $request->wantsJson()) {
            return response()->json(['message' => 'Deleted']);
        }

        return redirect($this->redirectPath())->with('message', 'Deleted');
    }

    /**
     * Get the post register / login redirect path.
     *
     * @return string
     */
    private function redirectPath()
    {
        if (isset($this->redirectPath)) {
            return $this->redirectPath;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return isset($this->redirectTo) ? $this->redirectTo : '/';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1		<?php namespace App\Http\Controllers;
2
3		use App\Contracts\Registrar;
4		use App\Exceptions\Common\NotImplementedException;
5		use Illuminate\Http\Request;
6
7		class UsersController extends Controller
8		{
9		/**
10		* Create a new authentication controller instance.
11		*/
12	15	public function __construct()
13		{
14	15	$this->middleware('guest', ['except' => ['show', 'edit', 'update', 'destroy']]);
15	15	}
16
17		/**
18		* Show the form for creating a new resource.
19		*
20		* @param \Illuminate\Http\Request $request
21		*
22		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
23		*/
24	6	public function create(Request $request)
25		{
26	6	if ($request->ajax() \|\| $request->wantsJson()) {
27	1	throw new NotImplementedException;
28		}
29
30	5	return view('auth/register');
31		}
32
33		/**
34		* Store a newly created user.
35		*
36		* @param \Illuminate\Http\Request $request *
37		* @param \App\Contracts\Registrar $registrar
38		*
39		* @return \Illuminate\Http\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
40		*/
41	4	public function store(Request $request, Registrar $registrar)
42		{
43	4	$user = $registrar->register();
44
45	2	if ($request->ajax() \|\| $request->wantsJson()) {
46	1	return response()->json(['message' => 'Created', 'data' => $user])->setStatusCode(\Illuminate\Http\Response::HTTP_CREATED);
47		}
48
49	1	return redirect($this->redirectPath())->with('message', 'Created');
50		}
51
52		/**
53		* Display the specified user information.
54		*
55		* @param \App\Contracts\Registrar $registrar
56		* @param int $id
57		*
58		* @return \Illuminate\Http\JsonResponse
59		*/
60	2	public function show(Registrar $registrar, $id)
61		{
62	2	$user = $registrar->get($id);
63
64	2	return response()->json(['message' => 'Found', 'data' => $user]);
65		}
66
67		/**
68		* Show the form for editing user information.
69		*
70		* @param \Illuminate\Http\Request $request
71		* @param \App\Contracts\Registrar $registrar
72		* @param int $id
73		*
74		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\Http\JsonResponse\|\Illuminate\View\View
75		*/
76	1	public function edit(Request $request, Registrar $registrar, $id)
77		{
78		/** @var \App\Models\User $user */
79	1	$user = $registrar->get($id);
80
81	1	if ($request->ajax() \|\| $request->wantsJson()) {
82	1	return response()->json(['message' => 'Ready', 'data' => $user]);
83		}
84
85		return view('auth/edit', ['user' => $user]);
86		}
87
88		/**
89		* Update the specified user information.
90		*
91		* @param \Illuminate\Http\Request $request
92		* @param \App\Contracts\Registrar $registrar
93		* @param int $id
94		*
95		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
96		*/
97	2	public function update(Request $request, Registrar $registrar, $id)
98		{
99	2	$registrar->update($id);
100	1	if ($request->ajax() \|\| $request->wantsJson()) {
101	1	return response()->json(['message' => 'Updated']);
102		}
103
104		return redirect()->back()->with('message', 'Updated');
105		}
106
107		/**
108		* Remove the specified user record from storage.
109		*
110		* @param \Illuminate\Http\Request $request
111		* @param \App\Contracts\Registrar $registrar
112		* @param int $id
113		*
114		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
115		*/
116	2	public function destroy(Request $request, Registrar $registrar, $id)
117		{
118	2	$registrar->delete($id);
119
120	1	if ($request->ajax() \|\| $request->wantsJson()) {
121	1	return response()->json(['message' => 'Deleted']);
122		}
123
124		return redirect($this->redirectPath())->with('message', 'Deleted');
125		}
126
127		/**
128		* Get the post register / login redirect path.
129		*
130		* @return string
131		*/
132	1	private function redirectPath()
133		{
134	1	if (isset($this->redirectPath)) {
135		return $this->redirectPath;
		0 ignored issues – show Bug introduced 2015-11-20 21:25 UTC by Report Bug Copy Issue Report The property `redirectPath` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
136		}
137
138	1	return isset($this->redirectTo) ? $this->redirectTo : '/';
		0 ignored issues – show Bug introduced 2015-11-20 21:25 UTC by Report Bug Copy Issue Report The property `redirectTo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
139		}
140		}
141

AudithSoftworks / Basis

Push — master ( 9fa9ff...52caec )

UsersController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like