Audiens\AppnexusClient\repository\SegmentBillingRepository

Complexity

Total Complexity

20

Size/Duplication

Total Lines	225
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getBaseUrl()	0	4	1
A	setBaseUrl()	0	4	1
B	add()	13	30	3
A	update()	19	19	2
B	findOneBySegmentId()	0	29	4
C	findAll()	0	44	7
A	remove()	11	11	1

<?php

namespace Audiens\AppnexusClient\repository;

use Audiens\AppnexusClient\CachableTrait;
use Audiens\AppnexusClient\CacheableInterface;
use Audiens\AppnexusClient\entity\SegmentBilling;
use Audiens\AppnexusClient\exceptions\RepositoryException;
use Doctrine\Common\Cache\Cache;
use GuzzleHttp\Client;
use GuzzleHttp\ClientInterface;

/**
 * Class SegmentBillingRepository
 */
class SegmentBillingRepository implements CacheableInterface
{
    use CachableTrait;

    const BASE_URL = 'https://api.adnxs.com/segment-billing-category';

    const SANDBOX_BASE_URL = 'http://api-test.adnxs.com/segment-billing-category';

    /** @var Client */
    protected $client;

    /** @var  int */
    protected $memberId;

    /** @var  Cache */
    protected $cache;

    /** @var  string */
    protected $baseUrl;

    const CACHE_NAMESPACE = 'appnexus_segment_billing_repository_find_all';

    const CACHE_EXPIRATION = 3600;

    /**
     * SegmentRepository constructor.
     *
     * @param ClientInterface $client
     * @param Cache|null      $cache
     */
    public function __construct(ClientInterface $client, Cache $cache = null)

This method seems to be duplicated in your project.

    {
        $this->client = $client;

$client is of type object<GuzzleHttp\ClientInterface>, but the property $client was declared to be of type object<GuzzleHttp\Client>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->cache = $cache;
        $this->cacheEnabled = $cache instanceof Cache;
        $this->baseUrl = self::BASE_URL;
    }

    /**
     * @return string
     */
    public function getBaseUrl()
    {
        return $this->baseUrl;
    }

    /**
     * @param string $baseUrl
     */
    public function setBaseUrl($baseUrl)
    {
        $this->baseUrl = $baseUrl;
    }


    /**
     * @param SegmentBilling $segmentBilling
     *
     * @return RepositoryResponse
     * @throws RepositoryException
     */
    public function add(SegmentBilling $segmentBilling)
    {

        $compiledUrl = $this->baseUrl.'?member_id='.$segmentBilling->getMemberId();

        $payload = [
            'segment-billing-category' => $segmentBilling->toArray(),
        ];


        $response = $this->client->request('POST', $compiledUrl, ['body' => json_encode($payload)]);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        if ($repositoryResponse->isSuccessful()) {

This code seems to be duplicated across your project.

            $stream = $response->getBody();
            $responseContent = json_decode($stream->getContents(), true);

            $stream->rewind();


            if (!(isset($responseContent['response']['segment-billing-category'][0]['id']))) {
                throw RepositoryException::wrongFormat(serialize($responseContent));
            }

            $segmentBilling->setId($responseContent['response']['segment-billing-category'][0]['id']);
        }

        return $repositoryResponse;
    }

    /**
     * @param SegmentBilling $segmentBilling
     *
     * @return RepositoryResponse
     * @throws RepositoryException
     */
    public function update(SegmentBilling $segmentBilling)

This method seems to be duplicated in your project.

    {

        if (!$segmentBilling->getId()) {
            throw RepositoryException::missingSegmentBillingId($segmentBilling);
        }

        $compiledUrl = $this->baseUrl.'?member_id='.$segmentBilling->getMemberId();

        $payload = [
            'segment-billing-category' => $segmentBilling->toArray(),
        ];

        $response = $this->client->request('PUT', $compiledUrl, ['body' => json_encode($payload)]);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        return $repositoryResponse;
    }

    /**
     * @param $memberId
     * @param $segmentId
     * @return SegmentBilling
     * @throws RepositoryException
     */
    public function findOneBySegmentId($memberId, $segmentId)
    {

        $compiledUrl = $this->baseUrl.'?member_id='.$memberId.'&segment_id='.$segmentId;


        $response = $this->client->request('GET', $compiledUrl);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        if (!$repositoryResponse->isSuccessful()) {
            throw RepositoryException::failed($repositoryResponse);
        }

        $stream = $response->getBody();
        $responseContent = json_decode($stream->getContents(), true);
        $stream->rewind();

        if (!$responseContent['response']['segment-billing-categories']) {
            return null;
        }

        if (count($responseContent['response']['segment-billing-categories']) > 1) {
            throw RepositoryException::genericFailed('Expected only one results. Found '.count($responseContent['response']['segment-billing-categories']));
        }


        return SegmentBilling::fromArray($responseContent['response']['segment-billing-categories'][0]);
    }

    /**
     * @param     $memberId
     * @param int $start
     * @param int $maxResults
     *
     * @return SegmentBilling[]|null
     * @throws RepositoryException
     */
    public function findAll($memberId, $start = 0, $maxResults = 100)
    {

        $cacheKey = self::CACHE_NAMESPACE.sha1($memberId.$start.$maxResults);


        if ($this->isCacheEnabled()) {
            if ($this->cache->contains($cacheKey)) {
                return $this->cache->fetch($cacheKey);
            }
        }

        $compiledUrl = $this->baseUrl.'?member_id='.$memberId.'&start_element='.$start.'&num_elements='.$maxResults;


        $response = $this->client->request('GET', $compiledUrl);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        if (!$repositoryResponse->isSuccessful()) {
            throw RepositoryException::failed($repositoryResponse);
        }

        $stream = $response->getBody();
        $responseContent = json_decode($stream->getContents(), true);
        $stream->rewind();


        $result = [];

        if (!$responseContent['response']['segment-billing-categories']) {
            $responseContent['response']['segment-billing-categories'] = [];
        }

        foreach ($responseContent['response']['segment-billing-categories'] as $segmentBillingArray) {
            $result[] = SegmentBilling::fromArray($segmentBillingArray);
        }

        if ($this->isCacheEnabled()) {
            $this->cache->save($cacheKey, $result, self::CACHE_EXPIRATION);
        }

        return $result;
    }

    /**
     * @param $memberId
     * @param $id
     *
     * @return RepositoryResponse
     */
    public function remove($memberId, $id)

This method seems to be duplicated in your project.

    {

        $compiledUrl = $this->baseUrl.'?member_id='.$memberId.'&id='.$id;

        $response = $this->client->request('DELETE', $compiledUrl);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        return $repositoryResponse;
    }
}