Audiens\AppnexusClient\repository\UserSegmentRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	134
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	upload()	0	33	1
B	getUploadUrl()	0	24	3
A	isCacheEnabled()	0	4	1
A	disableCache()	0	4	1
A	enableCache()	0	4	1

<?php

namespace Audiens\AppnexusClient\repository;

use Audiens\AppnexusClient\Auth;
use Audiens\AppnexusClient\entity\UserSegment;
use Doctrine\Common\Cache\Cache;
use GuzzleHttp\Client;
use GuzzleHttp\ClientInterface;

/**
 * Class UserSegmentRepository
 */
class UserSegmentRepository
{

    const BASE_URL = 'http://api.appnexus.com/batch-segment';
//    const BASE_URL_ADNXS = 'http://sand.api.appnexus.com/batch-segment';

    /** @var  \SplQueue */
    protected $userSegments;

    /** @var Client|Auth */
    protected $client;

    /** @var  int */
    protected $memberId;

    /** @var  Cache */
    protected $cache;

    /** @var bool */
    protected $cacheEnabled;

    const CACHE_NAMESPACE = 'appnexus_segment_user_upload';

    const CACHE_EXPIRATION = 3600;

    /**
     * SegmentRepository constructor.
     *
     * @param ClientInterface $client
     * @param Cache|null      $cache
     */
    public function __construct(ClientInterface $client, Cache $cache = null)
    {
        $this->client = $client;

$client is of type object<GuzzleHttp\ClientInterface>, but the property $client was declared to be of type object<GuzzleHttp\Client>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->cache = $cache;
        $this->cacheEnabled = $cache instanceof Cache;

    }


    /**
     * @param $fileAsString
     * @param $memberId
     *
     * @return RepositoryResponse
     * @throws \Exception
     */
    public function upload($fileAsString,$memberId){

        $tempFile = tmpfile();

        fwrite($tempFile, $fileAsString);
        fseek($tempFile, 0);


        $url = $this->getUploadUrl($memberId);

        $contentPayload = [

$contentPayload is not used, you could remove the assignment.

            # Content-Disposition: form-data; name="file"; filename="/the/full/path/of/image/file/you/want/to/upload.png"
            'Content-Disposition' => sprintf('form-data; name="%s"; filename="%s"', 'file', $myFile),

The variable $myFile does not exist. Did you forget to declare it?

            # Content-Type: application/octet-stream
            # 'Content-Type' => 'application/octet-stream'

50% of this comment could be valid code. Did you maybe forget this after debugging?

        ];

        $response = $this->client->request('PUT', $url, ['body' => $tempFile]);

        $stream = $response->getBody();

        $responseContent = json_decode($stream->getContents(), true);


        print_r($responseContent);die();

The method upload() contains an exit expression.

        fclose($tempFile); // this removes the file

fclose($tempFile); does not seem to be reachable.

    }



    /**
     * @param $memberId
     *
     * @return string
     * @throws \Exception
     */
    public function getUploadUrl($memberId)
    {

        $compiledUrl = self::BASE_URL.'?member_id='.$memberId;

        $response = $this->client->request('POST', $compiledUrl);

        $repositoryResponse = RepositoryResponse::fromResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

        if (!$repositoryResponse->isSuccessful()) {
            throw new \Exception('name me');
        }

        if (!isset($responseContent['response']['batch_segment_upload_job']['upload_url'])) {

The variable $responseContent seems only to be defined at a later point. As such the call to isset() seems to always evaluate to false.

            throw new \Exception('name me');
        }

        $stream = $response->getBody();
        $responseContent = json_decode($stream->getContents(), true);
        $stream->rewind();

        return $responseContent['response']['batch_segment_upload_job']['upload_url'];

    }


    /**
     * @return boolean
     */
    public function isCacheEnabled()
    {
        return $this->cacheEnabled;
    }

    public function disableCache()
    {
        $this->cacheEnabled = false;
    }

    public function enableCache()
    {
        $this->cacheEnabled = true;
    }

}