Complex classes like UploadJobStatus often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UploadJobStatus, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
5 | class UploadJobStatus extends UploadTicket |
||
6 | { |
||
7 | |||
8 | public const PHASE_COMPLETED = 'completed'; |
||
9 | |||
10 | use HydratableTrait; |
||
11 | |||
12 | protected $phase; |
||
13 | protected $start_time; |
||
14 | protected $uploaded_time; |
||
15 | protected $validated_time; |
||
16 | protected $completed_time; |
||
17 | protected $error_code; |
||
18 | protected $time_to_process; |
||
19 | protected $percent_complete; |
||
20 | protected $num_valid; |
||
21 | protected $num_valid_user; |
||
22 | protected $num_invalid_format; |
||
23 | protected $num_invalid_user; |
||
24 | protected $num_invalid_segment; |
||
25 | protected $num_unauth_segment; |
||
26 | protected $num_past_expiration; |
||
27 | protected $num_inactive_segment; |
||
28 | protected $num_other_error; |
||
29 | protected $error_log_lines; |
||
30 | protected $segment_log_lines; |
||
31 | protected $created_on; |
||
32 | |||
33 | public function getPhase() |
||
37 | |||
38 | public function setPhase($phase) |
||
42 | |||
43 | public function getStartTime() |
||
47 | |||
48 | public function setStartTime($start_time) |
||
52 | |||
53 | public function getUploadedTime() |
||
57 | |||
58 | public function setUploadedTime($uploaded_time) |
||
62 | |||
63 | public function getValidatedTime() |
||
67 | |||
68 | public function setValidatedTime($validated_time) |
||
72 | |||
73 | public function getCompletedTime() |
||
77 | |||
78 | public function setCompletedTime($completed_time) |
||
82 | |||
83 | public function getErrorCode() |
||
87 | |||
88 | public function setErrorCode($error_code) |
||
92 | |||
93 | public function getTimeToProcess() |
||
97 | |||
98 | public function setTimeToProcess($time_to_process) |
||
102 | |||
103 | public function getPercentComplete() |
||
107 | |||
108 | public function setPercentComplete($percent_complete) |
||
112 | |||
113 | public function getNumValid() |
||
117 | |||
118 | public function setNumValid($num_valid) |
||
122 | |||
123 | public function getNumValidUser() |
||
127 | |||
128 | public function setNumValidUser($num_valid_user) |
||
132 | |||
133 | public function getNumInvalidFormat() |
||
137 | |||
138 | public function setNumInvalidFormat($num_invalid_format) |
||
142 | |||
143 | public function getNumInvalidUser() |
||
147 | |||
148 | public function setNumInvalidUser($num_invalid_user) |
||
152 | |||
153 | public function getNumInvalidSegment() |
||
157 | |||
158 | public function setNumInvalidSegment($num_invalid_segment) |
||
162 | |||
163 | public function getNumUnauthSegment() |
||
167 | |||
168 | public function setNumUnauthSegment($num_unauth_segment) |
||
172 | |||
173 | public function getNumPastExpiration() |
||
177 | |||
178 | public function setNumPastExpiration($num_past_expiration) |
||
182 | |||
183 | public function getNumInactiveSegment() |
||
187 | |||
188 | public function setNumInactiveSegment($num_inactive_segment) |
||
192 | |||
193 | public function getNumOtherError() |
||
197 | |||
198 | public function setNumOtherError($num_other_error) |
||
202 | |||
203 | public function getErrorLogLines() |
||
207 | |||
208 | public function setErrorLogLines($error_log_lines) |
||
212 | |||
213 | public function getSegmentLogLines() |
||
217 | |||
218 | public function setSegmentLogLines($segment_log_lines) |
||
222 | |||
223 | public function getId() |
||
227 | |||
228 | public function setId($id) |
||
232 | |||
233 | public function getJobId() |
||
237 | |||
238 | public function setJobId($job_id) |
||
242 | |||
243 | public function getMemberId() |
||
247 | |||
248 | public function setMemberId($member_id) |
||
252 | |||
253 | public function getCreatedOn() |
||
257 | |||
258 | public function setCreatedOn($created_on) |
||
262 | |||
263 | public function getLastModified() |
||
267 | |||
268 | public function setLastModified($last_modified) |
||
272 | |||
273 | public function isCompeted(): bool |
||
277 | |||
278 | public static function fromArray(array $objectArray) |
||
290 | } |
||
291 |