Complex classes like Traits often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Traits, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
12 | class Traits |
||
13 | { |
||
14 | |||
15 | use HydratableTrait; |
||
16 | |||
17 | /** @var int */ |
||
18 | protected $sid; |
||
19 | |||
20 | /** @var int */ |
||
21 | protected $pid; |
||
22 | |||
23 | /** @var string */ |
||
24 | protected $name; |
||
25 | |||
26 | /** @var string */ |
||
27 | protected $description; |
||
28 | |||
29 | /** @var string */ |
||
30 | protected $traitType; |
||
31 | |||
32 | /** @var string */ |
||
33 | protected $status; |
||
34 | |||
35 | /** @var int */ |
||
36 | protected $crUID; |
||
37 | |||
38 | /** @var int */ |
||
39 | protected $upUID; |
||
40 | |||
41 | /** @var string */ |
||
42 | protected $integrationCode; |
||
43 | |||
44 | /** @var int */ |
||
45 | protected $dataSourceId; |
||
46 | |||
47 | /** @var int */ |
||
48 | protected $folderId; |
||
49 | |||
50 | /** @var int */ |
||
51 | protected $count90Day; |
||
52 | |||
53 | /** @var int */ |
||
54 | protected $uniques90Day; |
||
55 | |||
56 | /** @var int */ |
||
57 | protected $uniques1Day; |
||
58 | |||
59 | /** @var int */ |
||
60 | protected $uniques14Day; |
||
61 | |||
62 | /** @var int */ |
||
63 | protected $uniques7Day; |
||
64 | |||
65 | /** @var int */ |
||
66 | protected $count14Day; |
||
67 | |||
68 | /** @var int */ |
||
69 | protected $count7Day; |
||
70 | |||
71 | /** @var int */ |
||
72 | protected $count30Day; |
||
73 | |||
74 | /** @var int */ |
||
75 | protected $uniques60Day; |
||
76 | |||
77 | /** @var int */ |
||
78 | protected $uniques30Day; |
||
79 | |||
80 | /** @var int */ |
||
81 | protected $count60Day; |
||
82 | |||
83 | /** @var int */ |
||
84 | protected $count1Day; |
||
85 | |||
86 | /** @var int */ |
||
87 | protected $countLifetime; |
||
88 | |||
89 | /** @var int */ |
||
90 | protected $uniquesLifetime; |
||
91 | |||
92 | /** @var \DateTime */ |
||
93 | protected $createTime; |
||
94 | |||
95 | /** @var \DateTime */ |
||
96 | protected $updateTime; |
||
97 | |||
98 | /** @var array() */ |
||
99 | protected $metrics = []; |
||
100 | |||
101 | |||
102 | /** |
||
103 | * @return int |
||
104 | */ |
||
105 | public function getSid() |
||
109 | |||
110 | /** |
||
111 | * @param int $sid |
||
112 | */ |
||
113 | public function setSid($sid) |
||
117 | |||
118 | /** |
||
119 | * @return int |
||
120 | */ |
||
121 | public function getPid() |
||
125 | |||
126 | /** |
||
127 | * @param int $pid |
||
128 | */ |
||
129 | public function setPid($pid) |
||
133 | |||
134 | /** |
||
135 | * @return string |
||
136 | */ |
||
137 | public function getName() |
||
141 | |||
142 | /** |
||
143 | * @param string $name |
||
144 | */ |
||
145 | public function setName($name) |
||
149 | |||
150 | /** |
||
151 | * @return string |
||
152 | */ |
||
153 | public function getDescription() |
||
157 | |||
158 | /** |
||
159 | * @param string $description |
||
160 | */ |
||
161 | public function setDescription($description) |
||
165 | |||
166 | /** |
||
167 | * @return string |
||
168 | */ |
||
169 | public function getTraitType() |
||
173 | |||
174 | /** |
||
175 | * @param string $traitType |
||
176 | */ |
||
177 | public function setTraitType($traitType) |
||
181 | |||
182 | /** |
||
183 | * @return string |
||
184 | */ |
||
185 | public function getStatus() |
||
189 | |||
190 | /** |
||
191 | * @param string $status |
||
192 | */ |
||
193 | public function setStatus($status) |
||
197 | |||
198 | /** |
||
199 | * @return int |
||
200 | */ |
||
201 | public function getCrUid() |
||
205 | |||
206 | /** |
||
207 | * @param int $crUID |
||
208 | */ |
||
209 | public function setCrUid($crUID) |
||
213 | |||
214 | /** |
||
215 | * @return int |
||
216 | */ |
||
217 | public function getUpUid() |
||
221 | |||
222 | /** |
||
223 | * @param int $upUID |
||
224 | */ |
||
225 | public function setUpUid($upUID) |
||
229 | |||
230 | /** |
||
231 | * @return string |
||
232 | */ |
||
233 | public function getIntegrationCode() |
||
237 | |||
238 | /** |
||
239 | * @param string $integrationCode |
||
240 | */ |
||
241 | public function setIntegrationCode($integrationCode) |
||
245 | |||
246 | /** |
||
247 | * @return int |
||
248 | */ |
||
249 | public function getDataSourceId() |
||
253 | |||
254 | /** |
||
255 | * @param int $dataSourceId |
||
256 | */ |
||
257 | public function setDataSourceId($dataSourceId) |
||
261 | |||
262 | /** |
||
263 | * @return int |
||
264 | */ |
||
265 | public function getFolderId() |
||
269 | |||
270 | /** |
||
271 | * @param int $folderId |
||
272 | */ |
||
273 | public function setFolderId($folderId) |
||
277 | |||
278 | /** |
||
279 | * @return int |
||
280 | */ |
||
281 | public function getCount90Day() |
||
285 | |||
286 | /** |
||
287 | * @param int $count90Day |
||
288 | */ |
||
289 | public function setCount90Day($count90Day) |
||
293 | |||
294 | /** |
||
295 | * @return int |
||
296 | */ |
||
297 | public function getUniques90Day() |
||
301 | |||
302 | /** |
||
303 | * @param int $uniques90Day |
||
304 | */ |
||
305 | public function setUniques90Day($uniques90Day) |
||
309 | |||
310 | /** |
||
311 | * @return int |
||
312 | */ |
||
313 | public function getUniques1Day() |
||
317 | |||
318 | /** |
||
319 | * @param int $uniques1Day |
||
320 | */ |
||
321 | public function setUniques1Day($uniques1Day) |
||
325 | |||
326 | /** |
||
327 | * @return int |
||
328 | */ |
||
329 | public function getUniques14Day() |
||
333 | |||
334 | /** |
||
335 | * @param int $uniques14Day |
||
336 | */ |
||
337 | public function setUniques14Day($uniques14Day) |
||
341 | |||
342 | /** |
||
343 | * @return int |
||
344 | */ |
||
345 | public function getUniques7Day() |
||
349 | |||
350 | /** |
||
351 | * @param int $uniques7Day |
||
352 | */ |
||
353 | public function setUniques7Day($uniques7Day) |
||
357 | |||
358 | /** |
||
359 | * @return int |
||
360 | */ |
||
361 | public function getCount14Day() |
||
365 | |||
366 | /** |
||
367 | * @param int $count14Day |
||
368 | */ |
||
369 | public function setCount14Day($count14Day) |
||
373 | |||
374 | /** |
||
375 | * @return int |
||
376 | */ |
||
377 | public function getCount7Day() |
||
381 | |||
382 | /** |
||
383 | * @param int $count7Day |
||
384 | */ |
||
385 | public function setCount7Day($count7Day) |
||
389 | |||
390 | /** |
||
391 | * @return int |
||
392 | */ |
||
393 | public function getCount30Day() |
||
397 | |||
398 | /** |
||
399 | * @param int $count30Day |
||
400 | */ |
||
401 | public function setCount30Day($count30Day) |
||
405 | |||
406 | /** |
||
407 | * @return int |
||
408 | */ |
||
409 | public function getUniques60Day() |
||
413 | |||
414 | /** |
||
415 | * @param int $uniques60Day |
||
416 | */ |
||
417 | public function setUniques60Day($uniques60Day) |
||
421 | |||
422 | /** |
||
423 | * @return int |
||
424 | */ |
||
425 | public function getUniques30Day() |
||
429 | |||
430 | /** |
||
431 | * @param int $uniques30Day |
||
432 | */ |
||
433 | public function setUniques30Day($uniques30Day) |
||
437 | |||
438 | /** |
||
439 | * @return int |
||
440 | */ |
||
441 | public function getCount60Day() |
||
445 | |||
446 | /** |
||
447 | * @param int $count60Day |
||
448 | */ |
||
449 | public function setCount60Day($count60Day) |
||
453 | |||
454 | /** |
||
455 | * @return int |
||
456 | */ |
||
457 | public function getCount1Day() |
||
461 | |||
462 | /** |
||
463 | * @param int $count1Day |
||
464 | */ |
||
465 | public function setCount1Day($count1Day) |
||
469 | |||
470 | /** |
||
471 | * @return int |
||
472 | */ |
||
473 | public function getCountLifetime() |
||
477 | |||
478 | /** |
||
479 | * @param int $countLifetime |
||
480 | */ |
||
481 | public function setCountLifetime($countLifetime) |
||
485 | |||
486 | /** |
||
487 | * @return int |
||
488 | */ |
||
489 | public function getUniquesLifetime() |
||
493 | |||
494 | /** |
||
495 | * @param int $uniquesLifetime |
||
496 | */ |
||
497 | public function setUniquesLifetime($uniquesLifetime) |
||
501 | |||
502 | /** |
||
503 | * @return \DateTime |
||
504 | */ |
||
505 | public function getCreateTime() |
||
509 | |||
510 | /** |
||
511 | * @param \DateTime $createTime |
||
512 | */ |
||
513 | public function setCreateTime(\DateTime $createTime) |
||
517 | |||
518 | /** |
||
519 | * @return \DateTime |
||
520 | */ |
||
521 | public function getUpdateTime() |
||
525 | |||
526 | /** |
||
527 | * @param \DateTime $updateTime |
||
528 | */ |
||
529 | public function setUpdateTime(\DateTime $updateTime) |
||
533 | |||
534 | /** |
||
535 | * @return array |
||
536 | */ |
||
537 | public function getMetrics() |
||
541 | |||
542 | /** |
||
543 | * @param array $metrics |
||
544 | */ |
||
545 | public function setMetrics(array $metrics) |
||
549 | |||
550 | public function addMetrics($metric) |
||
554 | |||
555 | public function toInsertArray() |
||
575 | } |
||
576 |