DataProviderAudienceHydrator::fromStdClass() - Code Metrics - Audiens/adform-client - Measure and Improve Code Quality continuously with Scrutinizer

DataProviderAudienceHydrator::fromStdClass() A
last analyzed 2020-04-27 16:18 UTC

↳ Parent: DataProviderAudienceHydrator

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	12
rs	9.9666
cc	1
nc	1
nop	1

<?php declare(strict_types=1);

namespace Audiens\AdForm\Entity;

use DateTime;
use stdClass;

/**
 * Class DataProviderAudienceHydrator
 */
class DataProviderAudienceHydrator extends DataProviderAudience
{
    /**
     * Hydrate a DataProviderAudience from a stdClass, intended to be used for
     * instancing a result from \json_decode()
     *
     * @param stdClass $stdClass
     *
     * @return DataProviderAudience
     */
    public static function fromStdClass(stdClass $stdClass): DataProviderAudience
    {
        $dataProviderAudience = new DataProviderAudience();
        $dataProviderAudience->dataProvider = $stdClass->dataProvider;
        $dataProviderAudience->dataProviderId = $stdClass->dataProviderId;
        $dataProviderAudience->total = (int)$stdClass->total;
        $dataProviderAudience->unique = (int)$stdClass->unique;
        $dataProviderAudience->totalHits = (int)$stdClass->totalHits;
        $dataProviderAudience->uniqueHits = (int)$stdClass->uniqueHits;
        $dataProviderAudience->date = DateParser::parse($stdClass->date);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $dataProviderAudience;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Audiens\AdForm\Entity;
4
5			use DateTime;
6			use stdClass;
7
8			/**
9			* Class DataProviderAudienceHydrator
10			*/
11			class DataProviderAudienceHydrator extends DataProviderAudience
12			{
13			/**
14			* Hydrate a DataProviderAudience from a stdClass, intended to be used for
15			* instancing a result from \json_decode()
16			*
17			* @param stdClass $stdClass
18			*
19			* @return DataProviderAudience
20			*/
21			public static function fromStdClass(stdClass $stdClass): DataProviderAudience
22			{
23			$dataProviderAudience = new DataProviderAudience();
24			$dataProviderAudience->dataProvider = $stdClass->dataProvider;
25			$dataProviderAudience->dataProviderId = $stdClass->dataProviderId;
26			$dataProviderAudience->total = (int)$stdClass->total;
27			$dataProviderAudience->unique = (int)$stdClass->unique;
28			$dataProviderAudience->totalHits = (int)$stdClass->totalHits;
29			$dataProviderAudience->uniqueHits = (int)$stdClass->uniqueHits;
30			$dataProviderAudience->date = DateParser::parse($stdClass->date);
			0 ignored issues – show Documentation Bug introduced 2018-11-05 10:44 UTC by Report Bug Copy Issue Report It seems like `Audiens\AdForm\Entity\Da...:parse($stdClass->date)` can also be of type `false`. However, the property `$date` is declared as type `DateTime\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
31
32			return $dataProviderAudience;
33			}
34			}
35

Audiens / adform-client

DataProviderAudienceHydrator::fromStdClass() A last analyzed 2020-04-27 16:18 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DataProviderAudienceHydrator::fromStdClass() A
last analyzed 2020-04-27 16:18 UTC