Audiens\AdForm\Entity\SegmentHydrator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	fromStdClass()	0	40	4

<?php declare(strict_types=1);

namespace Audiens\AdForm\Entity;

use Audiens\AdForm\Enum\SegmentStatus;
use stdClass;

/**
 * Class SegmentHydrator
 */
class SegmentHydrator extends Segment
{
    /**
     * Hydrate a segment from a stdClass, intended to be used for
     * instancing a segment from \json_decode()
     *
     * @param stdClass $stdClass
     *
     * @return Segment
     */
    public static function fromStdClass(stdClass $stdClass): Segment
    {
        $segment = new Segment();

        $segment->id = (int) $stdClass->id;
        $segment->dataProviderId = (int)$stdClass->dataProviderId;
        $segment->status = new SegmentStatus($stdClass->status);
        $segment->categoryId = (int)$stdClass->categoryId;
        $segment->refId = $stdClass->refId;
        $segment->fee = (float)$stdClass->fee;
        $segment->ttl = (int)$stdClass->ttl;
        $segment->name = $stdClass->name;

        // might not be set in JSON
        if (isset($stdClass->formula)) {
            $segment->formula = $stdClass->formula;
        }

        // might not be set in JSON
        if (isset($stdClass->extractionRule)) {
            $segment->extractionRule = $stdClass->extractionRule;
        }

        $segment->audience = (bool)$stdClass->audience;
        $segment->audienceBySources = $stdClass->audienceBySources;
        $segment->audienceByUserIdentityType = $stdClass->audienceByUserIdentityType;
        $segment->isExtended = (bool)$stdClass->isExtended;

        $segment->frequency = (int)$stdClass->frequency;
        $segment->isCrossDevice = (bool)$stdClass->isCrossDevice;
        $segment->hasDataUsagePermissions = (bool)$stdClass->hasDataUsagePermissions;

        $segment->updatedAt = DateParser::parse($stdClass->updatedAt);

It seems like Audiens\AdForm\Entity\DateParser::parse($stdClass->updatedAt) can also be of type false. However, the property $updatedAt is declared as type DateTime|null. Maybe add an additional type check?

        $segment->createdAt = DateParser::parse($stdClass->createdAt);

It seems like Audiens\AdForm\Entity\DateParser::parse($stdClass->createdAt) can also be of type false. However, the property $createdAt is declared as type DateTime|null. Maybe add an additional type check?

        if (isset($stdClass->unifiedTaxonomyLabelsIds)) {
            $segment->unifiedTaxonomyLabelIds = $stdClass->unifiedTaxonomyLabelsIds;
        }

        return $segment;
    }
}