Issues in Request.php (master) - Issues in master - Asymptix/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (307)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

framework/web/Request.php (15 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Asymptix\web;

use Asymptix\core\Tools;
use Asymptix\helpers\Naming;

/**
 * Request functionality.
 *
 * @category Asymptix PHP Framework
 * @author Dmytro Zarezenko <[email protected]>
 * @copyright (c) 2009 - 2017, Dmytro Zarezenko
 *
 * @git https://github.com/Asymptix/Framework
 * @license http://opensource.org/licenses/MIT
 */
class Request {

    /**
     * Check if form was submitted.
     *
     * @param string $submitFieldName Name of the submit field (button).
     *           Default: "submitBtn"
     *
     * @return bool
     */
    public static function isFormSubmitted($submitFieldName = "submitBtn") {
        return (self::getFieldValue($submitFieldName) !== null);
    }

    /**
     * Verify if field is exists in the request.
     *
     * @param mixed $fieldName String name of the field or complex name as array.
     * @param string $source Http::GET or Http::POST constant.
     *
     * @return bool
     */
    public static function issetField($fieldName, $source = null) {
        return !is_null(self::getFieldValue($fieldName, $source));
    }

    /**
     * Gets value of the field from $_REQUEST or $_SESSION (is some REQUEST values
     * needs to be stored by scenario). Also it takes values from $_GET or $_POST
     * separately if second parameter is passed.
     *
     * @param mixed $fieldName String name of the field or complex hierarchy name.
     * @param string $source Http::GET or Http::POST constant.
     *
     * @return mixed Value of the field, NULL otherwise.
     */
    public static function getFieldValue($fieldName, $source = null) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $value = null;

        try {
            switch ($source) {
                case (Http::GET):
                    $value = Naming::getValueByComplexName($_GET, $fieldName);
                    break;
                case (Http::POST):
                    $value = Naming::getValueByComplexName($_POST, $fieldName);
                    break;
                default:
                    $value = Naming::getValueByComplexName($_REQUEST, $fieldName);
            }
        } catch (\Exception $ex) {
            try {
                if (Session::exists('_post')) {
                    $value = Naming::getValueByComplexName(
                        Session::get('_post'), $fieldName
                    );
                }
            } catch (\Exception $ex) {
                return null;
            }
        }

        if (!is_null($value)) {
            if (is_array($value)) {
                return $value;
            } elseif (is_int($value)) {
                return intval($value);
            }

            return $value;
        }

        return null;
    }

    /**
     * Returns value of the HTTP GET requet field.
     *
     * @param mixed $fieldName String name of the field or complex name as array.
     * @param mixed $defaultValue Default value.
     *
     * @return mixed Value of the field, NULL otherwise.
     */
    public static function _get($fieldName, $defaultValue = null) {

        $fieldValue = self::getFieldValue($fieldName, Http::GET);
        if (is_null($fieldValue) && !is_null($defaultValue)) {
            return $defaultValue;
        }

        return $fieldValue;
    }

    /**
     * Returns value of the HTTP POST requet field.
     *
     * @param mixed $fieldName String name of the field or complex name as array.
     * @param mixed $defaultValue Default value.
     *
     * @return mixed Value of the field, NULL otherwise.
     */
    public static function _post($fieldName, $defaultValue = null) {

        $fieldValue = self::getFieldValue($fieldName, Http::POST);
        if (is_null($fieldValue) && !is_null($defaultValue)) {
            return $defaultValue;
        }

        return $fieldValue;
    }

    /**
     * Returns value of the HTTP POST or GET requet field.
     *
     * @param mixed $fieldName String name of the field or complex name as array.
     * @param mixed $defaultValue Default value.
     *
     * @return mixed Value of the field, NULL otherwise.
     */
    public static function _field($fieldName, $defaultValue = null) {

        $fieldValue = self::getFieldValue($fieldName);
        if (is_null($fieldValue) && !is_null($defaultValue)) {
            return $defaultValue;
        }

        return $fieldValue;
    }

    /**
     * Returns value of the filter field.
     *
     * @param string $filterName Name of the filter field.
     * @param mixed $defaultValue Default value.
     *
     * @return mixed
     */
    public static function _filter($filterName, $defaultValue) {
        return Tools::getFilterValue($filterName, $defaultValue);
    }

    /**
     * Sets value of the field or creates new field by pair $fieldName => $fieldValue.
     *
     * @global array<mixed> $_FIELDS Global fields list.
     * @param mixed $fieldName Name of the field as a string or complex name as
     *            an array.
     * @param mixed $fieldValue Value of the field.
     *
     * @throws \Exception
     */
    public static function setFieldValue($fieldName, $fieldValue) {
        global $_FIELDS;
function myFunction($a, $b) {
    // Do something
}

        Naming::setValueWithComplexName($_FIELDS, $fieldName, $fieldValue);
    }

    /**
     * Remembers field in session.
     *
     * @param string $fieldName Name of the field.
     * @param mixed $fieldValue
     */
    public static function rememberField($fieldName, $fieldValue) {
        Session::set("_post[{$fieldName}]", serialize($fieldValue));
    }

    /**
     * Forget cross session field.
     *
     * @param string $fieldName Field name.
     */
    public static function forgetField($fieldName) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        Naming::unsetValueWithComplexName($_SESSION, "_post[{$fieldName}]");
    }

    /**
     * Forget all cross session fields.
     *
     * @return bool
     */
    public static function forgetFields() {
        return Session::remove('_post');
    }

    /**
     * Clean all request parameters from provided source.
     *
     * @param string $source Http::GET or Http::POST constant.
     */
    public static function clean($source = null) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        switch ($source) {
            case (Http::GET):
                $_GET = [];

                break;
            case (Http::POST):
                $_POST = [];

                break;
            default:
                $_REQUEST = $_GET = $_POST = [];
        }
    }

    /**
     * Change value of the existing field.
     *
     * @global array<mixed> $_FIELDS Global fields list.
     * @param string $fieldName Name of the field.
     * @param mixed $fieldValue Value of the field.
     */
    public static function changeFieldValue($fieldName, $fieldValue) {
        global $_FIELDS;
function myFunction($a, $b) {
    // Do something
}

        if (isset($_FIELDS[$fieldName])) {
            $_FIELDS[$fieldName] = $fieldValue;
        } else {
            throw new \Exception("No field '" . $fieldName . "' in global fields list.");
        }
    }

    /**
     * Casts value if the existing field to specified type.
     *
     * @global array<mixed> $_FIELDS Global fields list.
     * @param string $fieldName Name of the field.
     * @param string $type New field value type.
     */
    public static function castFieldValue($fieldName, $type) {
        global $_FIELDS;
function myFunction($a, $b) {
    // Do something
}

        if (isset($_FIELDS[$fieldName])) {
            switch ($type) {
                case ('integer'):
                case ('int'):
                case ('i'):
                    $_FIELDS[$fieldName] = intval($_FIELDS[$fieldName]);
                    break;
                case ('real'):
                case ('float'):
                case ('double'):
                case ('d'):
                    $_FIELDS[$fieldName] = floatval($_FIELDS[$fieldName]);
                    break;
                case ('string'):
                case ('str'):
                case ('s'):
                    $_FIELDS[$fieldName] = strval($_FIELDS[$fieldName]);
                    break;
                case ('boolean'):
                case ('bool'):
                case ('b'):
                    $_FIELDS[$fieldName] = (bool)$_FIELDS[$fieldName];
            }
        } else {
            throw new \Exception("No field '" . $fieldName . "' in global fields list.");
        }
    }

    /**
     * Normilize all boolean checkboxes even they are not checked.
     *
     * @global array $_FIELDS Submitted form fields.
     * @param array<string> $fieldNames Names of all boolean checkboxes what need
     *           fixes.
     */
    public static function normalizeCheckboxes($fieldNames) {
        global $_FIELDS;
function myFunction($a, $b) {
    // Do something
}

        foreach ($fieldNames as $fieldName) {
            $_FIELDS[$fieldName] = (int)(bool)self::getFieldValue($fieldName);
        }
    }

    /**
     * Removes fields from global fields list.
     *
     * @param array<string> $fieldNames Names of all boolean checkboxes what need
     *           fixes (may be list of complex field names).
     */
    public static function removeFields($fieldNames) {
        global $_FIELDS;
function myFunction($a, $b) {
    // Do something
}

        foreach ($fieldNames as $fieldName) {
            Naming::unsetValueWithComplexName($_FIELDS, $fieldName);
        }
    }

}


Issues (307)

Security Analysis not enabled

framework/web/Request.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2
3		namespace Asymptix\web;
4
5		use Asymptix\core\Tools;
6		use Asymptix\helpers\Naming;
7
8		/**
9		* Request functionality.
10		*
11		* @category Asymptix PHP Framework
12		* @author Dmytro Zarezenko <[email protected]>
13		* @copyright (c) 2009 - 2017, Dmytro Zarezenko
14		*
15		* @git https://github.com/Asymptix/Framework
16		* @license http://opensource.org/licenses/MIT
17		*/
18		class Request {
19
20		/**
21		* Check if form was submitted.
22		*
23		* @param string $submitFieldName Name of the submit field (button).
24		* Default: "submitBtn"
25		*
26		* @return bool
27		*/
28		public static function isFormSubmitted($submitFieldName = "submitBtn") {
29		return (self::getFieldValue($submitFieldName) !== null);
30		}
31
32		/**
33		* Verify if field is exists in the request.
34		*
35		* @param mixed $fieldName String name of the field or complex name as array.
36		* @param string $source Http::GET or Http::POST constant.
37		*
38		* @return bool
39		*/
40		public static function issetField($fieldName, $source = null) {
41		return !is_null(self::getFieldValue($fieldName, $source));
42		}
43
44		/**
45		* Gets value of the field from $_REQUEST or $_SESSION (is some REQUEST values
46		* needs to be stored by scenario). Also it takes values from $_GET or $_POST
47		* separately if second parameter is passed.
48		*
49		* @param mixed $fieldName String name of the field or complex hierarchy name.
50		* @param string $source Http::GET or Http::POST constant.
51		*
52		* @return mixed Value of the field, NULL otherwise.
53		*/
54		public static function getFieldValue($fieldName, $source = null) {
		0 ignored issues – show Coding Style introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getFieldValue` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getFieldValue` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getFieldValue` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
55		$value = null;
56
57		try {
58		switch ($source) {
59		case (Http::GET):
60		$value = Naming::getValueByComplexName($_GET, $fieldName);
61		break;
62		case (Http::POST):
63		$value = Naming::getValueByComplexName($_POST, $fieldName);
64		break;
65		default:
66		$value = Naming::getValueByComplexName($_REQUEST, $fieldName);
67		}
68		} catch (\Exception $ex) {
69		try {
70		if (Session::exists('_post')) {
71		$value = Naming::getValueByComplexName(
72		Session::get('_post'), $fieldName
73		);
74		}
75		} catch (\Exception $ex) {
76		return null;
77		}
78		}
79
80		if (!is_null($value)) {
81		if (is_array($value)) {
82		return $value;
83		} elseif (is_int($value)) {
84		return intval($value);
85		}
86
87		return $value;
88		}
89
90		return null;
91		}
92
93		/**
94		* Returns value of the HTTP GET requet field.
95		*
96		* @param mixed $fieldName String name of the field or complex name as array.
97		* @param mixed $defaultValue Default value.
98		*
99		* @return mixed Value of the field, NULL otherwise.
100		*/
101	View Code Duplication	public static function _get($fieldName, $defaultValue = null) {
		0 ignored issues – show Duplication introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		$fieldValue = self::getFieldValue($fieldName, Http::GET);
103		if (is_null($fieldValue) && !is_null($defaultValue)) {
104		return $defaultValue;
105		}
106
107		return $fieldValue;
108		}
109
110		/**
111		* Returns value of the HTTP POST requet field.
112		*
113		* @param mixed $fieldName String name of the field or complex name as array.
114		* @param mixed $defaultValue Default value.
115		*
116		* @return mixed Value of the field, NULL otherwise.
117		*/
118	View Code Duplication	public static function _post($fieldName, $defaultValue = null) {
		0 ignored issues – show Duplication introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		$fieldValue = self::getFieldValue($fieldName, Http::POST);
120		if (is_null($fieldValue) && !is_null($defaultValue)) {
121		return $defaultValue;
122		}
123
124		return $fieldValue;
125		}
126
127		/**
128		* Returns value of the HTTP POST or GET requet field.
129		*
130		* @param mixed $fieldName String name of the field or complex name as array.
131		* @param mixed $defaultValue Default value.
132		*
133		* @return mixed Value of the field, NULL otherwise.
134		*/
135	View Code Duplication	public static function _field($fieldName, $defaultValue = null) {
		0 ignored issues – show Duplication introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136		$fieldValue = self::getFieldValue($fieldName);
137		if (is_null($fieldValue) && !is_null($defaultValue)) {
138		return $defaultValue;
139		}
140
141		return $fieldValue;
142		}
143
144		/**
145		* Returns value of the filter field.
146		*
147		* @param string $filterName Name of the filter field.
148		* @param mixed $defaultValue Default value.
149		*
150		* @return mixed
151		*/
152		public static function _filter($filterName, $defaultValue) {
153		return Tools::getFilterValue($filterName, $defaultValue);
154		}
155
156		/**
157		* Sets value of the field or creates new field by pair $fieldName => $fieldValue.
158		*
159		* @global array<mixed> $_FIELDS Global fields list.
160		* @param mixed $fieldName Name of the field as a string or complex name as
161		* an array.
162		* @param mixed $fieldValue Value of the field.
163		*
164		* @throws \Exception
165		*/
166		public static function setFieldValue($fieldName, $fieldValue) {
167		global $_FIELDS;
		0 ignored issues – show Compatibility Best Practice introduced 2016-12-16 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
168
169		Naming::setValueWithComplexName($_FIELDS, $fieldName, $fieldValue);
170		}
171
172		/**
173		* Remembers field in session.
174		*
175		* @param string $fieldName Name of the field.
176		* @param mixed $fieldValue
177		*/
178		public static function rememberField($fieldName, $fieldValue) {
179		Session::set("_post[{$fieldName}]", serialize($fieldValue));
180		}
181
182		/**
183		* Forget cross session field.
184		*
185		* @param string $fieldName Field name.
186		*/
187		public static function forgetField($fieldName) {
		0 ignored issues – show Coding Style introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `forgetField` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
188		Naming::unsetValueWithComplexName($_SESSION, "_post[{$fieldName}]");
189		}
190
191		/**
192		* Forget all cross session fields.
193		*
194		* @return bool
195		*/
196		public static function forgetFields() {
197		return Session::remove('_post');
198		}
199
200		/**
201		* Clean all request parameters from provided source.
202		*
203		* @param string $source Http::GET or Http::POST constant.
204		*/
205		public static function clean($source = null) {
		0 ignored issues – show Coding Style introduced 2017-07-17 10:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `clean` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-07-17 10:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `clean` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-07-17 10:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `clean` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
206		switch ($source) {
207		case (Http::GET):
208		$_GET = [];
209
210		break;
211		case (Http::POST):
212		$_POST = [];
213
214		break;
215		default:
216		$_REQUEST = $_GET = $_POST = [];
217		}
218		}
219
220		/**
221		* Change value of the existing field.
222		*
223		* @global array<mixed> $_FIELDS Global fields list.
224		* @param string $fieldName Name of the field.
225		* @param mixed $fieldValue Value of the field.
226		*/
227		public static function changeFieldValue($fieldName, $fieldValue) {
228		global $_FIELDS;
		0 ignored issues – show Compatibility Best Practice introduced 2016-12-16 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
229
230		if (isset($_FIELDS[$fieldName])) {
231		$_FIELDS[$fieldName] = $fieldValue;
232		} else {
233		throw new \Exception("No field '" . $fieldName . "' in global fields list.");
234		}
235		}
236
237		/**
238		* Casts value if the existing field to specified type.
239		*
240		* @global array<mixed> $_FIELDS Global fields list.
241		* @param string $fieldName Name of the field.
242		* @param string $type New field value type.
243		*/
244		public static function castFieldValue($fieldName, $type) {
245		global $_FIELDS;
		0 ignored issues – show Compatibility Best Practice introduced 2016-12-16 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
246
247		if (isset($_FIELDS[$fieldName])) {
248		switch ($type) {
249		case ('integer'):
250		case ('int'):
251		case ('i'):
252		$_FIELDS[$fieldName] = intval($_FIELDS[$fieldName]);
253		break;
254		case ('real'):
255		case ('float'):
256		case ('double'):
257		case ('d'):
258		$_FIELDS[$fieldName] = floatval($_FIELDS[$fieldName]);
259		break;
260		case ('string'):
261		case ('str'):
262		case ('s'):
263		$_FIELDS[$fieldName] = strval($_FIELDS[$fieldName]);
264		break;
265		case ('boolean'):
266		case ('bool'):
267		case ('b'):
268		$_FIELDS[$fieldName] = (bool)$_FIELDS[$fieldName];
269		}
270		} else {
271		throw new \Exception("No field '" . $fieldName . "' in global fields list.");
272		}
273		}
274
275		/**
276		* Normilize all boolean checkboxes even they are not checked.
277		*
278		* @global array $_FIELDS Submitted form fields.
279		* @param array<string> $fieldNames Names of all boolean checkboxes what need
280		* fixes.
281		*/
282		public static function normalizeCheckboxes($fieldNames) {
283		global $_FIELDS;
		0 ignored issues – show Compatibility Best Practice introduced 2016-12-16 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
284
285		foreach ($fieldNames as $fieldName) {
286		$_FIELDS[$fieldName] = (int)(bool)self::getFieldValue($fieldName);
287		}
288		}
289
290		/**
291		* Removes fields from global fields list.
292		*
293		* @param array<string> $fieldNames Names of all boolean checkboxes what need
294		* fixes (may be list of complex field names).
295		*/
296		public static function removeFields($fieldNames) {
297		global $_FIELDS;
		0 ignored issues – show Compatibility Best Practice introduced 2016-12-16 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
298
299		foreach ($fieldNames as $fieldName) {
300		Naming::unsetValueWithComplexName($_FIELDS, $fieldName);
301		}
302		}
303
304		}
305

Asymptix / Framework

Issues (307)

Security Analysis not enabled

framework/web/Request.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like