Email::sendSignUpNotification() - Code Metrics - Asymptix/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Email::sendSignUpNotification() A
last analyzed 2018-07-31 14:35 UTC

↳ Parent: Email

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0

<?php

use conf\Config;
use Asymptix\core\Validator;

/**
 * Email class example.
 *
 * @category Asymptix PHP Framework
 * @author Dmytro Zarezenko <[email protected]>
 * @copyright (c) 2015, Dmytro Zarezenko
 *
 * @git https://github.com/Asymptix/Framework
 * @license http://opensource.org/licenses/MIT
 */
class Email extends \Asymptix\mail\Email {
namespace YourVendor;

class YourClass { }

    /**
     * Send e-mail notification about user signup to the admin.
     *
     * @global Language $_LANG Global language object.
     * @param User $user Registered User object.
     *
     * @return boolean Returns TRUE if the mail was successfully accepted for
     *           delivery, FALSE otherwise.
     */
    public function sendSignUpAdminNotification($user) {
        global $_LANG;
function myFunction($a, $b) {
    // Do something
}

        return $this->sendNotification(
            Config::EMAIL_ADMIN,
            "New user signup: '" . $user->username . "'",
            $_LANG->code,
            "signup_admin_email",
            array(
                'user_id' => $user->id,
                'username' => $user->username
            ),
            Email::FORMAT_HTML
        );
    }

    /**
     * Send e-mail notification about user signup.
     *
     * @global Language $_LANG Global language object.
     * @param User $user Registered User object.
     *
     * @return boolean Returns TRUE if the mail was successfully accepted for
     *           delivery, FALSE otherwise.
     * @throws \Exception If users e-mail is invalid.
     */
    public function sendSignUpNotification($user) {
        global $_LANG;
function myFunction($a, $b) {
    // Do something
}

        if (!Validator::isEmail($user->email)) {
            throw new \Exception("Invalid email: '" . $user->email . "'");
        }

        return $this->sendNotification(
            $user->email,
            "You registered successfully",
            $_LANG->code,
            "signup_email",
            array(
                'user_id' => $user->id,
                'username' => $user->username
            ),
            Email::FORMAT_HTML
        );
    }

}


Email::sendSignUpNotification() A
last analyzed 2018-07-31 14:35 UTC

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			use conf\Config;
4			use Asymptix\core\Validator;
5
6			/**
7			* Email class example.
8			*
9			* @category Asymptix PHP Framework
10			* @author Dmytro Zarezenko <[email protected]>
11			* @copyright (c) 2015, Dmytro Zarezenko
12			*
13			* @git https://github.com/Asymptix/Framework
14			* @license http://opensource.org/licenses/MIT
15			*/
16			class Email extends \Asymptix\mail\Email {
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
17
18			/**
19			* Send e-mail notification about user signup to the admin.
20			*
21			* @global Language $_LANG Global language object.
22			* @param User $user Registered User object.
23			*
24			* @return boolean Returns TRUE if the mail was successfully accepted for
25			* delivery, FALSE otherwise.
26			*/
27			public function sendSignUpAdminNotification($user) {
28			global $_LANG;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
29
30			return $this->sendNotification(
31			Config::EMAIL_ADMIN,
32			"New user signup: '" . $user->username . "'",
33			$_LANG->code,
34			"signup_admin_email",
35			array(
36			'user_id' => $user->id,
37			'username' => $user->username
38			),
39			Email::FORMAT_HTML
40			);
41			}
42
43			/**
44			* Send e-mail notification about user signup.
45			*
46			* @global Language $_LANG Global language object.
47			* @param User $user Registered User object.
48			*
49			* @return boolean Returns TRUE if the mail was successfully accepted for
50			* delivery, FALSE otherwise.
51			* @throws \Exception If users e-mail is invalid.
52			*/
53			public function sendSignUpNotification($user) {
54			global $_LANG;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-26 12:49 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
55
56			if (!Validator::isEmail($user->email)) {
57			throw new \Exception("Invalid email: '" . $user->email . "'");
58			}
59
60			return $this->sendNotification(
61			$user->email,
62			"You registered successfully",
63			$_LANG->code,
64			"signup_email",
65			array(
66			'user_id' => $user->id,
67			'username' => $user->username
68			),
69			Email::FORMAT_HTML
70			);
71			}
72
73			}
74

Asymptix / Framework

Email::sendSignUpNotification() A last analyzed 2018-07-31 14:35 UTC

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

Email::sendSignUpNotification() A
last analyzed 2018-07-31 14:35 UTC