Astrotomic\Stancy\Factories\FeedFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	makeFromSheetCollectionName()	0	5	1
A	__construct()	0	3	1
A	makeFromSheetCollection()	0	5	1

<?php

namespace Astrotomic\Stancy\Factories;

use Astrotomic\Stancy\Contracts\FeedFactory as FeedFactoryContract;
use Astrotomic\Stancy\Contracts\PageFactory as PageFactoryContract;
use Spatie\Sheets\Facades\Sheets;
use Spatie\Sheets\Repository as SheetRepository;
use Spatie\Sheets\Sheet;

class FeedFactory implements FeedFactoryContract
{
    /** @var PageFactoryContract */
    protected $pageFactory;

    public function __construct(PageFactoryContract $pageFactory)
    {
        $this->pageFactory = $pageFactory;
    }

    public function makeFromSheetCollection(SheetRepository $collection): array

Method \Astrotomic\Stancy\Factories\FeedFactory::makeFromSheetCollection() does not have @return annotation for its traversable return value.

    {
        return $collection->all()->map(function(Sheet $sheet) {

You should change the following
<fg=red>- return $collection->all()->map(function(Sheet $sheet) {
</><fg=green>+ return $collection->all()->map(function (Sheet $sheet) {
</>

            return $this->pageFactory->makeFromSheet($sheet);
        })->all();
    }

    public function makeFromSheetCollectionName(string $name): array

Method \Astrotomic\Stancy\Factories\FeedFactory::makeFromSheetCollectionName() does not have @return annotation for its traversable return value.

    {
        $collection = Sheets::collection($name);

        return $this->makeFromSheetCollection($collection);
    }
}