Astrotomic\Stancy\Factories\SitemapFactory

Complexity

Total Complexity

9

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	makeFromSheetCollectionName()	0	3	1
A	makeFromSheetList()	0	17	3
A	sheetToPage()	0	3	1
A	sheetsToPages()	0	5	1
A	makeFromPages()	0	9	2

<?php

namespace Astrotomic\Stancy\Factories;

use Astrotomic\Stancy\Contracts\Page as PageContract;
use Astrotomic\Stancy\Contracts\PageFactory as PageFactoryContract;
use Astrotomic\Stancy\Contracts\SitemapFactory as SitemapFactoryContract;
use Illuminate\Support\Str;
use Spatie\Sheets\Facades\Sheets;
use Spatie\Sheets\Sheet;
use Spatie\Sitemap\Sitemap;

class SitemapFactory implements SitemapFactoryContract
{
    /** @var PageFactoryContract */
    protected $pageFactory;

    public function __construct(PageFactoryContract $pageFactory)
    {
        $this->pageFactory = $pageFactory;
    }

    /**
     * @param PageContract[] $pages
     *
     * @return Sitemap
     */
    public function makeFromPages(array $pages): Sitemap
    {
        $sitemap = Sitemap::create();

        foreach($pages as $page) {

You should change the following
<fg=red>- foreach($pages as $page) {
</><fg=green>+ foreach ($pages as $page) {
</>

            $sitemap->add($page->toSitemapItem());
        }

        return $sitemap;
    }

    /**
     * @param string[] $list
     *
     * @return Sitemap
     */
    public function makeFromSheetList(array $list): Sitemap
    {
        $pages = [];

        foreach($list as $entry) {

You should change the following
<fg=red>- foreach($list as $entry) {
</><fg=green>+ foreach ($list as $entry) {
</>

            if (Str::contains($entry, ':')) {
                [$collection, $path] = explode(':', $entry);

                $pages[] = $this->sheetToPage(Sheets::collection($collection)->get($path));

It seems like Spatie\Sheets\Facades\Sheets::collection($collection)->get($path) can also be of type null; however, parameter $sheet of Astrotomic\Stancy\Factories\SitemapFactory::sheetToPage() does only seem to accept Spatie\Sheets\Sheet, maybe add an additional type check?

                continue;
            }

            $pages = array_merge($pages, $this->sheetsToPages(Sheets::collection($entry)->all()->all()));
        }

        return $this->makeFromPages($pages);
    }

    public function makeFromSheetCollectionName(string $name): Sitemap
    {
        return $this->makeFromSheetList([$name]);
    }

    /**
     * @param Sheet[] $sheets
     *
     * @return PageContract[]
     */
    protected function sheetsToPages(array $sheets): array
    {
        return array_map(function(Sheet $sheet): PageContract {

You should change the following
<fg=red>- return array_map(function(Sheet $sheet): PageContract {
</><fg=green>+ return array_map(function (Sheet $sheet): PageContract {
</>

            return $this->sheetToPage($sheet);
        }, $sheets);
    }

    protected function sheetToPage(Sheet $sheet): PageContract
    {
        return $this->pageFactory->makeFromSheet($sheet);
    }
}