Astrotomic\Stancy\Models\PageData

Complexity

Total Complexity

8

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	parseArray()	0	29	7
A	make()	0	3	1

<?php

namespace Astrotomic\Stancy\Models;

use DateTime;
use Illuminate\Contracts\Support\Arrayable;
use Spatie\DataTransferObject\DataTransferObject;

abstract class PageData extends DataTransferObject implements Arrayable
{
    public static function make(array $data): self

Method \Astrotomic\Stancy\Models\PageData::make() does not have @param annotation for its traversable parameter $data.

    {
        return new static($data);
    }

    // https://github.com/spatie/data-transfer-object/issues/64
    protected function parseArray(array $array): array

Only 2 indentation levels per function/method. Found 3 levels.

Method \Astrotomic\Stancy\Models\PageData::parseArray() does not have @param annotation for its traversable parameter $array.

Method \Astrotomic\Stancy\Models\PageData::parseArray() does not have @return annotation for its traversable return value.

    {
        foreach ($array as $key => $value) {
            if (is_object($value)) {
                if($value instanceof DateTime) {

You should change the following
<fg=red>- if($value instanceof DateTime) {
</><fg=green>+ if ($value instanceof DateTime) {
</>

                    $array[$key] = $value->format(DATE_RFC3339);

                    continue;
                }

                if (method_exists($value, 'toArray')) {
                    $array[$key] = $value->toArray();

                    continue;
                }

                if (method_exists($value, '__toString')) {
                    $array[$key] = $value->__toString();

                    continue;
                }
            }

            if (is_array($value)) {
                $array[$key] = $this->parseArray($value);
            }
        }

        return $array;
    }
}