Astrotomic\Stancy\Factories\SitemapFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	makeFromSheetCollection()	0	9	1
A	makeFromSheetCollectionName()	0	5	1

<?php

namespace Astrotomic\Stancy\Factories;

use Astrotomic\Stancy\Contracts\SitemapFactory as SitemapFactoryContract;

You should change the following
<fg=green>+use Astrotomic\Stancy\Contracts\PageFactory as PageFactoryContract;
</>

use Astrotomic\Stancy\Contracts\PageFactory as PageFactoryContract;

You should change the following
<fg=red>-use Astrotomic\Stancy\Contracts\PageFactory as PageFactoryContract;
</>

use Spatie\Sheets\Facades\Sheets;
use Spatie\Sheets\Repository as SheetRepository;
use Spatie\Sheets\Sheet;
use Spatie\Sitemap\Sitemap;

class SitemapFactory implements SitemapFactoryContract
{
    /** @var PageFactoryContract */
    protected $pageFactory;

    public function __construct(PageFactoryContract $pageFactory)
    {
        $this->pageFactory = $pageFactory;
    }

    public function makeFromSheetCollection(SheetRepository $collection): Sitemap
    {
        $sitemap = Sitemap::create();

        $collection->all()->each(function(Sheet $sheet) use ($sitemap) {

Closure does not have void return type hint.

You should change the following
<fg=red>- $collection->all()->each(function(Sheet $sheet) use ($sitemap) {
</><fg=green>+ $collection->all()->each(function(Sheet $sheet) use ($sitemap): void {
</>

You should change the following
<fg=red>- $collection->all()->each(function(Sheet $sheet) use ($sitemap) {
</><fg=green>+ $collection->all()->each(function (Sheet $sheet) use ($sitemap) {
</>

            $sitemap->add($this->pageFactory->makeFromSheet($sheet)->toSitemapItem());
        });

        return $sitemap;
    }

    public function makeFromSheetCollectionName(string $name): Sitemap
    {
        $collection = Sheets::collection($name);

        return $this->makeFromSheetCollection($collection);
    }
}