AshPowell / APAnalytics

src/Traits/IsAnalytic.php

<?php

namespace AshPowell\APAnalytics\Traits;

use App\User;

The type App\User was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Support\Str;
use \Carbon\Carbon;
use \Carbon\CarbonPeriod;

trait IsAnalytic
{
    public function initializeIsAnalytic()
    {
        $this->connection = config('apanalytics.db_connection');

The property connection does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->collection = Str::plural(Str::before($this->getTable(), '_analytic'));

It seems like getTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The property collection does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->dates      = ['created_at', 'updated_at'];

The property dates does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->guarded    = [];

The property guarded does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function canViewCollection(User $user = null)
    {
        if (app()->runningInConsole()) {

The method runningInConsole() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

            return true;
        }

        if (! $user) {
            return false;
        }

        return $user->isAnyAdmin();
    }

    /**
     * Returns the month on month analytic count
     *
     * @param string $period
     * @return Array
     */
    public static function getCumulativeGrowthData($period = 6)
    {
        $endDate   = now();
        $startDate = $endDate->copy()->subMonths($period);

It seems like $period can also be of type string; however, parameter $value of Carbon\Carbon::subMonths() does only seem to accept integer, maybe add an additional type check?

        $period    = CarbonPeriod::create($startDate, "1 month", $endDate);

        $output = [];
        foreach ($period as $date) {
            $date  = $date->format('d-m-Y');

The method format() does not exist on null.

            $output[$date] = (new static)->getCountForDate($date, 'd-m-Y');
        }

        return $output;
    }

    /**
     * Returns the analytic count for the specified month
     *
     * @param String $date
     * @param String $format
     * @return Int
     */
    public static function getCountForDate($date, $format)
    {
        $currentDate = Carbon::createFromFormat($format, $date);

        $currentCount = (new static)
            ->where('created_at', '<=', $currentDate)

It seems like where() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->count();

        return $currentCount;
    }
}