APAnalytics::show() - Code Metrics - Inspection of "bla" - AshPowell/APAnalytics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ef5122...a9751c )

by Ash

created 2019-01-18 16:10 UTC

APAnalytics::show() C

↳ Parent: APAnalytics

Complexity

Conditions	13
Paths	132

Size

Total Lines	74
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	35
nc	132
nop	4
dl	0
loc	74
rs	6.35
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace AshPowell\APAnalytics;

use App\User;
filter:
    dependency_paths: ["lib/*"]
use AshPowell\APAnalytics\Jobs\Track;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;
use InvalidArgumentException;
use MongoDB\Driver\Cursor;
use MongoDB\Model\BSONDocument;

class APAnalytics
{
    protected $connection;
    protected $namespace;

    /**
     * Instantiate a new instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->connection = config('apanalytic.db_connection', 'mongodb');
        $this->namespace  = config('apanalytic.namespace', '\App\\');
    }

    /**
     * Track the Analytic.
     *
     * @return void
     * @param  mixed      $collection
     * @param  mixed      $items
     * @param  null|mixed $userId
     * @param  mixed      $params
     */
    public function track($collection, $items, $userId = null, $params = [])
    {
        Track::dispatch($collection, $items, $userId, $params);

        return true;

    }

    /**
     * Get the Analytics.
     *
     * @return void
     * @param  mixed      $collection
     * @param  null|mixed $timeframe
     * @param  null|mixed $filters
     * @param  mixed      $interval
     */
    public function show($collection, $interval = 'count', $timeframe = null, $filters = null)
    {
        $start        = $timeframe ? array_get($timeframe, 'start') : null;
        $end          = $timeframe ? array_get($timeframe, 'end') : null;
        $matchArray   = [];
        $filters      = json_decode($filters);

        $model = $this->namespace.studly_case(str_singular($collection)).'Analytic';

        if (! class_exists($model)) {
            throw new InvalidArgumentException("Model {$model} does not exist.");
        }

        if ($filters) {
            foreach ($filters as $filter) {
                $propertyValue = $filter->property_value;

                if (is_numeric($propertyValue)) {
                    $propertyValue = (int) $propertyValue;
                }

                $matchArray = array_merge($matchArray, [$filter->property_name => $propertyValue]);
            }
        }

        abort_unless($this->canViewAnalytic($matchArray, auth()->user()), 403, 'You dont have permission to view these analytics');

        if ($start) {
            $matchArray['created_at']['$gte'] = mongoTime($start);
        }

        if ($end) {
            $matchArray['created_at']['$lt'] = mongoTime($end);
        }

        $aggregate = [];

        if ($matchArray) {
            $aggregate[] = ['$match' => $matchArray];
        }

        $aggregate[] = ['$sort' => ['created_at' => 1]];

        $aggregate[] = [
            '$project' => [
                'created_at' => 1
            ],
        ];

        //$aggregate[] = ['$batchSize' => 1000];

        // $data = DB::connection($this->connection)
        //     ->collection($collection)
        //     ->raw(function ($query) use ($aggregate) {
        //         return $query->aggregate($aggregate);
        //     });

        $data = DB::connection($this->connection)
                ->collection($collection)
                ->/** @scrutinizer ignore-call */ collection($collection)
                ->raw(function ($collection) use ($matchArray, $interval, $aggregate) {
                    if ($interval == 'count') {
                        return $collection->count($matchArray);
                    }

                    if ($aggregate) {
                        return $collection->aggregate($aggregate, ['allowDiskUse' => true]);
                    }
                });

        if ($interval != 'count') {
            $data = $this->toModels($data, $model);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }

        return $data;
    }

    /**
     * Convert the Cursor to Laravel Models.
     *
     * @param [type] $model

     * @param [type] $data
     *
     * @return void
     */
    private function toModels($data, $model = null)
    {
        if (! $model) {
            $model = '\Jenssegers\Mongodb\Eloquent\Model';
        }

        if (! class_exists($model)) {
            throw new InvalidArgumentException("Model {$model} does not exist.");
        }

        if ($data instanceof Cursor) {
            // Convert MongoCursor results to a collection of models.
            $data = iterator_to_array($data, false);

            return $model::hydrate($data);
        } elseif ($data instanceof BSONDocument) {
            // Convert Mongo BSONDocument to a single object.
            $data = $data::getArrayCopy();
            $data = $data::getArrayCopy();

            return $model::newFromBuilder((array) $data);
        } elseif (is_array($data) && array_key_exists('_id', $data)) {
            // The result is a single object.
            return $model::newFromBuilder((array) $data);
        }

        return $data;
    }

    /**
     * Check specified user has permission to see these analytics.
     *
     * @param array $filterArray
     * @param User  $user
     *
     * @return bool
     */
    private function canViewAnalytic($filterArray, User $user)
    {
        $modelsToCheck = config('apanalytics.models_require_ownership');

        if (count($modelsToCheck)) {
            foreach ($modelsToCheck as $model) {
                $modelName = studly_case(str_singular($model));
                $modelId   = array_get($filterArray, strtolower($modelName).'.id');

                if ($modelId) {
                    $modelClass = $this->namespace.$modelName;
                    $model      = $modelClass::find($modelId);

                    if ($model && $user->isOwner($model)) {
                        return true;
                    }

                    return false;
                }
            }
        }

        return true;
    }
}


AshPowell / APAnalytics

GitHub Access Token became invalid

Push — master ( ef5122...a9751c )

APAnalytics::show() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like