Track::handle() - Code Metrics - Inspection of "try alternate way" - AshPowell/APAnalytics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6aec2c...7e27f4 )

by Ash

created 2019-06-24 11:23 UTC

Track::handle() C

↳ Parent: Track

Complexity

Conditions	12
Paths	156

Size

Total Lines	77
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	2	Features	1

Metric	Value
cc	12
eloc	48
c	6
b	2
f	1
nc	156
nop	0
dl	0
loc	77
rs	6.4999

How to fix Long Method Complexity

<?php

namespace AshPowell\APAnalytics\Jobs;

use AshPowell\APAnalytics\Events\AnalyticTracked;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Pagination\Paginator;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Arr;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Str;
use Log;

class Track implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;


    public $mongodb_connection;
    public $collection;
    public $items;
    public $userId;
    public $params;
    public $type;

    /**
     * Create a new event instance.
     *
     * @return void
     * @param  mixed $collection
     * @param  mixed $items
     * @param  mixed $userId
     * @param  mixed $params
     * @param  mixed $type
     */
    public function __construct($collection, $items, $userId, $params, $type = 'insert')
    {
        $this->queue = 'analytics';

        $this->mongodb_connection = config('apanalytics.db_connection', 'mongodb');
        $this->collection         = $collection;
        $this->items              = $items;
        $this->userId             = $userId;
        $this->params             = $params;
        $this->type               = $type;
    }

    public function handle()
    {
        $connection = $this->mongodb_connection;
        $collection = $this->collection;
        $items      = $this->items;
        $userId     = $this->userId;
        $params     = $this->params;
        $type       = $this->type;
        $valid      = true;

        if ($type != 'update') {
            if ($items != null) {
                $valid = ($items instanceof Collection) ? $items->count() : ($items instanceof Model) ? 1 : count($items);
            } else {
                $valid = false;
            }
        }

        if ($valid) {
            $collection = Str::plural($collection);
            $items      = $this->formatItems($items);
            $postEvent  = in_array($collection, config('apanalytics.format_collections'));
            $event      = $this->prepEventData($postEvent, $items, $userId, $params, $collection);

            try {
                if ($type == 'insert') {
                    if ($postEvent) {
                        foreach ($items as $item) {
                            $basename = strtolower(class_basename($item));

                            $data = [
                                $basename => [
                                    'id'   => $item->id ?? null,
                                    'type' => $item->type ?? null,
                                ],
                                'business' => [
                                    'id' => $item->business->id ?? null,
                                ],
                            ];

                            // Add Extra Stuff
                            $data = $this->addExtraEventData($data, $userId, $params);

                            event(new AnalyticTracked($collection, $basename, $data));

                            $event[] = $data;
                        }
                    }

                    // Basic created ie user
                    if (! $postEvent) {
                        foreach ($items as $item) {
                            $basename = strtolower(class_basename($item));
                            $data     = [
                                $basename => [
                                    'id'   => $item->id ?? null,
                                ],
                            ];
                        }

                        event(new AnalyticTracked($collection, $basename, $data));

                    }

                    return DB::connection($connection)
                        ->collection($collection)
                        ->/** @scrutinizer ignore-call */ collection($collection)
                        ->insert($event);
                }

                // Type is update
                $basename = strtolower(Str::singular($collection));

                return DB::connection($connection)
                        ->collection($collection)
                        ->where("{$basename}_id", $items)
                        ->update($params);
            } catch (\Exception $e) {
                Log::error('Error Logging Event', ['error' => $e->getMessage()]);
            }
        }
    }

    private function prepEventData($postEvent, $items, $userId, $params, $collection)
    {
        if ($postEvent) {
            return [];
        }

        if (is_array($items) && $collection != 'visits') {
            return $items;
        }

        return $this->addExtraEventData($items, $userId, $params);
    }

    private function formatItems($items)
    {
        $formattedItems = $items;

        if (is_array($formattedItems)) {
            return $formattedItems;
        }

        if ($items instanceof Paginator || $items instanceof LengthAwarePaginator) {
            $formattedItems = $items->items();
        }

        return Arr::wrap($formattedItems);
    }

    private function addExtraEventData($data, $userId, $params)
    {
        // Merge our extra parameters
        if (is_array($params) && count($params)) {
            $data = array_merge($data, $params);
        }

        // Standard stuff
        $data = array_merge($data, [
            'user_id'    => $userId ?? auth()->id() ?? null,
            'created_at' => mongoTime(),
        ]);

        return $data;
    }
}


AshPowell / APAnalytics

GitHub Access Token became invalid

Push — master ( 6aec2c...7e27f4 )

Track::handle() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like