Modules\Translation\Repositories\File\FileTranslationRepository

Complexity

Total Complexity

11

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	6
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	19	4
A	__construct()	0	5	1
B	getTranslationFilenamesFromPaths()	0	23	6

<?php namespace Modules\Translation\Repositories\File;

use Illuminate\Filesystem\Filesystem;
use Illuminate\Translation\LoaderInterface;
use Modules\Translation\Repositories\FileTranslationRepository as FileTranslationRepositoryInterface;

class FileTranslationRepository implements FileTranslationRepositoryInterface
{
    /**
     * @var Filesystem
     */
    private $finder;
    /**
     * @var LoaderInterface
     */
    private $loader;

    public function __construct(Filesystem $finder, LoaderInterface $loader)
    {
        $this->finder = $finder;
        $this->loader = $loader;
    }

    /**
     * Get all the translations for all modules on disk
     * @return array
     */
    public function all()
    {
        $files = $this->getTranslationFilenamesFromPaths($this->loader->paths());

It seems like you code against a concrete implementation and not the interface Illuminate\Translation\LoaderInterface as the method paths() does only exist in the following implementations of said interface: Modules\Translation\Services\TranslationLoader.

        $translations = [];

        foreach ($files as $locale => $files) {
            foreach ($files as $namespace => $file) {
                $trans = $this->finder->getRequire($file);
                $trans = array_dot($trans);

                foreach ($trans as $key => $value) {
                    $translations[$locale]["{$namespace}.{$key}"] = $value;
                }
            }
        }

        return $translations;
    }

    /**
     * Get all of the names of the Translations files from an array of Paths.
     * Returns [ 'translationkeyprefix' => 'filepath' ]
     * @param array $paths
     * @return array
     */
    protected function getTranslationFilenamesFromPaths(array $paths)
    {
        $files   = [];
        $locales = config('laravellocalization.supportedLocales');

        foreach ($paths as $hint => $path) {
            foreach ($locales as $locale => $language) {
                $glob = $this->finder->glob("{$path}/{$locale}/*.php");

                if ($glob) {

The expression $glob of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    foreach ($glob as $file) {
                        $category = str_replace(["$path/", ".php", "{$locale}/"], "", $file);
                        $category = str_replace("/", ".", $category);
                        $category = !is_int($hint) ? "{$hint}::{$category}" : $category;

                        $files[$locale][$category] = $file;
                    }
                }
            }
        }

        return $files;
    }
}