Modules\Translation\Http\Controllers\Admin\TranslationController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	11

Importance

Changes	9
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	index()	0	6	1
A	update()	0	6	1
A	export()	0	8	1
A	import()	0	6	1
A	requireAssets()	0	7	1

<?php namespace Modules\Translation\Http\Controllers\Admin;

use Illuminate\Http\Request;
use Modules\Core\Http\Controllers\Admin\AdminBaseController;
use Modules\Translation\Entities\TranslationTranslation;
use Modules\Translation\Exporters\TranslationsExporter;
use Modules\Translation\Http\Requests\ImportTranslationsRequest;
use Modules\Translation\Importers\TranslationsImporter;
use Modules\Translation\Repositories\TranslationRepository;
use Modules\Translation\Services\TranslationsService;
use Pingpong\Modules\Facades\Module;

class TranslationController extends AdminBaseController
{
    /**
     * @var TranslationsService
     */
    private $translationsService;
    /**
     * @var TranslationRepository
     */
    private $translation;

    public function __construct(TranslationsService $translationsService, TranslationRepository $translation)
    {
        parent::__construct();

        $this->translationsService = $translationsService;
        $this->translation = $translation;
        $this->requireAssets();
    }

    /**
     * Display a listing of the resource.
     *
     * @return Response
     */
    public function index()
    {
        $translations = $this->translationsService->getFileAndDatabaseMergedTranslations();

        return view('translation::admin.translations.index', compact('translations'));
    }

    public function update(TranslationTranslation $translationTranslation, Request $request)
    {
        $this->translation->updateTranslationToValue($translationTranslation, $request->get('oldValue'));

        return redirect()->route('admin.translation.translation.index')->withSuccess('Translation saved.');
    }

    public function export(TranslationsExporter $exporter)
    {
        return response()->make($exporter->export(), [

array('Content-Type' => 'application/csv', 'Content-Disposition' => "attachment; filename=export_{$exporter->getFileName()}.csv", 'Pragma' => 'no-cache') is of type array<string,string,{"Content-Type":"string","Pragma":"string"}>, but the function expects a integer.

            "Content-Type" => "application/csv",
            "Content-Disposition" => "attachment; filename=export_{$exporter->getFileName()}.csv",
            "Pragma" => "no-cache"
        ]);
    }

    public function import(ImportTranslationsRequest $request, TranslationsImporter $importer)
    {
        $importer->import($request->file('file'));

It seems like $request->file('file') targeting Illuminate\Http\Request::file() can also be of type array or null; however, Modules\Translation\Importers\TranslationsImporter::import() does only seem to accept object<Symfony\Component\HttpFoundation\File\UploadedFile>, maybe add an additional type check?

        return redirect()->route('admin.translation.translation.index')->withSuccess(trans('translation::translations.Translations imported'));
    }

    private function requireAssets()
    {
        $this->assetManager->addAsset('bootstrap-editable.css', Module::asset('translation:vendor/x-editable/dist/bootstrap3-editable/css/bootstrap-editable.css'));
        $this->assetManager->addAsset('bootstrap-editable.js', Module::asset('translation:vendor/x-editable/dist/bootstrap3-editable/js/bootstrap-editable.min.js'));
        $this->assetPipeline->requireJs('bootstrap-editable.js');
        $this->assetPipeline->requireCss('bootstrap-editable.css');
    }
}