AsgardCms / Tag

Display/TagWidget.php

<?php

namespace Modules\Tag\Display;

use Modules\Tag\Contracts\TaggableInterface;
use Modules\Tag\Repositories\TagRepository;

class TagWidget
{
    /**
     * @var TagRepository
     */
    private $tag;
    /**
     * @var string
     */
    private $namespace;
    /**
     * @var TaggableInterface|null
     */
    private $entity;
    /**
     * @var string|null
     */
    private $view;

    public function __construct(TagRepository $tag)
    {
        $this->tag = $tag;
    }

    /**
     * @param $arguments
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show($arguments)
    {
        $this->extractArguments($arguments);

        $view = $this->view ?: 'tag::admin.fields.tags';

        $availableTags = $this->tag->allForNamespace($this->namespace);

        $tags = $this->getTags();

        return view($view, compact('availableTags', 'tags'));
    }

    /**
     * Extract the possible arguments as class properties
     * @param array $arguments
     */
    private function extractArguments(array $arguments)
    {
        $this->namespace = array_get($arguments, 0);
        $this->entity = array_get($arguments, 1);
        $this->view = array_get($arguments, 2);
    }

    /**
     * Get the available tags, if an entity is available from that
     * @return array
     */
    private function getTags()
    {
        if ($this->entity === null) {
            return request()->old('tags', []);
        }

        return request()->old('tags', $this->entity->tags->lists('slug')->toArray());

Accessing tags on the interface Modules\Tag\Contracts\TaggableInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}