MenuServiceProvider - Code Metrics - Inspection of "wipe: add page sublevel logic" - AsgardCms/Menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Simon

created 2015-12-29 10:14 UTC

MenuServiceProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	209
Duplicated Lines	6.22 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	11
Bugs	2	Features	4

Metric	Value
wmc	26
c	11
b	2
f	4
lcom	1
cbo	10
dl	13
loc	209
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	4	1
A	boot()	0	4	1
A	provides()	0	4	1
B	registerBindings()	0	28	3
A	addItemToMenu()	9	14	2
A	addChildrenToMenu()	0	8	2
A	addSubItemToMenu()	4	9	2
A	hasChildren()	0	4	1
A	registerMenus()	0	16	4
D	getTarget()	0	38	9

How to fix Duplicated Code

<?php namespace Modules\Menu\Providers;

use Illuminate\Support\Facades\Config;
use Illuminate\Support\ServiceProvider;
use Modules\Menu\Entities\Menu;
use Modules\Menu\Entities\Menuitem;
use Modules\Menu\Repositories\Cache\CacheMenuDecorator;
use Modules\Menu\Repositories\Cache\CacheMenuItemDecorator;
use Modules\Menu\Repositories\Eloquent\EloquentMenuItemRepository;
use Modules\Menu\Repositories\Eloquent\EloquentMenuRepository;
use Modules\Page\Entities\Page;
use Pingpong\Menus\MenuBuilder as Builder;
use Pingpong\Menus\MenuFacade;
use Pingpong\Menus\MenuItem as PingpongMenuItem;

class MenuServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        $this->registerBindings();
    }

    /**
     * Register all online menus on the Pingpong/Menu package
     */
    public function boot()
    {
        $this->registerMenus();
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return array();
    }

    /**
     * Register class binding
     */
    private function registerBindings()
    {
        $this->app->bind(
            'Modules\Menu\Repositories\MenuRepository',
            function () {
                $repository = new EloquentMenuRepository(new Menu());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

                if (! config('app.cache')) {
                    return $repository;
                }

                return new CacheMenuDecorator($repository);
            }
        );

        $this->app->bind(
            'Modules\Menu\Repositories\MenuItemRepository',
            function () {
                $repository = new EloquentMenuItemRepository(new Menuitem());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

                if (! config('app.cache')) {
                    return $repository;
                }

                return new CacheMenuItemDecorator($repository);
            }
        );
    }

    /**
     * Add a menu item to the menu
     * @param Menuitem $item
     * @param Builder $menu
     */
    public function addItemToMenu(Menuitem $item, Builder $menu)
    {
        if ($this->hasChildren($item)) {
            $this->addChildrenToMenu($item->title, $item->items, $menu, ['icon' => $item->icon, 'target' => $item->target]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {

            $target = $this->getTarget($item);
            $menu->url(
                $target,
                $item->title,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ['target' => $item->target,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'icon' => $item->icon]
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            );
        }
    }

    /**
     * Add children to menu under the give name
     *
     * @param string $name
     * @param object $children
     * @param Builder|MenuItem $menu
     */
    private function addChildrenToMenu($name, $children, $menu, $attribs = [])
    {
        $menu->dropdown($name, function (PingpongMenuItem $subMenu) use ($children) {
            foreach ($children as $child) {
                $this->addSubItemToMenu($child, $subMenu);
            }
        }, 0, $attribs);
    }

    /**
     * Add children to the given menu recursively
     * @param Menuitem $child
     * @param PingpongMenuItem $sub
     */
    private function addSubItemToMenu(Menuitem $child, PingpongMenuItem $sub)
    {
        if ($this->hasChildren($child)) {
            $this->addChildrenToMenu($child->title, $child->items, $sub);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {

            $target = $this->getTarget($child);
            $sub->url($target, $child->title, 0, ['icon' => $child->icon, 'target' => $target]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * Check if the given menu item has children
     *
     * @param  object $item
     * @return bool
     */
    private function hasChildren($item)
    {
        return $item->items->count() > 0;
    }

    /**
     * Register the active menus
     */
    private function registerMenus()
    {
        if (! $this->app['asgard.isInstalled']) {
            return;
        }
        $menu = $this->app->make('Modules\Menu\Repositories\MenuRepository');
        $menuItem = $this->app->make('Modules\Menu\Repositories\MenuItemRepository');
        foreach ($menu->allOnline() as $menu) {
            $menuTree = $menuItem->getTreeForMenu($menu->id);
            MenuFacade::create($menu->name, function (Builder $menu) use ($menuTree) {

                foreach ($menuTree as $menuItem) {
                    $this->addItemToMenu($menuItem, $menu);
                }
            });
        }
    }

    /**
     * Get link target
     *
     * @param $item
     * @return mixed
     */
    private function getTarget($item)
    {
        if (empty($item->url)) {
            $linkPathArray = array();
            $parentItem = $item;

            $hasParentItem = !is_null($item->parent_id) ? true : false;

            while ($hasParentItem) {
                $parentItem = Menuitem::where('id', '=', $parentItem->parent_id)->first();

                if ($parentItem->is_root != true) {
                    if (!empty($parentItem->page_id)) {
                        $page = Page::where('id', '=', $parentItem->page_id)->first()->translate($this->app->getLocale());
                        array_push($linkPathArray, $page->slug);
                    } else {
                        $parentUri = !is_null($parentItem->uri) ? $parentItem->uri . '/' . $linkPathArray : $linkPathArray;
                        array_push($linkPathArray, $parentUri);
                    }
                }
                $hasParentItem = !is_null($parentItem->parent_id) ? true : false;
            }

            $linkPathArray = array_reverse($linkPathArray);
            if (!empty($item->page_id)) {
                $page = Page::where('id', '=', $item->page_id)->first()->translate($this->app->getLocale());

                array_push($linkPathArray, $page->slug);
            } else {
                array_push($linkPathArray, $item->uri);
            }
            $parentLinkPath = implode('/', $linkPathArray);
        } else {
            $parentLinkPath = $item->url;
        }

        return $parentLinkPath;
    }

    /**
     * Get parent item
     *
     * @param $item
     * @return mixed
     */
    /*private function getParentItem($item){
       // \Debugbar::info($item->parent_id);
        //Menuitem::where('id','=',$item->parent_id);

        return $target;
    }*/
}


1			<?php namespace Modules\Menu\Providers;
2
3			use Illuminate\Support\Facades\Config;
4			use Illuminate\Support\ServiceProvider;
5			use Modules\Menu\Entities\Menu;
6			use Modules\Menu\Entities\Menuitem;
7			use Modules\Menu\Repositories\Cache\CacheMenuDecorator;
8			use Modules\Menu\Repositories\Cache\CacheMenuItemDecorator;
9			use Modules\Menu\Repositories\Eloquent\EloquentMenuItemRepository;
10			use Modules\Menu\Repositories\Eloquent\EloquentMenuRepository;
11			use Modules\Page\Entities\Page;
12			use Pingpong\Menus\MenuBuilder as Builder;
13			use Pingpong\Menus\MenuFacade;
14			use Pingpong\Menus\MenuItem as PingpongMenuItem;
15
16			class MenuServiceProvider extends ServiceProvider
17			{
18			/**
19			* Indicates if loading of the provider is deferred.
20			*
21			* @var bool
22			*/
23			protected $defer = false;
24
25			/**
26			* Register the service provider.
27			*
28			* @return void
29			*/
30			public function register()
31			{
32			$this->registerBindings();
33			}
34
35			/**
36			* Register all online menus on the Pingpong/Menu package
37			*/
38			public function boot()
39			{
40			$this->registerMenus();

AsgardCms / Menu

Pull Request — master (#24)

MenuServiceProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like