Menuitem - Code Metrics - Inspection of "Introducing menu types" - AsgardCms/Menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.0 (#31)

by Nicolas

created 2016-08-02 13:48 UTC

Menuitem A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	7
c	4
b	1
f	1
lcom	1
cbo	3
dl	0
loc	73
rs	10

5 Methods

Rating	Name	Size	Complexity
A	menu()	4	1
A	makeChildOf()	5	1
A	isRoot()	4	1
A	setPageIdAttribute()	4	2
A	setParentIdAttribute()	4	2

<?php

namespace Modules\Menu\Entities;

use Dimsav\Translatable\Translatable;
use Illuminate\Database\Eloquent\Model;
use TypiCMS\NestableTrait;

class Menuitem extends Model
{
    use Translatable, NestableTrait;

    public $translatedAttributes = ['title', 'uri', 'url', 'status', 'locale'];
    protected $fillable = [
        'menu_id',
        'page_id',
        'parent_id',
        'position',
        'target',
        'module_name',
        'title',
        'uri',
        'url',
        'status',
        'is_root',
        'icon',
        'link_type',
        'locale',
        'class',
    ];
    protected $table = 'menu__menuitems';

    /**
     * For nested collection
     *
     * @var array
     */
    public $children = [];

    public function menu()
    {
        return $this->belongsTo(Menu::class);
    }

    /**
     * Make the current menu item child of the given root item
     * @param Menuitem $rootItem
     */
    public function makeChildOf(Menuitem $rootItem)
    {
        $this->parent_id = $rootItem->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->save();
    }

    /**
     * Check if the current menu item is the root
     * @return bool
     */
    public function isRoot()
    {
        return (bool) $this->is_root;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Check if page_id is empty and returning null instead empty string
     * @return number
     */
    public function setPageIdAttribute($value)
    {
        $this->attributes['page_id'] = ! empty($value) ? $value : null;
    }

    /**
     * Check if parent_id is empty and returning null instead empty string
     * @return number
     */
    public function setParentIdAttribute($value)
    {
        $this->attributes['parent_id'] = ! empty($value) ? $value : null;
    }
}


1			<?php
2
3			namespace Modules\Menu\Entities;
4
5			use Dimsav\Translatable\Translatable;
6			use Illuminate\Database\Eloquent\Model;
7			use TypiCMS\NestableTrait;
8
9			class Menuitem extends Model
10			{
11			use Translatable, NestableTrait;
12
13			public $translatedAttributes = ['title', 'uri', 'url', 'status', 'locale'];
14			protected $fillable = [
15			'menu_id',
16			'page_id',
17			'parent_id',
18			'position',
19			'target',
20			'module_name',
21			'title',
22			'uri',
23			'url',
24			'status',
25			'is_root',
26			'icon',
27			'link_type',
28			'locale',
29			'class',
30			];
31			protected $table = 'menu__menuitems';
32
33			/**
34			* For nested collection
35			*
36			* @var array
37			*/
38			public $children = [];
39
40			public function menu()
41			{
42			return $this->belongsTo(Menu::class);
43			}
44
45			/**
46			* Make the current menu item child of the given root item
47			* @param Menuitem $rootItem
48			*/
49			public function makeChildOf(Menuitem $rootItem)
50			{
51			$this->parent_id = $rootItem->id;
			0 ignored issues – show Documentation introduced 2015-11-20 22:22 UTC by Report Bug Copy Issue Report The property `parent_id` does not exist on `object<Modules\Menu\Entities\Menuitem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2015-11-20 22:22 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Menu\Entities\Menuitem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52			$this->save();
53			}
54
55			/**
56			* Check if the current menu item is the root
57			* @return bool
58			*/
59			public function isRoot()
60			{
61			return (bool) $this->is_root;
			0 ignored issues – show Documentation introduced 2015-11-20 22:22 UTC by Report Bug Copy Issue Report The property `is_root` does not exist on `object<Modules\Menu\Entities\Menuitem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62			}
63
64			/**
65			* Check if page_id is empty and returning null instead empty string
66			* @return number
67			*/
68			public function setPageIdAttribute($value)
69			{
70			$this->attributes['page_id'] = ! empty($value) ? $value : null;
71			}
72
73			/**
74			* Check if parent_id is empty and returning null instead empty string
75			* @return number
76			*/
77			public function setParentIdAttribute($value)
78			{
79			$this->attributes['parent_id'] = ! empty($value) ? $value : null;
80			}
81			}
82

AsgardCms / Menu

Pull Request — 2.0 (#31)

Menuitem A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like