MenuController - Code Metrics - AsgardCms/Menu - Measure and Improve Code Quality continuously with Scrutinizer

MenuController A
last analyzed 2015-12-09 19:58 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	7
c	3
b	0
f	0
lcom	2
cbo	7
dl	0
loc	74
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	10	1
A	index()	6	1
A	create()	4	1
A	store()	8	1
A	edit()	8	1
A	update()	8	1
A	destroy()	8	1

<?php namespace Modules\Menu\Http\Controllers\Admin;

use Modules\Core\Http\Controllers\Admin\AdminBaseController;
use Modules\Menu\Entities\Menu;
use Modules\Menu\Http\Requests\CreateMenuRequest;
use Modules\Menu\Http\Requests\UpdateMenuRequest;
use Modules\Menu\Repositories\MenuItemRepository;
use Modules\Menu\Repositories\MenuRepository;
use Modules\Menu\Services\MenuRenderer;

class MenuController extends AdminBaseController
{
    /**
     * @var MenuRepository
     */
    private $menu;
    /**
     * @var MenuItemRepository
     */
    private $menuItem;
    /**
     * @var MenuRenderer
     */
    private $menuRenderer;

    public function __construct(
        MenuRepository $menu,
        MenuItemRepository $menuItem,
        MenuRenderer $menuRenderer
    ) {
        parent::__construct();
        $this->menu = $menu;
        $this->menuItem = $menuItem;
        $this->menuRenderer = $menuRenderer;
    }

    public function index()
    {
        $menus = $this->menu->all();

        return view('menu::admin.menus.index', compact('menus'));
    }

    public function create()
    {
        return view('menu::admin.menus.create');
    }

    public function store(CreateMenuRequest $request)
    {
        $this->menu->create($request->all());

        flash(trans('menu::messages.menu created'));

        return redirect()->route('admin.menu.menu.index');
    }

    public function edit(Menu $menu)
    {
        $menuItems = $this->menuItem->allRootsForMenu($menu->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $menuStructure = $this->menuRenderer->renderForMenu($menu->id, $menuItems->nest());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return view('menu::admin.menus.edit', compact('menu', 'menuStructure'));
    }

    public function update(Menu $menu, UpdateMenuRequest $request)
    {
        $this->menu->update($menu, $request->all());

        flash(trans('menu::messages.menu updated'));

        return redirect()->route('admin.menu.menu.index');
    }

    public function destroy(Menu $menu)
    {
        $this->menu->destroy($menu);

        flash(trans('menu::messages.menu deleted'));

        return redirect()->route('admin.menu.menu.index');
    }
}


1			<?php namespace Modules\Menu\Http\Controllers\Admin;
2
3			use Modules\Core\Http\Controllers\Admin\AdminBaseController;
4			use Modules\Menu\Entities\Menu;
5			use Modules\Menu\Http\Requests\CreateMenuRequest;
6			use Modules\Menu\Http\Requests\UpdateMenuRequest;
7			use Modules\Menu\Repositories\MenuItemRepository;
8			use Modules\Menu\Repositories\MenuRepository;
9			use Modules\Menu\Services\MenuRenderer;
10
11			class MenuController extends AdminBaseController
12			{
13			/**
14			* @var MenuRepository
15			*/
16			private $menu;
17			/**
18			* @var MenuItemRepository
19			*/
20			private $menuItem;
21			/**
22			* @var MenuRenderer
23			*/
24			private $menuRenderer;
25
26			public function __construct(
27			MenuRepository $menu,
28			MenuItemRepository $menuItem,
29			MenuRenderer $menuRenderer
30			) {
31			parent::__construct();
32			$this->menu = $menu;
33			$this->menuItem = $menuItem;
34			$this->menuRenderer = $menuRenderer;
35			}
36
37			public function index()
38			{
39			$menus = $this->menu->all();
40
41			return view('menu::admin.menus.index', compact('menus'));
42			}
43
44			public function create()
45			{
46			return view('menu::admin.menus.create');
47			}
48
49			public function store(CreateMenuRequest $request)
50			{
51			$this->menu->create($request->all());
52
53			flash(trans('menu::messages.menu created'));
54
55			return redirect()->route('admin.menu.menu.index');
56			}
57
58			public function edit(Menu $menu)
59			{
60			$menuItems = $this->menuItem->allRootsForMenu($menu->id);
			0 ignored issues – show Documentation introduced 2015-11-20 22:22 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Menu\Entities\Menu>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61
62			$menuStructure = $this->menuRenderer->renderForMenu($menu->id, $menuItems->nest());
			0 ignored issues – show Documentation introduced 2015-11-20 22:22 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Menu\Entities\Menu>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
63
64			return view('menu::admin.menus.edit', compact('menu', 'menuStructure'));
65			}
66
67			public function update(Menu $menu, UpdateMenuRequest $request)
68			{
69			$this->menu->update($menu, $request->all());
70
71			flash(trans('menu::messages.menu updated'));
72
73			return redirect()->route('admin.menu.menu.index');
74			}
75
76			public function destroy(Menu $menu)
77			{
78			$this->menu->destroy($menu);
79
80			flash(trans('menu::messages.menu deleted'));
81
82			return redirect()->route('admin.menu.menu.index');
83			}
84			}
85

AsgardCms / Menu

MenuController A last analyzed 2015-12-09 19:58 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like

MenuController A
last analyzed 2015-12-09 19:58 UTC