Issues in MediaRelation.php - New Issues - Inspection of "Initial push of changes to 2.0 for event based med..." - AsgardCms/Media - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.0 (#49)

unknown

created 2016-07-15 06:54 UTC

Support/Traits/MediaRelation.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Modules\Media\Support\Traits;

trait MediaRelation
{
    /**
     * Make the Many To Many Morph To Relation
     * @return object
     */
    public function files()
    {
        return $this->morphToMany('Modules\Media\Entities\File', 'imageable', 'media__imageables')->withPivot('zone', 'id')->withTimestamps()->orderBy('order');
    }

    /**
     * Make the Many to Many Morph to Relation with specific zone
     * @param string $zone
     * @return object
     */
    public function filesByZone($zone)
    {
        return $this->morphToMany('Modules\Media\Entities\File', 'imageable', 'media__imageables')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->withPivot('zone', 'id')
            ->wherePivot('zone', '=', $zone)
            ->withTimestamps()
            ->orderBy('order');
    }
}


1			<?php
2
3			namespace Modules\Media\Support\Traits;
4
5			trait MediaRelation
6			{
7			/**
8			* Make the Many To Many Morph To Relation
9			* @return object
10			*/
11			public function files()
12			{
13			return $this->morphToMany('Modules\Media\Entities\File', 'imageable', 'media__imageables')->withPivot('zone', 'id')->withTimestamps()->orderBy('order');
14			}
15
16			/**
17			* Make the Many to Many Morph to Relation with specific zone
18			* @param string $zone
19			* @return object
20			*/
21			public function filesByZone($zone)
22			{
23			return $this->morphToMany('Modules\Media\Entities\File', 'imageable', 'media__imageables')
			0 ignored issues – show Bug introduced 2016-07-15 01:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `morphToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			->withPivot('zone', 'id')
25			->wherePivot('zone', '=', $zone)
26			->withTimestamps()
27			->orderBy('order');
28			}
29			}
30

AsgardCms / Media

Pull Request — 2.0 (#49)

Support/Traits/MediaRelation.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like