Issues in File.php - New Issues - Inspection of "Initial push of changes to 2.0 for event based med..." - AsgardCms/Media - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.0 (#49)

unknown

created 2016-07-15 22:12 UTC

Entities/File.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Modules\Media\Entities;

use Dimsav\Translatable\Translatable;
use Illuminate\Database\Eloquent\Model;
use Modules\Media\Helpers\FileHelper;
use Modules\Media\Image\Facade\Imagy;
use Modules\Media\ValueObjects\MediaPath;
use Modules\Tag\Contracts\TaggableInterface;
use Modules\Tag\Traits\NamespacedEntity;
use Modules\Tag\Traits\TaggableTrait;

/**
 * Class File
 * @package Modules\Media\Entities
 * @property \Modules\Media\ValueObjects\MediaPath path
 */
class File extends Model implements TaggableInterface
{
    use Translatable, NamespacedEntity, TaggableTrait;
    /**
     * All the different images types where thumbnails should be created
     * @var array
     */
    private $imageExtensions = ['jpg', 'png', 'jpeg', 'gif'];

    protected $table = 'media__files';
    public $translatedAttributes = ['description', 'alt_attribute', 'keywords'];
    protected $fillable = [
        'description',
        'alt_attribute',
        'keywords',
        'filename',
        'path',
        'extension',
        'mimetype',
        'width',
        'height',
        'filesize',
        'folder_id',
    ];
    protected $appends = ['path_string', 'media_type'];
    protected static $entityNamespace = 'asgardcms/media';

    public function getPathAttribute($value)
    {
        return new MediaPath($value);
    }

    public function getPathStringAttribute()
    {
        return (string) $this->path;
    }

    public function getMediaTypeAttribute()
    {
        return FileHelper::getTypeByMimetype($this->mimetype);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function isImage()
    {
        return in_array(pathinfo($this->path, PATHINFO_EXTENSION), $this->imageExtensions);
    }

    public function getThumbnail($type)
    {
        if ($this->isImage() && $this->getKey()) {
            return Imagy::getThumbnail($this->path, $type);
        }

        return false;
    }
}


1			<?php
2
3			namespace Modules\Media\Entities;
4
5			use Dimsav\Translatable\Translatable;
6			use Illuminate\Database\Eloquent\Model;
7			use Modules\Media\Helpers\FileHelper;
8			use Modules\Media\Image\Facade\Imagy;
9			use Modules\Media\ValueObjects\MediaPath;
10			use Modules\Tag\Contracts\TaggableInterface;
11			use Modules\Tag\Traits\NamespacedEntity;
12			use Modules\Tag\Traits\TaggableTrait;
13
14			/**
15			* Class File
16			* @package Modules\Media\Entities
17			* @property \Modules\Media\ValueObjects\MediaPath path
18			*/
19			class File extends Model implements TaggableInterface
20			{
21			use Translatable, NamespacedEntity, TaggableTrait;
22			/**
23			* All the different images types where thumbnails should be created
24			* @var array
25			*/
26			private $imageExtensions = ['jpg', 'png', 'jpeg', 'gif'];
27
28			protected $table = 'media__files';
29			public $translatedAttributes = ['description', 'alt_attribute', 'keywords'];
30			protected $fillable = [
31			'description',
32			'alt_attribute',
33			'keywords',
34			'filename',
35			'path',
36			'extension',
37			'mimetype',
38			'width',
39			'height',
40			'filesize',
41			'folder_id',
42			];
43			protected $appends = ['path_string', 'media_type'];
44			protected static $entityNamespace = 'asgardcms/media';
45
46			public function getPathAttribute($value)
47			{
48			return new MediaPath($value);
49			}
50
51			public function getPathStringAttribute()
52			{
53			return (string) $this->path;
54			}
55
56			public function getMediaTypeAttribute()
57			{
58			return FileHelper::getTypeByMimetype($this->mimetype);
			0 ignored issues – show Documentation introduced 2016-07-15 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mimetype` does not exist on `object<Modules\Media\Entities\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
59			}
60
61			public function isImage()
62			{
63			return in_array(pathinfo($this->path, PATHINFO_EXTENSION), $this->imageExtensions);
64			}
65
66			public function getThumbnail($type)
67			{
68			if ($this->isImage() && $this->getKey()) {
69			return Imagy::getThumbnail($this->path, $type);
70			}
71
72			return false;
73			}
74			}
75

AsgardCms / Media

Pull Request — 2.0 (#49)

Entities/File.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like