Modules\Media\Tests\ImagyTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	93
Duplicated Lines	16.13 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	3
Bugs	1	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	12	1
A	tearDown()	0	5	1
A	it_should_not_create_thumbs_for_pdf_files()	0	6	1
A	it_should_return_thumbnail_path()	8	8	1
A	it_should_return_same_path_for_non_images()	7	7	1
A	it_should_detect_an_image()	0	10	1
A	it_should_create_a_file()	0	10	2

<?php namespace Modules\Media\Tests;

use Illuminate\Support\Facades\App;
use Modules\Media\Image\Imagy;
use Modules\Media\Image\Intervention\InterventionFactory;
use Modules\Media\Image\ThumbnailsManager;

class ImagyTest extends MediaTestCase
{
    /**
     * @var Imagy
     */
    protected $imagy;
    /**
     * @var \Illuminate\Filesystem\Filesystem
     */
    protected $finder;
    /**
     * @var \Illuminate\Contracts\Config\Repository
     */
    protected $config;
    /**
     * @var string
     */
    protected $mediaPath;
    private $testbenchPublicPath;

    /**
     *
     */
    public function setUp()
    {
        parent::setUp();
        $this->config = App::make('Illuminate\Contracts\Config\Repository');
        $module = App::make('modules');
        $this->finder = App::make('Illuminate\Filesystem\Filesystem');
        $this->imagy = new Imagy(new InterventionFactory(), new ThumbnailsManager($this->config, $module), $this->config);

The call to ThumbnailsManager::__construct() has too many arguments starting with $module.

        $this->testbenchPublicPath = __DIR__ . '/../vendor/orchestra/testbench/fixture/public/';
        $this->mediaPath = __DIR__ . '/Fixtures/';
        $this->finder->copy("{$this->mediaPath}google-map.png", "{$this->testbenchPublicPath}google-map.png");
    }

    public function tearDown()
    {
        $this->finder->delete("{$this->testbenchPublicPath}google-map.png");
        $this->finder->delete("{$this->testbenchPublicPath}google-map_smallThumb.png");
    }

    /** @test */
    public function it_should_create_a_file()
    {
        if ($this->finder->isFile("{$this->mediaPath}google-map_smallThumb.png")) {
            $this->finder->delete("{$this->mediaPath}google-map_smallThumb.png");
        }

        $this->imagy->get("/google-map.png", 'smallThumb', true);

        $this->assertTrue($this->finder->isFile("{$this->testbenchPublicPath}google-map_smallThumb.png"));
    }

    /** @test */
    public function it_should_not_create_thumbs_for_pdf_files()
    {
        $this->imagy->get("{$this->mediaPath}test-pdf.pdf", 'smallThumb', true);

        $this->assertFalse($this->finder->isFile(public_path() . "{$this->mediaPath}test-pdf_smallThumb.png"));
    }

    /** @test */
    public function it_should_return_thumbnail_path()

This method seems to be duplicated in your project.

    {
        $path = $this->mediaPath;
        $path .= $this->imagy->getThumbnail("{$this->mediaPath}google-map.png", 'smallThumb');
        $expected = "{$this->mediaPath}google-map_smallThumb.png";

        $this->assertEquals($expected, $path);
    }

    /** @test */
    public function it_should_return_same_path_for_non_images()

This method seems to be duplicated in your project.

    {
        $path = $this->imagy->getThumbnail("{$this->mediaPath}test-pdf.pdf", 'smallThumb');
        $expected = "{$this->mediaPath}test-pdf.pdf";

        $this->assertEquals($expected, $path);
    }

    /** @test */
    public function it_should_detect_an_image()
    {
        $jpg = $this->imagy->isImage('image.jpg');
        $png = $this->imagy->isImage('image.png');
        $pdf = $this->imagy->isImage('pdf.pdf');

        $this->assertTrue($jpg);
        $this->assertTrue($png);
        $this->assertFalse($pdf);
    }
}