Modules\Media\Services\FileService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	store()	0	17	2
A	createThumbnails()	0	7	1

<?php namespace Modules\Media\Services;

use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Queue\Queue;
use Illuminate\Queue\Jobs\Job;
use Modules\Media\Repositories\FileRepository;
use Symfony\Component\HttpFoundation\File\UploadedFile;

class FileService
{
    /**
     * @var FileRepository
     */
    private $file;
    /**
     * @var Repository
     */
    private $config;
    /**
     * @var Queue
     */
    private $queue;

    public function __construct(
        FileRepository $file,
        Repository $config,
        Queue $queue)
    {
        $this->file = $file;
        $this->config = $config;
        $this->queue = $queue;
    }

    /**
     * @param  UploadedFile $file
     * @return mixed
     */
    public function store(UploadedFile $file)
    {
        // Save the file info to db
        try {
            $savedFile = $this->file->createFromFile($file);
        } catch (\InvalidArgumentException $e) {
            return $e->getMessage();
        }

        // Move the uploaded file to files path
        $file->move(public_path() . $this->config->get('asgard.media.config.files-path'), $savedFile->filename);
        @chmod(public_path() . $this->config->get('asgard.media.config.files-path') . $savedFile->filename, 0666);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $this->createThumbnails($savedFile);

        return $savedFile;
    }

    /**
     * Create the necessary thumbnails for the given file
     * @param $savedFile
     */
    private function createThumbnails($savedFile)
    {
        $this->queue->push(function (Job $job) use ($savedFile) {

function (\Illuminate\Queue\Jobs\Job $job) use($savedFile) { app('imagy')->createAll($savedFile->path); $job->delete(); } is of type object<Closure>, but the function expects a string.

            app('imagy')->createAll($savedFile->path);
            $job->delete();
        });
    }
}