Modules\Core\Composers\ApplicationVersionViewComposer

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	12.9 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	compose()	0	7	2
A	onBackend()	8	8	2
A	getAppVersion()	0	6	2
A	getComposerFile()	0	8	1

<?php namespace Modules\Core\Composers;

use Illuminate\Contracts\Cache\Repository;
use Illuminate\Contracts\Filesystem\Filesystem;
use Illuminate\Contracts\View\View;
use Illuminate\Http\Request;

class ApplicationVersionViewComposer
{
    /**
     * @var Filesystem
     */
    private $filesystem;
    /**
     * @var Repository
     */
    private $cache;
    /**
     * @var Request
     */
    private $request;

    public function __construct(Filesystem $filesystem, Repository $cache, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->filesystem = $filesystem;
        $this->cache = $cache;
        $this->request = $request;
    }

    public function compose(View $view)
    {
        if ($this->onBackend() === false) {
            return;
        }
        $view->with('version', $this->getAppVersion());
    }

    private function onBackend()

This method seems to be duplicated in your project.

    {
        $url = $this->request->url();
        if (str_contains($url, config('asgard.core.core.admin-prefix'))) {
            return true;
        }
        return false;
    }

    /**
     * @return string
     */
    private function getAppVersion()
    {
        $composerFile = $this->getComposerFile();

        return isset($composerFile->version) ? $composerFile->version : '1.0';
    }

    /**
     * Get the decoded contents from the main composer.json file
     * @return object
     */
    private function getComposerFile()
    {
        $composerFile = $this->cache->remember('app.version', 1440, function () {
            return $this->filesystem->get('composer.json');
        });

        return json_decode($composerFile);
    }
}