CanPublishConfiguration::publishConfig() - Code Metrics - Inspection of "Creating helper trait to publish a module config f..." - AsgardCms/Core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( f84433...6a2cd6 )

by Nicolas

created 2016-06-16 19:09 UTC

CanPublishConfiguration::publishConfig() A

↳ Parent: CanPublishConfiguration

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	7
rs	9.4285

<?php namespace Modules\Core\Traits;

trait CanPublishConfiguration
{
    /**
     * Publish the given configuration file name (without extension) and the given module
     * @param string $module
     * @param string $fileName
     */
    public function publishConfig($module, $fileName)
    {
        $this->mergeConfigFrom($this->getModuleConfigFilePath($module, $fileName), "asgard.$module.$fileName");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getModuleConfigFilePath($module, $fileName) => config_path("asgardcms/$module/$fileName.php"),
        ], 'config');
    }

    /**
     * Get path of the give file name in the given module
     * @param string $module
     * @param string $file
     * @return string
     */
    private function getModuleConfigFilePath($module, $file)
    {
        return $this->getModulePath($module) . "/Config/$file.php";
    }

    /**
     * @param $module
     * @return string
     */
    private function getModulePath($module)
    {
        return base_path('Modules'. DIRECTORY_SEPARATOR . ucfirst($module));
    }
}


1			<?php namespace Modules\Core\Traits;
2
3			trait CanPublishConfiguration
4			{
5			/**
6			* Publish the given configuration file name (without extension) and the given module
7			* @param string $module
8			* @param string $fileName
9			*/
10			public function publishConfig($module, $fileName)
11			{
12			$this->mergeConfigFrom($this->getModuleConfigFilePath($module, $fileName), "asgard.$module.$fileName");
			0 ignored issues – show Bug introduced 2016-06-16 19:12 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			$this->publishes([
			0 ignored issues – show Bug introduced 2016-06-16 19:12 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			$this->getModuleConfigFilePath($module, $fileName) => config_path("asgardcms/$module/$fileName.php"),
15			], 'config');
16			}
17
18			/**
19			* Get path of the give file name in the given module
20			* @param string $module
21			* @param string $file
22			* @return string
23			*/
24			private function getModuleConfigFilePath($module, $file)
25			{
26			return $this->getModulePath($module) . "/Config/$file.php";
27			}
28
29			/**
30			* @param $module
31			* @return string
32			*/
33			private function getModulePath($module)
34			{
35			return base_path('Modules'. DIRECTORY_SEPARATOR . ucfirst($module));
36			}
37			}
38

AsgardCms / Core

Push — 2.0 ( f84433...6a2cd6 )

CanPublishConfiguration::publishConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like