CanPublishConfiguration::publishConfig() - Code Metrics - Inspection of "Feature/routes override" - AsgardCms/Core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#96)

unknown

created 2016-09-01 16:33 UTC

CanPublishConfiguration::publishConfig() A

↳ Parent: CanPublishConfiguration

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	2
eloc	7
c	3
b	0
f	0
nc	2
nop	2
dl	0
loc	10
rs	9.4285

<?php

namespace Modules\Core\Traits;

trait CanPublishConfiguration
{
    /**
     * Publish the given configuration file name (without extension) and the given module
     * @param string $module
     * @param string $fileName
     */
    public function publishConfig($module, $fileName)
    {
        if (app()->environment() === 'testing') {
            return;
        }
        $this->mergeConfigFrom($this->getModuleConfigFilePath($module, $fileName), strtolower("asgard.$module.$fileName"));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getModuleConfigFilePath($module, $fileName) => config_path(strtolower("asgard.$module.$fileName")),
        ], 'config');
    }

    /**
     * Get path of the give file name in the given module
     * @param string $module
     * @param string $file
     * @return string
     */
    private function getModuleConfigFilePath($module, $file)
    {
        return $this->getModulePath($module) . "/Config/$file.php";
    }

    /**
     * @param $module
     * @return string
     */
    private function getModulePath($module)
    {
        return base_path('Modules' . DIRECTORY_SEPARATOR . ucfirst($module));
    }
}


1			<?php
2
3			namespace Modules\Core\Traits;
4
5			trait CanPublishConfiguration
6			{
7			/**
8			* Publish the given configuration file name (without extension) and the given module
9			* @param string $module
10			* @param string $fileName
11			*/
12			public function publishConfig($module, $fileName)
13			{
14			if (app()->environment() === 'testing') {
15			return;
16			}
17			$this->mergeConfigFrom($this->getModuleConfigFilePath($module, $fileName), strtolower("asgard.$module.$fileName"));
			0 ignored issues – show Bug introduced 2016-06-16 19:12 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			$this->publishes([
			0 ignored issues – show Bug introduced 2016-06-16 19:12 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			$this->getModuleConfigFilePath($module, $fileName) => config_path(strtolower("asgard.$module.$fileName")),
20			], 'config');
21			}
22
23			/**
24			* Get path of the give file name in the given module
25			* @param string $module
26			* @param string $file
27			* @return string
28			*/
29			private function getModuleConfigFilePath($module, $file)
30			{
31			return $this->getModulePath($module) . "/Config/$file.php";
32			}
33
34			/**
35			* @param $module
36			* @return string
37			*/
38			private function getModulePath($module)
39			{
40			return base_path('Modules' . DIRECTORY_SEPARATOR . ucfirst($module));
41			}
42			}
43

AsgardCms / Core

Pull Request — master (#96)

CanPublishConfiguration::publishConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like