Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Modules\Core\Providers; |
||
7 | abstract class RoutingServiceProvider extends ServiceProvider |
||
8 | { |
||
9 | /** |
||
10 | * The root namespace to assume when generating URLs to actions. |
||
11 | * |
||
12 | * @var string |
||
13 | */ |
||
14 | protected $namespace = ''; |
||
15 | |||
16 | /** |
||
17 | * Define your route model bindings, pattern filters, etc. |
||
18 | * |
||
19 | * @param \Illuminate\Routing\Router $router |
||
20 | * @return void |
||
21 | */ |
||
22 | public function boot(Router $router) |
||
26 | |||
27 | /** |
||
28 | * @return string |
||
29 | */ |
||
30 | abstract protected function getFrontendRoute(); |
||
31 | |||
32 | /** |
||
33 | * @return string |
||
34 | */ |
||
35 | abstract protected function getBackendRoute(); |
||
36 | |||
37 | /** |
||
38 | * @return string |
||
39 | */ |
||
40 | abstract protected function getApiRoute(); |
||
41 | |||
42 | /** |
||
43 | * Define the routes for the application. |
||
44 | * |
||
45 | * @param \Illuminate\Routing\Router $router |
||
46 | * @return void |
||
47 | */ |
||
48 | public function map(Router $router) |
||
49 | { |
||
50 | $router->group(['namespace' => $this->namespace], function (Router $router) { |
||
51 | $this->loadApiRoutes($router); |
||
52 | }); |
||
53 | |||
54 | $router->group(['namespace' => $this->namespace, 'prefix' => LaravelLocalization::setLocale(), 'middleware' => ['localizationRedirect'] ], function (Router $router) { |
||
55 | $this->loadBackendRoutes($router); |
||
56 | $this->loadFrontendRoutes($router); |
||
57 | }); |
||
58 | } |
||
59 | |||
60 | /** |
||
61 | * @param Router $router |
||
62 | */ |
||
63 | private function loadFrontendRoutes(Router $router) |
||
73 | |||
74 | /** |
||
75 | * @param Router $router |
||
76 | */ |
||
77 | View Code Duplication | private function loadBackendRoutes(Router $router) |
|
87 | |||
88 | /** |
||
89 | * @param Router $router |
||
90 | */ |
||
91 | View Code Duplication | private function loadApiRoutes(Router $router) |
|
101 | } |
||
102 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.