Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Modules\Blog\Http\Requests; |
||
5 | class UpdatePostRequest extends BaseFormRequest |
||
6 | { |
||
7 | public function rules() |
||
8 | { |
||
9 | return []; |
||
10 | } |
||
11 | |||
12 | public function translationRules() |
||
13 | { |
||
14 | $id = $this->route()->getParameter('post')->id; |
||
|
|||
15 | |||
16 | return [ |
||
17 | // "title" => "required", |
||
18 | // "slug" => "required|unique:blog__post_translations,slug,$id,post_id,locale,$this->localeKey", |
||
19 | ]; |
||
20 | } |
||
21 | |||
22 | public function authorize() |
||
26 | |||
27 | View Code Duplication | public function translationMessages() |
|
35 | |||
36 | View Code Duplication | public function all() |
|
45 | } |
||
46 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.