UpdatePostRequest::all() - Code Metrics - Inspection of "Posts belong to language, disabled validation" - AsgardCms/Blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#47)

unknown

created 2016-11-22 00:06 UTC

UpdatePostRequest::all() A

↳ Parent: UpdatePostRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php namespace Modules\Blog\Http\Requests;

use Modules\Core\Internationalisation\BaseFormRequest;

class UpdatePostRequest extends BaseFormRequest
{
    public function rules()
    {
        return [];
    }

    public function translationRules()
    {
        $id = $this->route()->getParameter('post')->id;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return [
//            "title" => "required",
//            "slug" => "required|unique:blog__post_translations,slug,$id,post_id,locale,$this->localeKey",
        ];
    }

    public function authorize()
    {
        return true;
    }

    public function translationMessages()

    {
        return [
            'title.required' => trans('blog::messages.title is required'),
            'slug.required' => trans('blog::messages.slug is required'),
            'slug.unique' => trans('blog::messages.slug is unique'),
        ];
    }

    public function all()

    {
        $all = parent::all();

        $all[$all['locale']] = $all['default'];
        unset($all['default']);

        return $all;
    }
}


1		<?php namespace Modules\Blog\Http\Requests;
2
3		use Modules\Core\Internationalisation\BaseFormRequest;
4
5		class UpdatePostRequest extends BaseFormRequest
6		{
7		public function rules()
8		{
9		return [];
10		}
11
12		public function translationRules()
13		{
14		$id = $this->route()->getParameter('post')->id;
		0 ignored issues – show Unused Code introduced 2016-11-22 00:09 UTC by Report Bug Copy Issue Report `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
15
16		return [
17		// "title" => "required",
18		// "slug" => "required\|unique:blog__post_translations,slug,$id,post_id,locale,$this->localeKey",
19		];
20		}
21
22		public function authorize()
23		{
24		return true;
25		}
26
27	View Code Duplication	public function translationMessages()
		0 ignored issues – show Duplication introduced 2015-11-21 11:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		return [
30		'title.required' => trans('blog::messages.title is required'),
31		'slug.required' => trans('blog::messages.slug is required'),
32		'slug.unique' => trans('blog::messages.slug is unique'),
33		];
34		}
35
36	View Code Duplication	public function all()
		0 ignored issues – show Duplication introduced 2016-11-22 00:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$all = parent::all();
39
40		$all[$all['locale']] = $all['default'];
41		unset($all['default']);
42
43		return $all;
44		}
45		}
46

AsgardCms / Blog

Pull Request — master (#47)

UpdatePostRequest::all() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like