AsaTirsen / weather

src/Weather/CurlService.php

<?php

namespace Asti\Weather;


class CurlService
{

    public function getDataThroughCurl(string $url)
    {
//        $url = "http://localhost:8080/dbwebb/ramverk1/me/redovisa/htdocs/api/ipcheck/check?ipCheck=$ip";


        //  Initiate curl handler
        $ch = curl_init();

        // Will return the response, if false it print the response
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

        // Set the url
        curl_setopt($ch, CURLOPT_URL, $url);

        // Execute
        $data = curl_exec($ch);

        // Closing
        curl_close($ch);

        return json_decode($data, true);

It seems like $data can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

    }

    public function getMultipleCurls ($fetchURL, $dateArray, $fetchURLPart2)
    {
        $mh = curl_multi_init();
        $multiCurl = [];
        $curlArray = [];

        foreach($dateArray as $i => $date) {
            $URL = $fetchURL . $date . $fetchURLPart2;
            $multiCurl[$i] = curl_init();
            curl_setopt($multiCurl[$i], CURLOPT_URL, $URL);
            curl_setopt($multiCurl[$i], CURLOPT_HEADER, 0);
            curl_setopt($multiCurl[$i], CURLOPT_RETURNTRANSFER, 1);
            curl_multi_add_handle($mh, $multiCurl[$i]);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_add_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

        }
        $index = null;
        do {
            curl_multi_exec($mh, $index);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_exec() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

        } while ($index > 0);

        foreach ($multiCurl as $k => $ch) {
            $result[$k] = curl_multi_getcontent($ch);
            array_push($curlArray, json_decode($result[$k], true));

The variable $result seems to be defined later in this foreach loop on line 52. Are you sure it is defined here?

            curl_multi_remove_handle($mh, $ch);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_remove_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

        }
        curl_multi_close($mh);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_close() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

        return $curlArray;
    }
}