LocationService::curlIpApi() - Code Metrics - Inspection of "amended chmod for cache to scrutinizer.yml 7" - AsaTirsen/weather - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( c42d70...1b364a )

by Åsa

created 2021-05-18 09:24 UTC

LocationService::curlIpApi() A

↳ Parent: LocationService

Complexity

Conditions	5
Paths	6

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	5.0406

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
eloc	20
c	1
b	0
f	1
nc	6
nop	1
dl	0
loc	28
ccs	15
cts	17
cp	0.8824
crap	5.0406
rs	9.2888

<?php

namespace Asti\Weather;

class LocationService
{


    /*
     *
     * curls api, get_file_contents
     * sends response to model
     *
     */

    private $key = null;
    private $url = null;

    public function setKey($key)
    {
        $this->key = $key;
    }

    public function setUrl($url): void
    {
        $this->url = $url;
    }

    public function getKey(): string
    {
        return $this->key;
    }

    public function getUrl(): string
    {
        return $this->url;
    }




    public function curlIpApi($ipAdr): array
    {
        $curl = new CurlService();
        if ($ipAdr!= "") {
            $res = $curl->getDataThroughCurl($this->getUrl() . $ipAdr . "?access_key=" . $this->getKey());

            if ($res["type"] == null) {
                $json = [
                    "Message" => "IP-adressen är fel. Försök igen!"
                ];
                return $json;
            }
            $json = [
                "Type" => $res["type"],
                "Valid" => $res["type"] ? "ipv4" || "ipv6" : "not valid",
                "UserInput" => $res["ip"],
                "Latitude" => $res["latitude"],
                "Longitude" => $res["longitude"],
                "City" => $res["city"],
                "Country" => $res["country_name"],
            ];
            return [$json];
        }
        else {
            $json = [
                "Message" => "IP-adressen är tom. Försök igen"
            ];
            return $json;
        }
    }
}


1		<?php
2
3		namespace Asti\Weather;
4
5		class LocationService
6		{
7
8
9		/*
10		*
11		* curls api, get_file_contents
12		* sends response to model
13		*
14		*/
15
16		private $key = null;
17		private $url = null;
18
19	2	public function setKey($key)
20		{
21	2	$this->key = $key;
22	2	}
23
24	2	public function setUrl($url): void
25		{
26	2	$this->url = $url;
27	2	}
28
29	2	public function getKey(): string
30		{
31	2	return $this->key;
32		}
33
34	2	public function getUrl(): string
35		{
36	2	return $this->url;
37		}
38
39
40
41
42	2	public function curlIpApi($ipAdr): array
43		{
44	2	$curl = new CurlService();
45	2	if ($ipAdr!= "") {
46	2	$res = $curl->getDataThroughCurl($this->getUrl() . $ipAdr . "?access_key=" . $this->getKey());
47
48	2	if ($res["type"] == null) {
49		$json = [
50	1	"Message" => "IP-adressen är fel. Försök igen!"
51		];
52	1	return $json;
53		}
54		$json = [
55	2	"Type" => $res["type"],
56	2	"Valid" => $res["type"] ? "ipv4" \|\| "ipv6" : "not valid",
57	2	"UserInput" => $res["ip"],
58	2	"Latitude" => $res["latitude"],
59	2	"Longitude" => $res["longitude"],
60	2	"City" => $res["city"],
61	2	"Country" => $res["country_name"],
62		];
63	2	return [$json];
64		}
65		else {
66		$json = [
67		"Message" => "IP-adressen är tom. Försök igen"
68		];
69		return $json;
70		}
71		}
72		}
73

AsaTirsen / weather

Push — main ( c42d70...1b364a )

LocationService::curlIpApi() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like