WeatherApiController::weatherActionPost() - Code Metrics - Inspection of "amended chmod for cache to scrutinizer.yml 7" - AsaTirsen/weather - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( c42d70...1b364a )

by Åsa

created 2021-05-18 09:24 UTC

WeatherApiController::weatherActionPost() A

↳ Parent: WeatherApiController

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4.0092

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	11
c	2
b	0
f	0
nc	4
nop	0
dl	0
loc	15
ccs	11
cts	12
cp	0.9167
crap	4.0092
rs	9.9

<?php

namespace Asti\Api;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Asti\Weather\WeatherService;

/**
 * A test controller to show off using a model.
 */
class WeatherApiController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * function checks if input is an ip address and if so, if it's PIv4 or Ipv6
     */
//    public function indexAction()
//    {

//    }

    public function weatherActionPost() : array
    {
        $request = $this->di->get("request");
        $geoipService = $this->di->get("location");
        $weatherService = $this->di->get("weather");
        $ipAdress = $request->getPost("ipCheck");
        $res = $geoipService->curlIpApi($ipAdress);

        if (isset($res["Message"])) {
            return [$res];
        }
        if (in_array("Prognos", $request->getPost())) {
            return [$weatherService->curlWeatherApi($res[0]["Longitude"], $res[0]["Latitude"])];
        } elseif ((in_array("Äldre data", $request->getPost()))) {
            return [$weatherService->curlOldWeatherApi($res[0]["Longitude"], $res[0]["Latitude"])];
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1		<?php
2
3		namespace Asti\Api;
4
5		use Anax\Commons\ContainerInjectableInterface;
6		use Anax\Commons\ContainerInjectableTrait;
7		use Asti\Weather\WeatherService;
8
9		/**
10		* A test controller to show off using a model.
11		*/
12		class WeatherApiController implements ContainerInjectableInterface
13		{
14		use ContainerInjectableTrait;
15
16		/**
17		* function checks if input is an ip address and if so, if it's PIv4 or Ipv6
18		*/
19		// public function indexAction()
20		// {
21
22		// }
23
24	1	public function weatherActionPost() : array
25		{
26	1	$request = $this->di->get("request");
27	1	$geoipService = $this->di->get("location");
28	1	$weatherService = $this->di->get("weather");
29	1	$ipAdress = $request->getPost("ipCheck");
30	1	$res = $geoipService->curlIpApi($ipAdress);
31
32	1	if (isset($res["Message"])) {
33		return [$res];
34		}
35	1	if (in_array("Prognos", $request->getPost())) {
36	1	return [$weatherService->curlWeatherApi($res[0]["Longitude"], $res[0]["Latitude"])];
37	1	} elseif ((in_array("Äldre data", $request->getPost()))) {
38	1	return [$weatherService->curlOldWeatherApi($res[0]["Longitude"], $res[0]["Latitude"])];
39		}
		0 ignored issues – show Bug Best Practice introduced 2021-05-17 12:27 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `array`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
40		}
41		}
42

AsaTirsen / weather

Push — main ( c42d70...1b364a )

WeatherApiController::weatherActionPost() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like