Issues in UserController.php (main) - Issues in main - AsaTirsen/forum - Measure and Improve Code Quality continuously with Scrutinizer

Issues (47)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/User/UserController.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Forum\User;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Forum\Answer\Answer;
use Forum\Comment\Comment;
use Forum\Question\Question;
use Forum\User\HTMLForm\UserLoginForm;
use Forum\User\HTMLForm\CreateUserForm;
use Forum\User\HTMLForm\UpdateForm;


// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 */
class UserController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;



    /**
     * @var $data description
     */
    //private $data;



    // /**
    //  * The initialize method is optional and will always be called before the
    //  * target method/action. This is a convienient method where you could
    //  * setup internal properties that are commonly used by several methods.
    //  *
    //  * @return void
    //  */
    // public function initialize() : void
    // {
    //     ;
    // }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return object as a response object
     */
    public function indexActionGet() : object
    {
        $page = $this->di->get("page");
        $user = new User();
        $user->setDb($this->di->get("dbqb"));
        $page->add("user/login");

        return $page->render([
            "title" => "A index page",
        ]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return object as a response object
     */
    public function loginAction() : object

    {
        $page = $this->di->get("page");
        $form = new UserLoginForm($this->di);
        $form->check();
        $data = [
            "form" => $form->getHTML(),
            "title" => "A login page",
            ];
        $page->add("user/login", $data);
        return $page->render($data);
    }

    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return object as a response object
     */
    public function createAction() : object

    {
        $page = $this->di->get("page");
        $form = new CreateUserForm($this->di);
        $form->check();

        $data = [
            "form" => $form->getHTML(),
            "title" => "Create user"
        ];

        $page->add("user/create", $data);
        return $page->render($data);
    }

    public function viewAction($userId): object
    {
        $page = $this->di->get("page");
        $user = new User();
        $question = new Question();
        $answer = new Answer;
        $comment = new Comment;
        $user->setDb($this->di->get("dbqb"));
        $answer->setDb($this->di->get("dbqb"));
        $comment->setDb($this->di->get("dbqb"));
        $question->setDb($this->di->get("dbqb"));
        $user->findById($userId);
        $questions = $question->findAllWhere("user_id = ?", $userId);
        $comments = $comment->findAllWhere("user_id = ?", $userId);
        $answers = $answer->findAllWhere("user_id = ?", $userId);
        $data = [
            "title" => $user->acronym,
            "user" => $user,
            "questions" => $questions,
            "comments" => $comments,
            "answers" => $answers,
        ];

        $page->add("user/view", $data);
        return $page->render($data);
    }


    /**
     * Handler with form to update an item.
     *
     * @param int $id the id to update.
     *
     * @return object as a response object
     */
    public function updateAction(int $id) : object

    {
        $page = $this->di->get("page");
        $form = new UpdateForm($this->di, $id);
        $form->check();

        $page->add("user/update", [
            "form" => $form->getHTML(),
        ]);

        return $page->render([
            "title" => "Update an item",
        ]);
    }
}


1		<?php
2
3		namespace Forum\User;
4
5		use Anax\Commons\ContainerInjectableInterface;
6		use Anax\Commons\ContainerInjectableTrait;
7		use Forum\Answer\Answer;
8		use Forum\Comment\Comment;
9		use Forum\Question\Question;
10		use Forum\User\HTMLForm\UserLoginForm;
11		use Forum\User\HTMLForm\CreateUserForm;
12		use Forum\User\HTMLForm\UpdateForm;
13
14
15		// use Anax\Route\Exception\ForbiddenException;
16		// use Anax\Route\Exception\NotFoundException;
17		// use Anax\Route\Exception\InternalErrorException;
18
19		/**
20		* A sample controller to show how a controller class can be implemented.
21		*/
22		class UserController implements ContainerInjectableInterface
23		{
24		use ContainerInjectableTrait;
25
26
27
28		/**
29		* @var $data description
30		*/
31		//private $data;
32
33
34
35		// /**
36		// * The initialize method is optional and will always be called before the
37		// * target method/action. This is a convienient method where you could
38		// * setup internal properties that are commonly used by several methods.
39		// *
40		// * @return void
41		// */
42		// public function initialize() : void
43		// {
44		// ;
45		// }
46
47
48
49		/**
50		* Description.
51		*
52		* @param datatype $variable Description
		0 ignored issues – show Bug introduced 2021-05-30 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
53		*
54		* @throws Exception
55		*
56		* @return object as a response object
57		*/
58		public function indexActionGet() : object
59		{
60		$page = $this->di->get("page");
61		$user = new User();
62		$user->setDb($this->di->get("dbqb"));
63		$page->add("user/login");
64
65		return $page->render([
66		"title" => "A index page",
67		]);
68		}
69
70
71
72		/**
73		* Description.
74		*
75		* @param datatype $variable Description
		0 ignored issues – show Bug introduced 2021-05-30 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
76		*
77		* @throws Exception
78		*
79		* @return object as a response object
80		*/
81	View Code Duplication	public function loginAction() : object
		0 ignored issues – show Duplication introduced 2021-05-30 13:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$page = $this->di->get("page");
84		$form = new UserLoginForm($this->di);
85		$form->check();
86		$data = [
87		"form" => $form->getHTML(),
88		"title" => "A login page",
89		];
90		$page->add("user/login", $data);
91		return $page->render($data);
92		}
93
94		/**
95		* Description.
96		*
97		* @param datatype $variable Description
		0 ignored issues – show Bug introduced 2021-05-30 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
98		*
99		* @throws Exception
100		*
101		* @return object as a response object
102		*/
103	View Code Duplication	public function createAction() : object
		0 ignored issues – show Duplication introduced 2021-05-30 13:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		$page = $this->di->get("page");
106		$form = new CreateUserForm($this->di);
107		$form->check();
108
109		$data = [
110		"form" => $form->getHTML(),
111		"title" => "Create user"
112		];
113
114		$page->add("user/create", $data);
115		return $page->render($data);
116		}
117
118		public function viewAction($userId): object
119		{
120		$page = $this->di->get("page");
121		$user = new User();
122		$question = new Question();
123		$answer = new Answer;
124		$comment = new Comment;
125		$user->setDb($this->di->get("dbqb"));
126		$answer->setDb($this->di->get("dbqb"));
127		$comment->setDb($this->di->get("dbqb"));
128		$question->setDb($this->di->get("dbqb"));
129		$user->findById($userId);
130		$questions = $question->findAllWhere("user_id = ?", $userId);
131		$comments = $comment->findAllWhere("user_id = ?", $userId);
132		$answers = $answer->findAllWhere("user_id = ?", $userId);
133		$data = [
134		"title" => $user->acronym,
135		"user" => $user,
136		"questions" => $questions,
137		"comments" => $comments,
138		"answers" => $answers,
139		];
140
141		$page->add("user/view", $data);
142		return $page->render($data);
143		}
144
145
146		/**
147		* Handler with form to update an item.
148		*
149		* @param int $id the id to update.
150		*
151		* @return object as a response object
152		*/
153	View Code Duplication	public function updateAction(int $id) : object
		0 ignored issues – show Duplication introduced 2021-05-30 13:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
154		{
155		$page = $this->di->get("page");
156		$form = new UpdateForm($this->di, $id);
157		$form->check();
158
159		$page->add("user/update", [
160		"form" => $form->getHTML(),
161		]);
162
163		return $page->render([
164		"title" => "Update an item",
165		]);
166		}
167		}
168

AsaTirsen / forum

Issues (47)

Security Analysis not enabled

src/User/UserController.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like