ContactController::store() - Code Metrics - Inspection of "new contact tests" - ArthurGuy/ProcessMonitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e5e9bc...6188cd )

by Arthur

created 2016-01-29 13:08 UTC

ContactController::store() B

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	26
rs	8.8571
cc	3
eloc	16
nc	3
nop	1

<?php

namespace App\Http\Controllers;

use Validator;
use App\Contact;
use App\Http\Requests;
use Illuminate\Http\Request;

class ContactController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {
            return Contact::all();
        }

        return view('template');
    }

    public function store(Request $request)
    {
        if (!$request->wantsJson()) {
            return response("Contacts can only be created via json requests", 400);
        }

        $validator = Validator::make($request->all(), [
            'name'        => 'required|max:255',
            'email'       => 'required|email|max:255',
            'filter_tags' => 'max:255',
        ]);

        if ($validator->fails()) {
            return response($validator->getMessageBag(), 422);
        }

        $contact              = new Contact;
        $contact->name        = $request->get('name');
        $contact->email       = $request->get('email');
        $contact->filter_tags = $request->get('filter_tags');
        $contact->active      = true;
        $contact->save();

        //Re-fetch so we have a full record
        return Contact::findOrFail($contact->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function destroy(Request $request, $id)

    {
        Contact::findOrFail($id)->delete();

        return response(null, 204);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Validator;
6			use App\Contact;
7			use App\Http\Requests;
8			use Illuminate\Http\Request;
9
10			class ContactController extends Controller
11			{
12			public function index(Request $request)
13			{
14			if ($request->wantsJson()) {
15			return Contact::all();
16			}
17
18			return view('template');
19			}
20
21			public function store(Request $request)
22			{
23			if (!$request->wantsJson()) {
24			return response("Contacts can only be created via json requests", 400);
25			}
26
27			$validator = Validator::make($request->all(), [
28			'name' => 'required\|max:255',
29			'email' => 'required\|email\|max:255',
30			'filter_tags' => 'max:255',
31			]);
32
33			if ($validator->fails()) {
34			return response($validator->getMessageBag(), 422);
35			}
36
37			$contact = new Contact;
38			$contact->name = $request->get('name');
39			$contact->email = $request->get('email');
40			$contact->filter_tags = $request->get('filter_tags');
41			$contact->active = true;
42			$contact->save();
43
44			//Re-fetch so we have a full record
45			return Contact::findOrFail($contact->id);
			0 ignored issues – show Documentation introduced 2016-01-29 13:17 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Contact>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			}
47
48			public function destroy(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-01-29 13:17 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49			{
50			Contact::findOrFail($id)->delete();
51
52			return response(null, 204);
53			}
54			}
55

ArthurGuy / ProcessMonitor

Push — master ( e5e9bc...6188cd )

ContactController::store() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like