GoCardlessHelper::getPayment() - Code Metrics - Inspection of "Upgraded GoCardless to the new API" - ArthurGuy/BBMembershipSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#216)

by Arthur

created 2017-10-30 15:11 UTC

GoCardlessHelper::getPayment() A

↳ Parent: GoCardlessHelper

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php namespace BB\Helpers;

class GoCardlessHelper
{

    private $account_details;

    /**
     * @var \GoCardlessPro\Client
     */
    private $client;

    public function __construct()
    {
        $this->setup();
    }

    public function setup()
    {
        $this->account_details = array(
            'app_id'        => env('GOCARDLESS_APP_ID', ''),
            'app_secret'    => env('GOCARDLESS_APP_SECRET', ''),
            'merchant_id'   => env('GOCARDLESS_MERCHANT_ID', ''),
            'access_token'  => env('GOCARDLESS_ACCESS_TOKEN', ''),
        );

        $this->client = new \GoCardlessPro\Client([
            'access_token' => env('NEW_GOCARDLESS_ACCESS_TOKEN'),
            'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE')? \GoCardlessPro\Environment::LIVE: \GoCardlessPro\Environment::SANDBOX,
        ]);
    }

    public function getPayment($paymentId)
    {
        return $this->client->payments()->get($paymentId);
    }

    public function newPreAuthUrl($user, $paymentDetails)
    {
        $redirectFlow = $this->client->redirectFlows()->create([
            "params" => $paymentDetails
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        ]);

        $user->gocardless_setup_id = $redirectFlow->id;
        $user->save();

        return $redirectFlow->redirect_url;
    }

    public function confirmResource($user, $confirm_params)
    {
        return $this->client->redirectFlows()->complete(
            $user->gocardless_setup_id,
            ["params" => ["session_token" => 'user-token-'.$user->id]]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
    }

    public function cancelSubscription($id)
    {
        return $this->client->subscriptions()->cancel($id);
    }

    /**
     * Create a new payment against a preauth
     * @param             $preauthId
     * @param             $amount
     * @param null|string $name
     * @param null|string $description
     * @return bool|mixed
     */
    public function newBill($preauthId, $amount, $name = null, $description = null)
    {
        try {
            return $this->client->payments()->create([
                "params" => [
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    "amount" => $amount, // amount in pence
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    "currency" => "GBP",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    "links" => [
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        "mandate" => $preauthId
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    ],
                    "metadata" => [
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        "description" => $name
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    ]
                ],
                "headers" => [
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    //"Idempotency-Key" => $preauthId . ':' . time()

                ]
            ]);
        } catch (\Exception $e) {
            \Log::error($e);
            return false;
        }
    }

    public function cancelPreAuth($preauthId)
    {
        if (empty($preauthId)) {
            return true;
        }
        try {
            $mandate = $this->client->mandates()->cancel($preauthId);

            return ($mandate->status == 'cancelled');
        } catch (\Exception $e) {
            \Log::error($e);
            return false;
        }
    }

    /**
     * @param string $reason
     * @return null|string
     */
    public function getNameFromReason($reason)
    {
        switch ($reason) {
            case 'subscription':
                return 'Monthly subscription';
            case 'balance':
                return 'Balance top up';
            case 'equipment-fee':
                return 'Equipment access fee';
            case 'door-key':
                return 'Door key';
        }

        return null;
    }
} 


1		<?php namespace BB\Helpers;
2
3		class GoCardlessHelper
4		{
5
6		private $account_details;
7
8		/**
9		* @var \GoCardlessPro\Client
10		*/
11		private $client;
12
13		public function __construct()
14		{
15		$this->setup();
16		}
17
18		public function setup()
19		{
20		$this->account_details = array(
21		'app_id' => env('GOCARDLESS_APP_ID', ''),
22		'app_secret' => env('GOCARDLESS_APP_SECRET', ''),
23		'merchant_id' => env('GOCARDLESS_MERCHANT_ID', ''),
24		'access_token' => env('GOCARDLESS_ACCESS_TOKEN', ''),
25		);
26
27		$this->client = new \GoCardlessPro\Client([
28		'access_token' => env('NEW_GOCARDLESS_ACCESS_TOKEN'),
29		'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE')? \GoCardlessPro\Environment::LIVE: \GoCardlessPro\Environment::SANDBOX,
30		]);
31		}
32
33		public function getPayment($paymentId)
34		{
35		return $this->client->payments()->get($paymentId);
36		}
37
38		public function newPreAuthUrl($user, $paymentDetails)
39		{
40		$redirectFlow = $this->client->redirectFlows()->create([
41		"params" => $paymentDetails
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `params` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
42		]);
43
44		$user->gocardless_setup_id = $redirectFlow->id;
45		$user->save();
46
47		return $redirectFlow->redirect_url;
48		}
49
50		public function confirmResource($user, $confirm_params)
51		{
52		return $this->client->redirectFlows()->complete(
53		$user->gocardless_setup_id,
54		["params" => ["session_token" => 'user-token-'.$user->id]]
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `params` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `session_token` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
55		);
56		}
57
58		public function cancelSubscription($id)
59		{
60		return $this->client->subscriptions()->cancel($id);
61		}
62
63		/**
64		* Create a new payment against a preauth
65		* @param $preauthId
66		* @param $amount
67		* @param null\|string $name
68		* @param null\|string $description
69		* @return bool\|mixed
70		*/
71		public function newBill($preauthId, $amount, $name = null, $description = null)
72		{
73		try {
74		return $this->client->payments()->create([
75		"params" => [
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `params` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
76		"amount" => $amount, // amount in pence
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 23:43 UTC by Report Bug Copy Issue Report The string literal `amount` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
77		"currency" => "GBP",
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `currency` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `GBP` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
78		"links" => [
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `links` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
79		"mandate" => $preauthId
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 23:43 UTC by Report Bug Copy Issue Report The string literal `mandate` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
80		],
81		"metadata" => [
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 23:43 UTC by Report Bug Copy Issue Report The string literal `metadata` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
82		"description" => $name
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `description` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
83		]
84		],
85		"headers" => [
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `headers` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
86		//"Idempotency-Key" => $preauthId . ':' . time()
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report `40%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
87		]
88		]);
89		} catch (\Exception $e) {
90		\Log::error($e);
91		return false;
92		}
93		}
94
95		public function cancelPreAuth($preauthId)
96		{
97		if (empty($preauthId)) {
98		return true;
99		}
100		try {
101		$mandate = $this->client->mandates()->cancel($preauthId);
102
103		return ($mandate->status == 'cancelled');
104		} catch (\Exception $e) {
105		\Log::error($e);
106		return false;
107		}
108		}
109
110		/**
111		* @param string $reason
112		* @return null\|string
113		*/
114	View Code Duplication	public function getNameFromReason($reason)
115		{
116		switch ($reason) {
117		case 'subscription':
118		return 'Monthly subscription';
119		case 'balance':
120		return 'Balance top up';
121		case 'equipment-fee':
122		return 'Equipment access fee';
123		case 'door-key':
124		return 'Door key';
125		}
126
127		return null;
128		}
129		}
130

ArthurGuy / BBMembershipSystem

Pull Request — master (#216)

GoCardlessHelper::getPayment() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like