SubscriptionController::destroy() - Code Metrics - Inspection of "Upgraded GoCardless to the new API" - ArthurGuy/BBMembershipSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — gocardless-upgrade ( ab99fa )

by Arthur

created 2017-10-28 13:15 UTC

SubscriptionController::destroy() B

↳ Parent: SubscriptionController

Complexity

Conditions	6
Paths	9

Size

Total Lines	38
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	8.439
c	0
b	0
f	0
cc	6
eloc	25
nc	9
nop	2

<?php namespace BB\Http\Controllers;

use BB\Entities\User;
use BB\Repo\SubscriptionChargeRepository;

class SubscriptionController extends Controller
{


    /**
     * @var SubscriptionChargeRepository
     */
    private $subscriptionChargeRepository;
    /**
     * @var \BB\Repo\UserRepository
     */
    private $userRepository;

    function __construct(\BB\Helpers\GoCardlessHelper $goCardless, SubscriptionChargeRepository $subscriptionChargeRepository, \BB\Repo\UserRepository $userRepository)

    {
        $this->goCardless = $goCardless;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->subscriptionChargeRepository = $subscriptionChargeRepository;
        $this->userRepository = $userRepository;

        $this->middleware('role:member', array('only' => ['create', 'destroy']));
    }

    /**
     * Setup a new pre auth
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create($userId)
    {
        $user = User::findWithPermission($userId);
        $payment_details = array(
            "description"          => "Build Brighton",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'success_redirect_url' => route('account.subscription.store', $user->id),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            "session_token"        => 'user-token-'.$user->id,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'prefilled_customer'   => [
                'given_name'    => $user->given_name,
                'family_name'   => $user->family_name,
                'email'         => $user->email,
                'address_line1' => $user->address->line_1,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'address_line2' => $user->address->line_2,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'city'          => $user->address->line_3,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'postal_code'   => $user->address->postcode,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'country_code'  => 'GB'
            ]
        );

        return \Redirect::to($this->goCardless->newPreAuthUrl($user, $payment_details));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store($userId)
    {
        $confirm_params = array(
            'resource_id'    => \Request::get('resource_id'),
            'resource_type'  => \Request::get('resource_type'),
            'resource_uri'   => \Request::get('resource_uri'),
            'signature'      => \Request::get('signature'),
        );

        // State is optional
        if (\Request::get('state')) {
            $confirm_params['state'] = \Request::get('state');
        }

        $user = User::findWithPermission($userId);

        try {
            $confirmed_resource = $this->goCardless->confirmResource($user, $confirm_params);
        } catch (\Exception $e) {
            \Notification::error($e->getMessage());
            return \Redirect::route('account.show', $user->id);
        }


        if (!isset($confirmed_resource->links->mandate) || empty($confirmed_resource->links->mandate)) {
            \Notification::error('Something went wrong, you can try again or get in contact');
            return \Redirect::route('account.show', $user->id);
        }

        $this->userRepository->recordGoCardlessVariableDetails($user->id, $confirmed_resource->links->mandate);

        //all we need for a valid member is an active dd so make sure the user account is active
        $this->userRepository->ensureMembershipActive($user->id);

        return \Redirect::route('account.show', [$user->id]);
    }


    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return Illuminate\Http\RedirectResponse
     */
    public function destroy($userId, $id = null)
    {

        /**
         * TODO: Check for and cancel pending sub charges
         */
        $user = User::findWithPermission($userId);
        if ($user->payment_method == 'gocardless') {
            try {
                $subscription = $this->goCardless->cancelSubscription($user->subscription_id);
                if ($subscription->status == 'cancelled') {
                    $user->cancelSubscription();

                    \Notification::success('Your subscription has been cancelled');
                    return \Redirect::back();
                }
            } catch (\Exception $e) {
                $user->cancelSubscription();

                \Notification::success('Your subscription has been cancelled');
                return \Redirect::back();
            }
        } elseif ($user->payment_method == 'gocardless-variable') {
            $status = $this->goCardless->cancelPreAuth($user->subscription_id);
            if ($status) {
                $user->subscription_id = null;
                $user->payment_method = '';
                $user->save();

                $user->setLeaving();


                $this->subscriptionChargeRepository->cancelOutstandingCharges($userId);

                \Notification::success('Your direct debit has been cancelled');
                return \Redirect::back();
            }
        }
        \Notification::error('Sorry, we were unable to cancel your subscription, please get in contact');
        return \Redirect::back();
    }


    public function listCharges()
    {
        $charges = $this->subscriptionChargeRepository->getChargesPaginated();
        return \View::make('payments.sub-charges')->with('charges', $charges);
    }

    public function updatePaymentMethod($id)
    {
        $user = User::findWithPermission($id);
        $paymentMethod = \Input::get('payment_method');

        if ($paymentMethod === 'balance' && $user->payment_method != $paymentMethod) {
            $status = $this->goCardless->cancelPreAuth($user->subscription_id);
            if ($status) {
                $user->subscription_id = null;
                $user->payment_method  = 'balance';
                $user->save();

                // If we don't cancel the sub charge the balance process may pick it up
                //$this->subscriptionChargeRepository->cancelOutstandingCharges($userId);

            }
        }

        \Notification::success('Details Updated');
        return \Redirect::route('account.show', [$user->id]);
    }
}


1			<?php namespace BB\Http\Controllers;
2
3			use BB\Entities\User;
4			use BB\Repo\SubscriptionChargeRepository;
5
6			class SubscriptionController extends Controller
7			{
8
9
10			/**
11			* @var SubscriptionChargeRepository
12			*/
13			private $subscriptionChargeRepository;
14			/**
15			* @var \BB\Repo\UserRepository
16			*/
17			private $userRepository;
18
19			function __construct(\BB\Helpers\GoCardlessHelper $goCardless, SubscriptionChargeRepository $subscriptionChargeRepository, \BB\Repo\UserRepository $userRepository)
			0 ignored issues – show Best Practice introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
20			{
21			$this->goCardless = $goCardless;
			0 ignored issues – show Bug introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report The property `goCardless` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			$this->subscriptionChargeRepository = $subscriptionChargeRepository;
23			$this->userRepository = $userRepository;
24
25			$this->middleware('role:member', array('only' => ['create', 'destroy']));
26			}
27
28			/**
29			* Setup a new pre auth
30			*
31			* @return \Illuminate\Http\RedirectResponse
32			*/
33			public function create($userId)
34			{
35			$user = User::findWithPermission($userId);
36			$payment_details = array(
37			"description" => "Build Brighton",
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `description` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `Build Brighton` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
38			'success_redirect_url' => route('account.subscription.store', $user->id),
			0 ignored issues – show Documentation introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report `$user->id` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			"session_token" => 'user-token-'.$user->id,
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The string literal `session_token` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
40			'prefilled_customer' => [
41			'given_name' => $user->given_name,
42			'family_name' => $user->family_name,
43			'email' => $user->email,
44			'address_line1' => $user->address->line_1,
			0 ignored issues – show Documentation introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The property `address` does not exist on `object<BB\Entities\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			'address_line2' => $user->address->line_2,
			0 ignored issues – show Documentation introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The property `address` does not exist on `object<BB\Entities\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			'city' => $user->address->line_3,
			0 ignored issues – show Documentation introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The property `address` does not exist on `object<BB\Entities\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
47			'postal_code' => $user->address->postcode,
			0 ignored issues – show Documentation introduced 2017-10-28 13:18 UTC by Report Bug Copy Issue Report The property `address` does not exist on `object<BB\Entities\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48			'country_code' => 'GB'
49			]
50			);
51
52			return \Redirect::to($this->goCardless->newPreAuthUrl($user, $payment_details));
53			}
54
55			/**
56			* Store a newly created resource in storage.
57			*
58			* @return \Illuminate\Http\RedirectResponse
59			*/
60			public function store($userId)
61			{
62			$confirm_params = array(
63			'resource_id' => \Request::get('resource_id'),
64			'resource_type' => \Request::get('resource_type'),
65			'resource_uri' => \Request::get('resource_uri'),
66			'signature' => \Request::get('signature'),
67			);
68
69			// State is optional
70			if (\Request::get('state')) {
71			$confirm_params['state'] = \Request::get('state');
72			}
73
74			$user = User::findWithPermission($userId);
75
76			try {
77			$confirmed_resource = $this->goCardless->confirmResource($user, $confirm_params);
78			} catch (\Exception $e) {
79			\Notification::error($e->getMessage());
80			return \Redirect::route('account.show', $user->id);
81			}
82
83
84			if (!isset($confirmed_resource->links->mandate) \|\| empty($confirmed_resource->links->mandate)) {
85			\Notification::error('Something went wrong, you can try again or get in contact');
86			return \Redirect::route('account.show', $user->id);
87			}
88
89			$this->userRepository->recordGoCardlessVariableDetails($user->id, $confirmed_resource->links->mandate);
90
91			//all we need for a valid member is an active dd so make sure the user account is active
92			$this->userRepository->ensureMembershipActive($user->id);
93
94			return \Redirect::route('account.show', [$user->id]);
95			}
96
97
98			/**
99			* Remove the specified resource from storage.
100			*
101			* @param int $id
102			* @return Illuminate\Http\RedirectResponse
103			*/
104			public function destroy($userId, $id = null)
105			{
106
107			/**
108			* TODO: Check for and cancel pending sub charges
109			*/
110			$user = User::findWithPermission($userId);
111			if ($user->payment_method == 'gocardless') {
112			try {
113			$subscription = $this->goCardless->cancelSubscription($user->subscription_id);
114			if ($subscription->status == 'cancelled') {
115			$user->cancelSubscription();
			0 ignored issues – show Deprecated Code introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report The method `BB\Entities\User::cancelSubscription()` has been deprecated. This method has been deprecated. Loading history...
116			\Notification::success('Your subscription has been cancelled');
117			return \Redirect::back();
118			}
119			} catch (\Exception $e) {
120			$user->cancelSubscription();
			0 ignored issues – show Deprecated Code introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report The method `BB\Entities\User::cancelSubscription()` has been deprecated. This method has been deprecated. Loading history...
121			\Notification::success('Your subscription has been cancelled');
122			return \Redirect::back();
123			}
124			} elseif ($user->payment_method == 'gocardless-variable') {
125			$status = $this->goCardless->cancelPreAuth($user->subscription_id);
126			if ($status) {
127			$user->subscription_id = null;
128			$user->payment_method = '';
129			$user->save();
130
131			$user->setLeaving();
			0 ignored issues – show Deprecated Code introduced 2015-11-23 19:55 UTC by Report Bug Copy Issue Report The method `BB\Entities\User::setLeaving()` has been deprecated. This method has been deprecated. Loading history...
132
133			$this->subscriptionChargeRepository->cancelOutstandingCharges($userId);
134
135			\Notification::success('Your direct debit has been cancelled');
136			return \Redirect::back();
137			}
138			}
139			\Notification::error('Sorry, we were unable to cancel your subscription, please get in contact');
140			return \Redirect::back();
141			}
142
143
144			public function listCharges()
145			{
146			$charges = $this->subscriptionChargeRepository->getChargesPaginated();
147			return \View::make('payments.sub-charges')->with('charges', $charges);
148			}
149
150			public function updatePaymentMethod($id)
151			{
152			$user = User::findWithPermission($id);
153			$paymentMethod = \Input::get('payment_method');
154
155			if ($paymentMethod === 'balance' && $user->payment_method != $paymentMethod) {
156			$status = $this->goCardless->cancelPreAuth($user->subscription_id);
157			if ($status) {
158			$user->subscription_id = null;
159			$user->payment_method = 'balance';
160			$user->save();
161
162			// If we don't cancel the sub charge the balance process may pick it up
163			//$this->subscriptionChargeRepository->cancelOutstandingCharges($userId);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-23 22:15 UTC by Report Bug Copy Issue Report `78%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
164			}
165			}
166
167			\Notification::success('Details Updated');
168			return \Redirect::route('account.show', [$user->id]);
169			}
170			}
171

ArthurGuy / BBMembershipSystem

Push — gocardless-upgrade ( ab99fa )

SubscriptionController::destroy() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like