GoCardlessWebhookController::receive() - Code Metrics - Inspection of "Upgraded GoCardless to the new API" - ArthurGuy/BBMembershipSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — gocardless-upgrade ( ab99fa )

by Arthur

created 2017-10-28 13:15 UTC

GoCardlessWebhookController::receive() D

↳ Parent: GoCardlessWebhookController

Complexity

Conditions	15
Paths	15

Size

Total Lines	86
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	86
rs	4.9121
c	0
b	0
f	0
cc	15
eloc	50
nc	15
nop	0

How to fix Long Method Complexity

<?php namespace BB\Http\Controllers;


use BB\Entities\Payment;
use BB\Entities\User;
use BB\Helpers\GoCardlessHelper;
use BB\Repo\PaymentRepository;
use BB\Repo\SubscriptionChargeRepository;
use \Carbon\Carbon;
use Illuminate\Http\Request;

class GoCardlessWebhookController extends Controller
{

    /**
     * @var PaymentRepository
     */
    private $paymentRepository;
    /**
     * @var SubscriptionChargeRepository
     */
    private $subscriptionChargeRepository;
    /**
     * @var GoCardlessHelper
     */
    private $goCardless;

    public function __construct(GoCardlessHelper $goCardless, PaymentRepository $paymentRepository, SubscriptionChargeRepository $subscriptionChargeRepository)
    {
        $this->goCardless = $goCardless;
        $this->paymentRepository = $paymentRepository;
        $this->subscriptionChargeRepository = $subscriptionChargeRepository;
    }

    public function receive()
    {
        $request = \Request::instance();
        $webhookData = $request->getContent();
        $signature = $request->header('Webhook-Signature');

        $hash = hash_hmac('sha256', $webhookData, 'Z4Zw1Bna_aoHo1Ifg-ZyU3NRVOjcQSuQP10zWHKg');

        if ($signature != $hash) {
            return \Response::make('', 403);
        }

        $webhookData = json_decode($webhookData, true);

        foreach ($webhookData['events'] as $event) {
            $parser = new \BB\Services\Payment\GoCardlessWebhookParser();
            $parser->parseResponse($event);

            switch ($parser->getResourceType()) {
                case 'payments':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                    switch ($parser->getAction()) {
                        case 'created':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->processNewPayment($event);

                            break;
                        case 'submitted':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            break;
                        case 'confirmed':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->processPaidBills($event);

                            break;
                        case 'paid_out':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            break;
                        case 'failed':
                        case 'cancelled':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->paymentFailed($event);

                            break;
                        default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

                            \Log::info('GoCardless payment event. Action: ' . $parser->getAction() . '. Data: ' . json_encode($event));
                    }

                    break;
                case 'mandates':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                    switch ($parser->getAction()) {
                        case 'cancelled':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->cancelPreAuth($event);

                            break;
                        default:
                    }

                    break;
                case 'subscriptions':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                    switch ($parser->getAction()) {
                        case 'cancelled':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->cancelSubscriptions($event);

                            break;
                        case 'payment_created':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                            $this->processNewSubscriptionPayment($event);

                            break;
                        default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

                            \Log::info('GoCardless subscription event. Action: ' . $parser->getAction() . '. Data: ' . json_encode($event));
                    }

                    break;
            }
        }

        return \Response::make('Success', 200);
    }


    /**
     * A Bill has been created, these will always start within the system except for subscription payments
     *
     * @param array $bill
     */
    private function processNewPayment(array $bill)
    {
        \Log::info('New payment notification. ' . json_encode($bill));
    }


    /**
     * A Bill has been created, these will always start within the system except for subscription payments
     *
     * @param array $bill
     */
    private function processNewSubscriptionPayment(array $bill)
    {
        // Lookup the payment from the API
        $payment = $this->goCardless->getPayment($bill['links']['payment']);

        try {

            //Locate the user through their subscription id
            $user = User::where('payment_method', 'gocardless')->where('subscription_id', $bill['links']['subscription'])->first();

            if ( ! $user) {
                \Log::warning("GoCardless new sub payment notification for unmatched user. Bill ID: " . $bill['links']['payment']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                return;
            }

            $amount = ($payment->amount * 1) / 100;
            $this->paymentRepository->recordSubscriptionPayment($user->id, 'gocardless', $bill['links']['payment'], $amount, $payment->status);

        } catch (\Exception $e) {
            \Log::error($e);
        }
    }


    private function processPaidBills(array $bill)
    {
        //When a bill is paid update the status on the local record and the connected sub charge (if there is one)

        $existingPayment = $this->paymentRepository->getPaymentBySourceId($bill['links']['payment']);
        if ($existingPayment) {

            if (isset($bill['paid_at'])) {
                $paymentDate = new Carbon($bill['paid_at']);
            } else {
                $paymentDate = new Carbon();
            }

            $this->paymentRepository->markPaymentPaid($existingPayment->id, $paymentDate);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        } else {
            \Log::info("GoCardless Webhook received for unknown payment: " . $bill['id']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
    }

    /**
     * @param array $bill
     */
    private function paymentFailed(array $bill)
    {
        $existingPayment = $this->paymentRepository->getPaymentBySourceId($bill['links']['payment']);
        $payment = $this->goCardless->getPayment($bill['links']['payment']);
        if ($existingPayment) {
            $this->paymentRepository->recordPaymentFailure($existingPayment->id, $payment->status);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            \Log::info("GoCardless Webhook received for unknown payment: " . $bill['links']['payment']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

    }

    /**
     * @param string $action
     */
    private function processBills($action, array $bills)
    {
        foreach ($bills as $bill) {
            $existingPayment = $this->paymentRepository->getPaymentBySourceId($bill['id']);
            if ($existingPayment) {
                if (($bill['status'] == 'pending') && ($action == 'resubmission_requested')) {
                    //Failed payment is being retried
                    $subCharge = $this->subscriptionChargeRepository->getById($existingPayment->reference);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    if ($subCharge) {
                        if ($subCharge->amount == $bill['amount']) {
                            $this->subscriptionChargeRepository->markChargeAsProcessing($subCharge->id);
                        } else {
                            //@TODO: Handle partial payments
                            \Log::warning("Sub charge handling - gocardless partial payment");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        }
                    }
                } elseif ($bill['status'] == 'refunded') {
                    //Payment refunded
                    //Update the payment record and possible the user record
                }
            } else {
                \Log::info("GoCardless Webhook received for unknown payment: " . $bill['id']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }

    }

    /**
     * @param array $preAuth
     */
    private function cancelPreAuth($preAuth)
    {
        /** @var User $user */
        $user = User::where('payment_method', 'gocardless-variable')->where('subscription_id', $preAuth['links']['mandate'])->first();
        if ($user) {
            $user->cancelSubscription();

        }
    }


    private function cancelSubscriptions($subscription)
    {
        //Make sure our local record is correct
        /** @var User $user */
        $user = User::where('payment_method', 'gocardless')->where('subscription_id', $subscription['links']['subscription'])->first();
        if ($user) {
            $user->cancelSubscription();

        }
    }

}


1			<?php namespace BB\Http\Controllers;
2
3
4			use BB\Entities\Payment;
5			use BB\Entities\User;
6			use BB\Helpers\GoCardlessHelper;
7			use BB\Repo\PaymentRepository;
8			use BB\Repo\SubscriptionChargeRepository;
9			use \Carbon\Carbon;
10			use Illuminate\Http\Request;
11
12			class GoCardlessWebhookController extends Controller
13			{
14
15			/**
16			* @var PaymentRepository
17			*/
18			private $paymentRepository;
19			/**
20			* @var SubscriptionChargeRepository
21			*/
22			private $subscriptionChargeRepository;
23			/**
24			* @var GoCardlessHelper
25			*/
26			private $goCardless;
27
28			public function __construct(GoCardlessHelper $goCardless, PaymentRepository $paymentRepository, SubscriptionChargeRepository $subscriptionChargeRepository)
29			{
30			$this->goCardless = $goCardless;
31			$this->paymentRepository = $paymentRepository;
32			$this->subscriptionChargeRepository = $subscriptionChargeRepository;
33			}
34
35			public function receive()
36			{
37			$request = \Request::instance();
38			$webhookData = $request->getContent();
39			$signature = $request->header('Webhook-Signature');
40

ArthurGuy / BBMembershipSystem

Push — gocardless-upgrade ( ab99fa )

GoCardlessWebhookController::receive() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like