ArthurGuy / BBMembershipSystem

app/Http/Controllers/SettingsController.php

Indentation +8 added lines, -8 removed lines

@@ -5,19 +5,19 @@
 class SettingsController extends Controller
 {
 
-	/**
-	 * Store a newly created resource in storage.
-	 *
-	 * @return \Illuminate\Http\RedirectResponse
-	 */
-	public function update()
-	{
+    /**
+     * Store a newly created resource in storage.
+     *
+     * @return \Illuminate\Http\RedirectResponse
+     */
+    public function update()
+    {
         $input = \Input::only('key', 'value');
 
         Settings::change($input['key'], $input['value']);
 
         \Notification::success("Setting updated");
         return redirect()->back()->withInput();
-	}
+    }
 
 }

app/Http/Middleware/SSLOnly.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function handle($request, Closure $next)
     {
-        if( ! $request->isSecure() && env('FORCE_SECURE', 'true')) {
+        if ( ! $request->isSecure() && env('FORCE_SECURE', 'true')) {
             if ((strpos($request->path(), 'access-control/') !== 0) && ($request->path() !== 'acs') && ($request->path() !== 'acs/spark')) {
                 return redirect()->secure($request->path());
             }

app/Http/routes.php

Spacing +17 added lines, -17 removed lines

@@ -72,7 +72,7 @@ 
 
 Route::post('account/{account}/payment', ['uses' => 'PaymentController@store', 'as' => 'account.payment.store', 'middleware' => 'role:admin']);
 
-Route::group(array('middleware' => 'role:finance'), function() {
+Route::group(array('middleware' => 'role:finance'), function () {
     Route::resource('payments', 'PaymentController', ['only' => ['index', 'destroy', 'update']]);
     Route::get('payments/overview', ['uses'=>'PaymentOverviewController@index', 'as'=>'payments.overview']);
     Route::get('payments/sub-charges', ['as' => 'payments.sub-charges', 'uses' => 'SubscriptionController@listCharges']);
@@ -92,13 +92,13 @@ 
 
 
 //Cash
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::post('account/{account}/payment/cash/create', ['as'=>'account.payment.cash.create', 'uses' => 'CashPaymentController@store']);
     Route::delete('account/{account}/payment/cash', ['as'=>'account.payment.cash.destroy', 'uses' => 'CashPaymentController@destroy']);
 });
 
 # Statements
-Route::group(array('middleware' => 'role:finance'), function() {
+Route::group(array('middleware' => 'role:finance'), function () {
     Route::resource('statement-import', 'StatementImportController', ['except' => ['index', 'show', 'edit', 'update', 'destroy']]);
 });
 
@@ -111,7 +111,7 @@ 
 # Inductions
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::post('equipment_training/update', ['uses'=>'InductionController@update', 'as'=>'equipment_training.update']);
     Route::resource('account.induction', 'InductionController', ['only' => ['update', 'destroy']]);
 });
@@ -122,7 +122,7 @@ 
 # Equipment
 ##########################
 
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('equipment', 'EquipmentController');
     Route::post('equipment/{id}/photo', ['uses'=>'EquipmentController@addPhoto', 'as'=>'equipment.photo.store']);
     Route::delete('equipment/{id}/photo/{key}', ['uses'=>'EquipmentController@destroyPhoto', 'as'=>'equipment.photo.destroy']);
@@ -145,7 +145,7 @@ 
 # Key fobs
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('keyfob', 'KeyFobController', ['only' => ['index', 'store', 'update', 'destroy']]);
 });
 
@@ -178,11 +178,11 @@ 
 Route::post('camera/event/store', ['uses' => 'CCTVController@store']);
 Route::post('camera/store', ['uses' => 'CCTVController@storeSingle']);
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('detected_devices', 'DetectedDevicesController');
 });
 
-Route::group(array('middleware' => 'role:acs'), function() {
+Route::group(array('middleware' => 'role:acs'), function () {
     Route::resource('devices', 'DeviceController');
 });
 
@@ -259,11 +259,11 @@ 
 # Roles
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('roles', 'RolesController', []);
     Route::resource('roles.users', 'RoleUsersController', ['only' => ['destroy', 'store']]);
 });
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('groups', 'GroupsController', ['only' => ['index', 'show']]);
 });
 
@@ -282,7 +282,7 @@ 
 # Expenses
 ##########################
 
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('expenses', 'ExpensesController');
 });
 
@@ -305,10 +305,10 @@ 
 
 
 
-Route::any('api-docs.json', function() {
+Route::any('api-docs.json', function () {
     $filePath = Config::get('swagger.doc-dir') . "/api-docs.json";
 
-    if (!File::Exists($filePath)) {
+    if ( ! File::Exists($filePath)) {
         App::abort(404, "Cannot find {$filePath}");
     }
 
@@ -318,13 +318,13 @@ 
     ));
 });
 
-Route::get('api-docs', function() {
+Route::get('api-docs', function () {
     if (Config::get('swagger.generateAlways')) {
-        $appDir = base_path()."/".Config::get('swagger.app-dir');
+        $appDir = base_path() . "/" . Config::get('swagger.app-dir');
         $docDir = Config::get('swagger.doc-dir');
 
 
-        if (!File::exists($docDir) || is_writable($docDir)) {
+        if ( ! File::exists($docDir) || is_writable($docDir)) {
             // delete all existing documentation
             if (File::exists($docDir)) {
                 File::deleteDirectory($docDir);
@@ -334,7 +334,7 @@ 
 
             $excludeDirs = Config::get('swagger.excludes');
 
-            $swagger =  \Swagger\scan($appDir, [
+            $swagger = \Swagger\scan($appDir, [
                 'exclude' => $excludeDirs
             ]);
 

app/Helpers/GoCardlessHelper.php

Spacing +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
 
         $this->client = new \GoCardlessPro\Client([
             'access_token' => env('NEW_GOCARDLESS_ACCESS_TOKEN'),
-            'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE')? \GoCardlessPro\Environment::LIVE: \GoCardlessPro\Environment::SANDBOX,
+            'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE') ? \GoCardlessPro\Environment::LIVE : \GoCardlessPro\Environment::SANDBOX,
         ]);
     }
 
@@ -51,7 +51,7 @@ 
     {
         return $this->client->redirectFlows()->complete(
             $user->gocardless_setup_id,
-            ["params" => ["session_token" => 'user-token-'.$user->id]]
+            ["params" => ["session_token" => 'user-token-' . $user->id]]
         );
     }
 

Doc Comments +12 added lines

@@ -30,6 +30,9 @@ 
         ]);
     }
 
+    /**
+     * @return double
+     */
     public function getPayment($paymentId)
     {
         return $this->client->payments()->get($paymentId);
@@ -56,6 +59,11 @@ 
     }
 
 
+    /**
+     * @param string|null $mandate
+     * @param integer $amount
+     * @param string $subscriptionNumber
+     */
     public function createSubscription($mandate, $amount, $dayOfMonth, $subscriptionNumber)
     {
         $subscription = $this->client->subscriptions()->create([
@@ -75,6 +83,10 @@ 
 
         return $subscription;
     }
+
+    /**
+     * @param string $id
+     */
     public function cancelSubscription($id)
     {
         return $this->client->subscriptions()->cancel($id);

app/Http/Controllers/ACSController.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
      *
      * @param $message
      * @param $device
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     private function handleSystemCheckIn($message, $device, $service)
     {
@@ -183,7 +183,7 @@ 
      * @param int   $statusCode
      * @param array $responseData
      *
-     * @return \Response
+     * @return \Illuminate\Http\JsonResponse
      */
     private function sendResponse($statusCode = 200, array $responseData)
     {

Braces +2 added lines, -1 removed lines

@@ -27,7 +27,8 @@
      */
     private $equipmentLogRepository;
 
-    function __construct(ACSNodeRepository $acsNodeRepository, ACSValidator $ACSValidator, \BB\Services\KeyFobAccess $keyFobAccess, EquipmentLogRepository $equipmentLogRepository) {
+    function __construct(ACSNodeRepository $acsNodeRepository, ACSValidator $ACSValidator, \BB\Services\KeyFobAccess $keyFobAccess, EquipmentLogRepository $equipmentLogRepository)
+    {
         $this->acsNodeRepository = $acsNodeRepository;
         $this->ACSValidator     = $ACSValidator;
         $this->keyFobAccess     = $keyFobAccess;

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace BB\Http\Controllers;
 
 use BB\Entities\ACSNode;
-use BB\Entities\DetectedDevice;
 use BB\Entities\User;
 use BB\Events\MemberActivity;
 use BB\Exceptions\ValidationException;

app/Services/KeyFobAccess.php

Doc Comments +3 added lines

@@ -235,6 +235,9 @@
         return $this->user;
     }
 
+    /**
+     * @return KeyFob
+     */
     public function lookupKeyFob($keyId)
     {
         try {

app/Http/Controllers/SubscriptionController.php

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
         $payment_details = array(
             "description"          => "Build Brighton",
             'success_redirect_url' => route('account.subscription.store', $user->id),
-            "session_token"        => 'user-token-'.$user->id,
+            "session_token"        => 'user-token-' . $user->id,
             'prefilled_customer'   => [
                 'given_name'    => $user->given_name,
                 'family_name'   => $user->family_name,
@@ -82,7 +82,7 @@ 
         }
 
 
-        if (!isset($confirmed_resource->links->mandate) || empty($confirmed_resource->links->mandate)) {
+        if ( ! isset($confirmed_resource->links->mandate) || empty($confirmed_resource->links->mandate)) {
             \Notification::error('Something went wrong, you can try again or get in contact');
             return \Redirect::route('account.show', $user->id);
         }
@@ -159,7 +159,7 @@ 
 
         if ($paymentMethod === 'balance' && empty($user->payment_method) && in_array($user->status, ['setting-up', 'left', 'leaving'])) {
             // Activate a users membership with a payment method of balance
-            $user->payment_method  = 'balance';
+            $user->payment_method = 'balance';
             $user->secondary_payment_method = null;
             $user->payment_day = Carbon::now()->day;
             $user->save();
@@ -168,7 +168,7 @@ 
         }
 
         if ($paymentMethod === 'balance' && $user->payment_method == 'gocardless-variable') {
-            $user->payment_method  = 'balance';
+            $user->payment_method = 'balance';
             $user->secondary_payment_method = 'gocardless-variable';
             $user->save();
         }

app/Http/Controllers/RoleUsersController.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace BB\Http\Controllers;
 
 use BB\Entities\Role;
-use BB\Entities\User;
 use BB\Validators\RoleUserValidator;
 
 class RoleUsersController extends Controller