ArthurGuy / BBMembershipSystem

app/Repo/ACSNodeRepository.php

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
             throw new ModelNotFoundException();
         }
         $node = $this->model->where('api_key', $apiKey)->first();
-        if (!$node) {
+        if ( ! $node) {
             throw new ModelNotFoundException();
         }
         return $node;
@@ -55,7 +55,7 @@ 
     public function logBoot($device)
     {
         $record = $this->model->where('device_id', $device)->first();
-        if (!$record) {
+        if ( ! $record) {
             $record = $this->createRecord($device);
         }
         $record->last_boot = Carbon::now();

app/Repo/PaymentRepository.php

Spacing +2 added lines, -2 removed lines

@@ -188,7 +188,7 @@ 
     {
         $payment = $this->getById($paymentId);
 
-        if (!empty($payment->user_id)) {
+        if ( ! empty($payment->user_id)) {
             throw new PaymentException('Payment already assigned to user');
         }
 
@@ -266,7 +266,7 @@ 
      */
     public function getEquipmentFeePayments($referencePrefix)
     {
-        return $this->model->where('reason', 'equipment-fee')->get()->filter(function($payment) use($referencePrefix) {
+        return $this->model->where('reason', 'equipment-fee')->get()->filter(function ($payment) use($referencePrefix) {
             return strpos($payment->reference, ':' . $referencePrefix) !== false;
         });
     }

app/Services/Registrar.php

Indentation +28 added lines, -28 removed lines

@@ -6,34 +6,34 @@
 
 class Registrar implements RegistrarContract {
 
-	/**
-	 * Get a validator for an incoming registration request.
-	 *
-	 * @param  array  $data
-	 * @return \Illuminate\Contracts\Validation\Validator
-	 */
-	public function validator(array $data)
-	{
-		return Validator::make($data, [
-			'name' => 'required|max:255',
-			'email' => 'required|email|max:255|unique:users',
-			'password' => 'required|confirmed|min:6',
-		]);
-	}
+    /**
+     * Get a validator for an incoming registration request.
+     *
+     * @param  array  $data
+     * @return \Illuminate\Contracts\Validation\Validator
+     */
+    public function validator(array $data)
+    {
+        return Validator::make($data, [
+            'name' => 'required|max:255',
+            'email' => 'required|email|max:255|unique:users',
+            'password' => 'required|confirmed|min:6',
+        ]);
+    }
 
-	/**
-	 * Create a new user instance after a valid registration.
-	 *
-	 * @param  array  $data
-	 * @return User
-	 */
-	public function create(array $data)
-	{
-		return User::create([
-			'name' => $data['name'],
-			'email' => $data['email'],
-			'password' => bcrypt($data['password']),
-		]);
-	}
+    /**
+     * Create a new user instance after a valid registration.
+     *
+     * @param  array  $data
+     * @return User
+     */
+    public function create(array $data)
+    {
+        return User::create([
+            'name' => $data['name'],
+            'email' => $data['email'],
+            'password' => bcrypt($data['password']),
+        ]);
+    }
 
 }

Braces +2 added lines, -1 removed lines

@@ -4,7 +4,8 @@
 use Validator;
 use Illuminate\Contracts\Auth\Registrar as RegistrarContract;
 
-class Registrar implements RegistrarContract {
+class Registrar implements RegistrarContract
+{
 
 	/**
 	 * Get a validator for an incoming registration request.

app/Repo/UserRepository.php

Spacing +2 added lines, -2 removed lines

@@ -109,7 +109,7 @@ 
 
         $memberData['hash'] = str_random(30);
 
-        $memberData['rules_agreed'] = $memberData['rules_agreed']? Carbon::now(): null;
+        $memberData['rules_agreed'] = $memberData['rules_agreed'] ? Carbon::now() : null;
 
         $user = $this->model->create($memberData);
         $this->profileDataRepository->createProfile($user->id);
@@ -218,7 +218,7 @@ 
 
         $user->induction_completed = true;
 
-        $user->rules_agreed = $user->rules_agreed? $user->rules_agreed: Carbon::now();
+        $user->rules_agreed = $user->rules_agreed ? $user->rules_agreed : Carbon::now();
 
         $user->save();
     }

Doc Comments +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
     /**
      * Record the fact that the user has agreed to the member induction and the rules
      *
-     * @param $userId
+     * @param integer $userId
      */
     public function recordInductionCompleted($userId)
     {

app/Http/Controllers/AccountController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use BB\Events\MemberGivenTrustedStatus;
 use BB\Events\MemberPhotoWasDeclined;
 use BB\Exceptions\ValidationException;
-use BB\Validators\InductionValidator;
 
 class AccountController extends Controller
 {

Spacing +1 added lines, -1 removed lines

@@ -358,7 +358,7 @@
 
         if ($amount < 5) {
             throw new ValidationException('The minimum subscription is 5 GBP');
-        } elseif (!\Auth::user()->isAdmin() && ($amount < 15)) {
+        } elseif ( ! \Auth::user()->isAdmin() && ($amount < 15)) {
             throw new ValidationException('The minimum subscription is 15 GBP, please contact the trustees for a lower amount. trustees@buildbrighton.com');
         }
 

app/Presenters/PaymentPresenter.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             case 'manual':
                 return 'Manual';
             case 'cash':
-                return 'Cash' . ($this->entity->source_id? ' (' . $this->entity->source_id . ')':'');
+                return 'Cash' . ($this->entity->source_id ? ' (' . $this->entity->source_id . ')' : '');
             case 'other':
                 return 'Other';
             case 'balance':

app/Helpers/UserImage.php

Doc Comments +4 added lines, -1 removed lines

@@ -12,6 +12,9 @@ 
 
     }
 
+    /**
+     * @param string $userId
+     */
     public function uploadPhoto($userId, $filePath, $newImage = false)
     {
         $tmpFilePath = storage_path('app') . '/' . $userId . '.png';
@@ -46,7 +49,7 @@ 
 
     /**
      * Delete an old profile image and replace it with a new one.
-     * @param $userId
+     * @param string $userId
      */
     public function approveNewImage($userId)
     {

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace BB\Helpers;
 
-use BB\Exceptions\UserImageFailedException;
 use Illuminate\Support\Facades\Storage;
 use Intervention\Image\Facades\Image;
 

app/Http/Controllers/InductionController.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace BB\Http\Controllers;
 
 use BB\Entities\Induction;
-use BB\Exceptions\PaymentException;
 use BB\Repo\PaymentRepository;
 
 class InductionController extends Controller

app/Http/Controllers/MembersController.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
     public function index()
     {
-        $users = $this->userRepository->getActivePublicList(!\Auth::guest());
+        $users = $this->userRepository->getActivePublicList( ! \Auth::guest());
         return \View::make('members.index')->withUsers($users);
     }
 
@@ -44,7 +44,7 @@ 
             return \Response::make('', 404);
         }
 
-        if (!$user->active) {
+        if ( ! $user->active) {
             return \Response::make('', 404);
         }