ArthurGuy / BBMembershipSystem

app/Repo/ACSNodeRepository.php

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
             throw new ModelNotFoundException();
         }
         $node = $this->model->where('api_key', $apiKey)->first();
-        if (!$node) {
+        if ( ! $node) {
             throw new ModelNotFoundException();
         }
         return $node;
@@ -55,7 +55,7 @@ 
     public function logBoot($device)
     {
         $record = $this->model->where('device_id', $device)->first();
-        if (!$record) {
+        if ( ! $record) {
             $record = $this->createRecord($device);
         }
         $record->last_boot = Carbon::now();

app/Repo/PaymentRepository.php

Spacing +2 added lines, -2 removed lines

@@ -188,7 +188,7 @@ 
     {
         $payment = $this->getById($paymentId);
 
-        if (!empty($payment->user_id)) {
+        if ( ! empty($payment->user_id)) {
             throw new PaymentException('Payment already assigned to user');
         }
 
@@ -266,7 +266,7 @@ 
      */
     public function getEquipmentFeePayments($referencePrefix)
     {
-        return $this->model->where('reason', 'equipment-fee')->get()->filter(function($payment) use($referencePrefix) {
+        return $this->model->where('reason', 'equipment-fee')->get()->filter(function ($payment) use($referencePrefix) {
             return strpos($payment->reference, ':' . $referencePrefix) !== false;
         });
     }

app/Services/Registrar.php

Indentation +28 added lines, -28 removed lines

@@ -6,34 +6,34 @@
 
 class Registrar implements RegistrarContract {
 
-	/**
-	 * Get a validator for an incoming registration request.
-	 *
-	 * @param  array  $data
-	 * @return \Illuminate\Contracts\Validation\Validator
-	 */
-	public function validator(array $data)
-	{
-		return Validator::make($data, [
-			'name' => 'required|max:255',
-			'email' => 'required|email|max:255|unique:users',
-			'password' => 'required|confirmed|min:6',
-		]);
-	}
+    /**
+     * Get a validator for an incoming registration request.
+     *
+     * @param  array  $data
+     * @return \Illuminate\Contracts\Validation\Validator
+     */
+    public function validator(array $data)
+    {
+        return Validator::make($data, [
+            'name' => 'required|max:255',
+            'email' => 'required|email|max:255|unique:users',
+            'password' => 'required|confirmed|min:6',
+        ]);
+    }
 
-	/**
-	 * Create a new user instance after a valid registration.
-	 *
-	 * @param  array  $data
-	 * @return User
-	 */
-	public function create(array $data)
-	{
-		return User::create([
-			'name' => $data['name'],
-			'email' => $data['email'],
-			'password' => bcrypt($data['password']),
-		]);
-	}
+    /**
+     * Create a new user instance after a valid registration.
+     *
+     * @param  array  $data
+     * @return User
+     */
+    public function create(array $data)
+    {
+        return User::create([
+            'name' => $data['name'],
+            'email' => $data['email'],
+            'password' => bcrypt($data['password']),
+        ]);
+    }
 
 }

Braces +2 added lines, -1 removed lines

@@ -4,7 +4,8 @@
 use Validator;
 use Illuminate\Contracts\Auth\Registrar as RegistrarContract;
 
-class Registrar implements RegistrarContract {
+class Registrar implements RegistrarContract
+{
 
 	/**
 	 * Get a validator for an incoming registration request.

app/Http/Controllers/DeviceController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Contracts\Validation\UnauthorizedException;
 use Illuminate\Http\Request;
 use Auth;
-use BB\Http\Requests;
 
 
 class NotificationController extends Controller

app/Http/Controllers/CCTVController.php

Spacing +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 
                 $equipment->addPhoto($newFilename);
 
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 \Log::error($e);
                 throw new ImageFailedException($e->getMessage());
             }

app/Repo/UserRepository.php

Spacing +2 added lines, -2 removed lines

@@ -109,7 +109,7 @@ 
 
         $memberData['hash'] = str_random(30);
 
-        $memberData['rules_agreed'] = $memberData['rules_agreed']? Carbon::now(): null;
+        $memberData['rules_agreed'] = $memberData['rules_agreed'] ? Carbon::now() : null;
 
         $user = $this->model->create($memberData);
         $this->profileDataRepository->createProfile($user->id);
@@ -218,7 +218,7 @@ 
 
         $user->induction_completed = true;
 
-        $user->rules_agreed = $user->rules_agreed? $user->rules_agreed: Carbon::now();
+        $user->rules_agreed = $user->rules_agreed ? $user->rules_agreed : Carbon::now();
 
         $user->save();
     }

Doc Comments +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
     /**
      * Record the fact that the user has agreed to the member induction and the rules
      *
-     * @param $userId
+     * @param integer $userId
      */
     public function recordInductionCompleted($userId)
     {

app/Http/Controllers/AccountController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use BB\Events\MemberGivenTrustedStatus;
 use BB\Events\MemberPhotoWasDeclined;
 use BB\Exceptions\ValidationException;
-use BB\Validators\InductionValidator;
 
 class AccountController extends Controller
 {

Spacing +1 added lines, -1 removed lines

@@ -358,7 +358,7 @@
 
         if ($amount < 5) {
             throw new ValidationException('The minimum subscription is 5 GBP');
-        } elseif (!\Auth::user()->isAdmin() && ($amount < 15)) {
+        } elseif ( ! \Auth::user()->isAdmin() && ($amount < 15)) {
             throw new ValidationException('The minimum subscription is 15 GBP, please contact the trustees for a lower amount. trustees@buildbrighton.com');
         }
 

app/Http/Controllers/MemberInductionController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Contracts\Validation\UnauthorizedException;
 use Illuminate\Http\Request;
 use Auth;
-use BB\Http\Requests;
 
 
 class NotificationController extends Controller

app/Http/routes.php

Spacing +17 added lines, -17 removed lines

@@ -65,7 +65,7 @@ 
 
 Route::post('account/{account}/payment', ['uses' => 'PaymentController@store', 'as' => 'account.payment.store', 'middleware' => 'role:admin']);
 
-Route::group(array('middleware' => 'role:finance'), function() {
+Route::group(array('middleware' => 'role:finance'), function () {
     Route::resource('payments', 'PaymentController', ['only' => ['index', 'destroy', 'update']]);
     Route::get('payments/overview', ['uses'=>'PaymentOverviewController@index', 'as'=>'payments.overview']);
     Route::get('payments/sub-charges', ['as' => 'payments.sub-charges', 'uses' => 'SubscriptionController@listCharges']);
@@ -84,13 +84,13 @@ 
 
 
 //Cash
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::post('account/{account}/payment/cash/create', ['as'=>'account.payment.cash.create', 'uses' => 'CashPaymentController@store']);
     Route::delete('account/{account}/payment/cash', ['as'=>'account.payment.cash.destroy', 'uses' => 'CashPaymentController@destroy']);
 });
 
 # Statements
-Route::group(array('middleware' => 'role:finance'), function() {
+Route::group(array('middleware' => 'role:finance'), function () {
     Route::resource('statement-import', 'StatementImportController', ['except' => ['index', 'show', 'edit', 'update', 'destroy']]);
 });
 
@@ -103,7 +103,7 @@ 
 # Inductions
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::post('equipment_training/update', ['uses'=>'InductionController@update', 'as'=>'equipment_training.update']);
     Route::resource('account.induction', 'InductionController', ['only' => ['update', 'destroy']]);
 });
@@ -114,7 +114,7 @@ 
 # Equipment
 ##########################
 
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('equipment', 'EquipmentController');
     Route::post('equipment/{id}/photo', ['uses'=>'EquipmentController@addPhoto', 'as'=>'equipment.photo.store']);
     Route::delete('equipment/{id}/photo/{key}', ['uses'=>'EquipmentController@destroyPhoto', 'as'=>'equipment.photo.destroy']);
@@ -137,7 +137,7 @@ 
 # Key fobs
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('keyfob', 'KeyFobController', ['only' => ['index', 'store', 'update', 'destroy']]);
 });
 
@@ -169,11 +169,11 @@ 
 
 Route::post('camera/event/store', ['uses' => 'CCTVController@store']);
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('detected_devices', 'DetectedDevicesController');
 });
 
-Route::group(array('middleware' => 'role:acs'), function() {
+Route::group(array('middleware' => 'role:acs'), function () {
     Route::resource('devices', 'DeviceController');
 });
 
@@ -249,11 +249,11 @@ 
 # Roles
 ##########################
 
-Route::group(array('middleware' => 'role:admin'), function() {
+Route::group(array('middleware' => 'role:admin'), function () {
     Route::resource('roles', 'RolesController', []);
     Route::resource('roles.users', 'RoleUsersController', ['only' => ['destroy', 'store']]);
 });
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('groups', 'GroupsController', ['only' => ['index', 'show']]);
 });
 
@@ -272,7 +272,7 @@ 
 # Expenses
 ##########################
 
-Route::group(array('middleware' => 'role:member'), function() {
+Route::group(array('middleware' => 'role:member'), function () {
     Route::resource('expenses', 'ExpensesController');
 });
 
@@ -289,10 +289,10 @@ 
 
 
 
-Route::any('api-docs.json', function() {
+Route::any('api-docs.json', function () {
     $filePath = Config::get('swagger.doc-dir') . "/api-docs.json";
 
-    if (!File::Exists($filePath)) {
+    if ( ! File::Exists($filePath)) {
         App::abort(404, "Cannot find {$filePath}");
     }
 
@@ -302,13 +302,13 @@ 
     ));
 });
 
-Route::get('api-docs', function() {
+Route::get('api-docs', function () {
     if (Config::get('swagger.generateAlways')) {
-        $appDir = base_path()."/".Config::get('swagger.app-dir');
+        $appDir = base_path() . "/" . Config::get('swagger.app-dir');
         $docDir = Config::get('swagger.doc-dir');
 
 
-        if (!File::exists($docDir) || is_writable($docDir)) {
+        if ( ! File::exists($docDir) || is_writable($docDir)) {
             // delete all existing documentation
             if (File::exists($docDir)) {
                 File::deleteDirectory($docDir);
@@ -318,7 +318,7 @@ 
 
             $excludeDirs = Config::get('swagger.excludes');
 
-            $swagger =  \Swagger\scan($appDir, [
+            $swagger = \Swagger\scan($appDir, [
                 'exclude' => $excludeDirs
             ]);