BB\Http\Controllers\AccountController

Complexity

Total Complexity

44

Size/Duplication

Total Lines	388
Duplicated Lines	4.38 %

Coupling/Cohesion

Components	2
Dependencies	17

Importance

Changes	4
Bugs	0	Features	1

15 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	46	2
A	index()	0	8	1
A	create()	0	5	1
B	store()	0	27	6
B	show()	0	24	4
A	induction()	0	6	1
A	updateInduction()	0	12	1
A	edit()	0	9	1
A	update()	0	12	1
F	adminUpdate()	0	70	15
A	alterSubscription()	0	20	4
A	confirmEmail()	0	11	3
A	destroy()	10	10	1
A	rejoin()	7	7	1
A	updateSubscriptionAmount()	0	13	2

<?php namespace BB\Http\Controllers;


use BB\Entities\Notification;
use BB\Entities\User;
use BB\Events\MemberGivenTrustedStatus;
use BB\Events\MemberPhotoWasDeclined;
use BB\Exceptions\ValidationException;
use BB\Validators\InductionValidator;

class AccountController extends Controller
{

    protected $layout = 'layouts.main';

    protected $userForm;

    /**
     * @var \BB\Helpers\UserImage
     */
    private $userImage;
    /**
     * @var \BB\Validators\UserDetails
     */
    private $userDetailsForm;
    /**
     * @var \BB\Repo\ProfileDataRepository
     */
    private $profileRepo;
    /**
     * @var \BB\Repo\InductionRepository
     */
    private $inductionRepository;
    /**
     * @var \BB\Repo\EquipmentRepository
     */
    private $equipmentRepository;
    /**
     * @var \BB\Repo\UserRepository
     */
    private $userRepository;
    /**
     * @var \BB\Validators\ProfileValidator
     */
    private $profileValidator;
    /**
     * @var \BB\Repo\AddressRepository
     */
    private $addressRepository;
    /**
     * @var \BB\Repo\SubscriptionChargeRepository
     */
    private $subscriptionChargeRepository;
    /**
     * @var InductionValidator
     */
    private $inductionValidator;


    function __construct(

It is generally recommended to explicitly declare the visibility for methods.

        \BB\Validators\UserValidator $userForm,
        \BB\Validators\UpdateSubscription $updateSubscriptionAdminForm,
        \BB\Helpers\GoCardlessHelper $goCardless,
        \BB\Helpers\UserImage $userImage,
        \BB\Validators\UserDetails $userDetailsForm,
        \BB\Repo\ProfileDataRepository $profileRepo,
        \BB\Repo\InductionRepository $inductionRepository,
        \BB\Repo\EquipmentRepository $equipmentRepository,
        \BB\Repo\UserRepository $userRepository,
        \BB\Validators\ProfileValidator $profileValidator,
        \BB\Repo\AddressRepository $addressRepository,
        \BB\Repo\SubscriptionChargeRepository $subscriptionChargeRepository,
        InductionValidator $inductionValidator)
    {
        $this->userForm = $userForm;
        $this->updateSubscriptionAdminForm = $updateSubscriptionAdminForm;

The property updateSubscriptionAdminForm does not exist. Did you maybe forget to declare it?

        $this->goCardless = $goCardless;

The property goCardless does not exist. Did you maybe forget to declare it?

        $this->userImage = $userImage;
        $this->userDetailsForm = $userDetailsForm;
        $this->profileRepo = $profileRepo;
        $this->inductionRepository = $inductionRepository;
        $this->equipmentRepository = $equipmentRepository;
        $this->userRepository = $userRepository;
        $this->profileValidator = $profileValidator;
        $this->addressRepository = $addressRepository;
        $this->subscriptionChargeRepository = $subscriptionChargeRepository;
        $this->inductionValidator = $inductionValidator;

        //This tones down some validation rules for admins
        $this->userForm->setAdminOverride( ! \Auth::guest() && \Auth::user()->hasRole('admin'));

        $this->middleware('role:member', array('except' => ['create', 'store']));
        $this->middleware('role:admin', array('only' => ['index']));
        //$this->middleware('guest', array('only' => ['create', 'store']));

78% of this comment could be valid code. Did you maybe forget this after debugging?

        $paymentMethods = [
            'gocardless'    => 'GoCardless',
            'paypal'        => 'PayPal',
            'bank-transfer' => 'Manual Bank Transfer',
            'other'         => 'Other'
        ];
        \View::share('paymentMethods', $paymentMethods);
        \View::share('paymentDays', array_combine(range(1, 31), range(1, 31)));

    }

    /**
     * Display a listing of the resource.
     *
     * @return Response
     */
    public function index()
    {
        $sortBy = \Request::get('sortBy');
        $direction = \Request::get('direction', 'asc');
        $showLeft = \Request::get('showLeft', 0);
        $users = $this->userRepository->getPaginated(compact('sortBy', 'direction', 'showLeft'));
        return \View::make('account.index')->withUsers($users);
    }


    /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()
    {
        \View::share('body_class', 'register_login');
        return \View::make('account.create');
    }


    /**
     * Store a newly created resource in storage.
     *
     * @return Illuminate\Http\RedirectResponse
     */
    public function store()
    {
        $input = \Input::only('given_name', 'family_name', 'email', 'secondary_email', 'password', 'phone', 'address.line_1', 'address.line_2', 'address.line_3', 'address.line_4', 'address.postcode', 'monthly_subscription', 'emergency_contact', 'new_profile_photo', 'profile_photo_private', 'rules_agreed');

        $this->userForm->validate($input);
        $this->profileValidator->validate($input);


        $user = $this->userRepository->registerMember($input, ! \Auth::guest() && \Auth::user()->hasRole('admin'));

        if (\Input::file('new_profile_photo')) {
            try {
                $this->userImage->uploadPhoto($user->hash, \Input::file('new_profile_photo')->getRealPath(), true);

                $this->profileRepo->update($user->id, ['new_profile_photo'=>1, 'profile_photo_private'=>$input['profile_photo_private']]);
            } catch (\Exception $e) {
                \Log::error($e);
            }
        }

        //If this isn't an admin user creating the record log them in
        if (\Auth::guest() || ! \Auth::user()->isAdmin()) {
            \Auth::login($user);
        }

        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }


    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return Response
     */
    public function show($id)
    {
        $user = User::findWithPermission($id);

        $inductions = $this->equipmentRepository->getRequiresInduction();

        $userInductions = $user->inductions()->get();
        foreach ($inductions as $i=>$induction) {
            $inductions[$i]->userInduction = false;
            foreach ($userInductions as $userInduction) {
                if ($userInduction->key == $induction->device_key) {
                    $inductions[$i]->userInduction = $userInduction;
                }
            }
        }

        //get pending address if any
        $newAddress = $this->addressRepository->getNewUserAddress($id);

        //Get the member subscription payments
        $subscriptionCharges = $this->subscriptionChargeRepository->getMemberChargesPaginated($id);

        return \View::make('account.show')->with('user', $user)->with('inductions', $inductions)->with('newAddress', $newAddress)->with('subscriptionCharges', $subscriptionCharges);
    }

    public function induction($id)
    {
        $user = User::findWithPermission($id);

        return view('account.induction')->with('user', $user);

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    public function updateInduction($id)
    {
        $user = User::findWithPermission($id);

        $input = \Input::only('rules_agreed', 'induction_completed');

        $this->inductionValidator->validate($input);

        $this->userRepository->recordInductionCompleted($id);

        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }


    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return Response
     */
    public function edit($id)
    {
        $user = User::findWithPermission($id);

        //We need to access the address here so its available in the view
        $user->address;

The property address does not exist on object<BB\Entities\User>. Since you implemented __get, maybe consider adding a @property annotation.

        return \View::make('account.edit')->with('user', $user);
    }


    /**
     * Update the specified resource in storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update($id)
    {
        $user = User::findWithPermission($id);
        $input = \Input::only('given_name', 'family_name', 'email', 'secondary_email', 'password', 'phone', 'address.line_1', 'address.line_2', 'address.line_3', 'address.line_4', 'address.postcode', 'emergency_contact', 'profile_private');

        $this->userForm->validate($input, $user->id);

        $this->userRepository->updateMember($id, $input, \Auth::user()->hasRole('admin'));

        \Notification::success('Details Updated');
        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }



    public function adminUpdate($id)
    {
        $user = User::findWithPermission($id);

        $madeTrusted = false;


        if (\Input::has('trusted')) {
            if ( ! $user->trusted && \Input::get('trusted')) {
                //User has been made a trusted member
                $madeTrusted = true;
            }
            $user->trusted = \Input::get('trusted');
        }

        if (\Input::has('key_holder')) {
            $user->key_holder = \Input::get('key_holder');
        }

        if (\Input::has('induction_completed')) {
            $user->induction_completed = \Input::get('induction_completed');
        }

        if (\Input::has('profile_photo_on_wall')) {
            $profileData = $user->profile()->first();
            $profileData->profile_photo_on_wall = \Input::get('profile_photo_on_wall');
            $profileData->save();
        }

        if (\Input::has('photo_approved')) {
            $profile = $user->profile()->first();

            if (\Input::get('photo_approved')) {
                $this->userImage->approveNewImage($user->hash);
                $profile->update(['new_profile_photo' => false, 'profile_photo' => true]);
            } else {
                $profile->update(['new_profile_photo' => false]);
                event(new MemberPhotoWasDeclined($user));
            }
        }

        if (\Input::has('inducted_by')) {
            $user->inducted_by = \Auth::id();

The property inducted_by does not exist on object<BB\Entities\User>. Since you implemented __set, maybe consider adding a @property annotation.

        }

        $user->save();

        if (\Input::has('approve_new_address')) {
            if (\Input::get('approve_new_address') == 'Approve') {
                $this->addressRepository->approvePendingMemberAddress($id);
            } elseif (\Input::get('approve_new_address') == 'Decline') {
                $this->addressRepository->declinePendingMemberAddress($id);
            }
        }

        if ($madeTrusted) {
            $message = 'You have been made a trusted member at Build Brighton';
            $notificationHash = 'trusted_status';
            Notification::logNew($user->id, $message, 'trusted_status', $notificationHash);
            event(new MemberGivenTrustedStatus($user));
        }


        if (\Request::wantsJson()) {
            return \Response::json('Updated', 200);
        } else {
            \Notification::success('Details Updated');
            return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

        }
    }


    public function alterSubscription($id)
    {
        $user = User::findWithPermission($id);
        $input = \Input::all();

        $this->updateSubscriptionAdminForm->validate($input, $user->id);

        if (($user->payment_method == 'gocardless') && ($input['payment_method'] != 'gocardless')) {
            //Changing away from GoCardless
            $subscription = $this->goCardless->cancelSubscription($user->subscription_id);
            if ($subscription->status == 'cancelled') {
                $user->cancelSubscription();

The method BB\Entities\User::cancelSubscription() has been deprecated.

            }
        }

        $user->updateSubscription($input['payment_method'], $input['payment_day']);

The method BB\Entities\User::updateSubscription() has been deprecated.

        \Notification::success('Details Updated');
        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }

    public function confirmEmail($id, $hash)
    {
        $user = User::find($id);
        if ($user && $user->hash == $hash) {
            $user->emailConfirmed();
            \Notification::success('Email address confirmed, thank you');
            return \Redirect::route('account.show', $user->id);

The method route() does not seem to exist on object<redirect>.

        }
        \Notification::error('Error confirming email address');
        return \Redirect::route('home');

The method route() does not seem to exist on object<redirect>.

    }



    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $user = User::findWithPermission($id);

        //No one will ever leaves the system but we can at least update their status to left.
        $user->setLeaving();

The method BB\Entities\User::setLeaving() has been deprecated.

        \Notification::success('Updated status to leaving');
        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }


    public function rejoin($id)

This method seems to be duplicated in your project.

    {
        $user = User::findWithPermission($id);
        $user->rejoin();

The method BB\Entities\User::rejoin() has been deprecated.

        \Notification::success('Details Updated');
        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }

    public function updateSubscriptionAmount($id)
    {
        $amount = \Input::get('monthly_subscription');

        if ($amount < 5) {
            throw new ValidationException('The minimum subscription is 5 GBP');
        }

        $user = User::findWithPermission($id);
        $user->updateSubAmount(\Input::get('monthly_subscription'));

The method BB\Entities\User::updateSubAmount() has been deprecated.

        \Notification::success('Details Updated');
        return \Redirect::route('account.show', [$user->id]);

The method route() does not seem to exist on object<redirect>.

    }
}